* [PATCH] staging: rtl8723bs: Use % 4096 instead of & 0xfff
@ 2025-04-04 23:33 Abraham Samuel Adekunle
2025-04-05 9:13 ` David Laight
0 siblings, 1 reply; 3+ messages in thread
From: Abraham Samuel Adekunle @ 2025-04-04 23:33 UTC (permalink / raw)
To: Greg Kroah-Hartman, Julia Lawall, outreachy
Cc: linux-staging, linux-kernel, Dan Carpenter, "andy."
Replace the bitwise AND operator `&` with a modulo
operator `%` and decimal number to make the upper limit visible
and clear what the semantic of it is.
Also add white spaces around binary operators for improved
readabiity and adherence to Linux kernel coding style.
Suggested-by Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Abraham Samuel Adekunle <abrahamadekunle50@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_xmit.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c
index 297c93d65315..630669193be4 100644
--- a/drivers/staging/rtl8723bs/core/rtw_xmit.c
+++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c
@@ -943,7 +943,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr, struct pkt_attrib *pattr
if (psta) {
psta->sta_xmitpriv.txseq_tid[pattrib->priority]++;
- psta->sta_xmitpriv.txseq_tid[pattrib->priority] &= 0xFFF;
+ psta->sta_xmitpriv.txseq_tid[pattrib->priority] %= 4096;
pattrib->seqnum = psta->sta_xmitpriv.txseq_tid[pattrib->priority];
SetSeqNum(hdr, pattrib->seqnum);
@@ -963,11 +963,11 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr, struct pkt_attrib *pattr
if (SN_LESS(pattrib->seqnum, tx_seq)) {
pattrib->ampdu_en = false;/* AGG BK */
} else if (SN_EQUAL(pattrib->seqnum, tx_seq)) {
- psta->BA_starting_seqctrl[pattrib->priority & 0x0f] = (tx_seq+1)&0xfff;
+ psta->BA_starting_seqctrl[pattrib->priority & 0x0f] = (tx_seq + 1) % 4096;
pattrib->ampdu_en = true;/* AGG EN */
} else {
- psta->BA_starting_seqctrl[pattrib->priority & 0x0f] = (pattrib->seqnum+1)&0xfff;
+ psta->BA_starting_seqctrl[pattrib->priority & 0x0f] = (pattrib->seqnum + 1) % 4096;
pattrib->ampdu_en = true;/* AGG EN */
}
}
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] staging: rtl8723bs: Use % 4096 instead of & 0xfff
2025-04-04 23:33 [PATCH] staging: rtl8723bs: Use % 4096 instead of & 0xfff Abraham Samuel Adekunle
@ 2025-04-05 9:13 ` David Laight
2025-04-06 21:55 ` Samuel Abraham
0 siblings, 1 reply; 3+ messages in thread
From: David Laight @ 2025-04-05 9:13 UTC (permalink / raw)
To: Abraham Samuel Adekunle
Cc: Greg Kroah-Hartman, Julia Lawall, outreachy, linux-staging,
linux-kernel, Dan Carpenter, "andy."
On Fri, 4 Apr 2025 23:33:16 +0000
Abraham Samuel Adekunle <abrahamadekunle50@gmail.com> wrote:
> Replace the bitwise AND operator `&` with a modulo
> operator `%` and decimal number to make the upper limit visible
> and clear what the semantic of it is.
Use 4096u to make absolutely certain an unsigned module is used.
David
>
> Also add white spaces around binary operators for improved
> readabiity and adherence to Linux kernel coding style.
>
> Suggested-by Andy Shevchenko <andy.shevchenko@gmail.com>
>
> Signed-off-by: Abraham Samuel Adekunle <abrahamadekunle50@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_xmit.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c
> index 297c93d65315..630669193be4 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c
> @@ -943,7 +943,7 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr, struct pkt_attrib *pattr
>
> if (psta) {
> psta->sta_xmitpriv.txseq_tid[pattrib->priority]++;
> - psta->sta_xmitpriv.txseq_tid[pattrib->priority] &= 0xFFF;
> + psta->sta_xmitpriv.txseq_tid[pattrib->priority] %= 4096;
> pattrib->seqnum = psta->sta_xmitpriv.txseq_tid[pattrib->priority];
>
> SetSeqNum(hdr, pattrib->seqnum);
> @@ -963,11 +963,11 @@ s32 rtw_make_wlanhdr(struct adapter *padapter, u8 *hdr, struct pkt_attrib *pattr
> if (SN_LESS(pattrib->seqnum, tx_seq)) {
> pattrib->ampdu_en = false;/* AGG BK */
> } else if (SN_EQUAL(pattrib->seqnum, tx_seq)) {
> - psta->BA_starting_seqctrl[pattrib->priority & 0x0f] = (tx_seq+1)&0xfff;
> + psta->BA_starting_seqctrl[pattrib->priority & 0x0f] = (tx_seq + 1) % 4096;
>
> pattrib->ampdu_en = true;/* AGG EN */
> } else {
> - psta->BA_starting_seqctrl[pattrib->priority & 0x0f] = (pattrib->seqnum+1)&0xfff;
> + psta->BA_starting_seqctrl[pattrib->priority & 0x0f] = (pattrib->seqnum + 1) % 4096;
> pattrib->ampdu_en = true;/* AGG EN */
> }
> }
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] staging: rtl8723bs: Use % 4096 instead of & 0xfff
2025-04-05 9:13 ` David Laight
@ 2025-04-06 21:55 ` Samuel Abraham
0 siblings, 0 replies; 3+ messages in thread
From: Samuel Abraham @ 2025-04-06 21:55 UTC (permalink / raw)
To: David Laight
Cc: Greg Kroah-Hartman, Julia Lawall, outreachy, linux-staging,
linux-kernel, Dan Carpenter
On Sat, Apr 5, 2025 at 10:13 AM David Laight
<david.laight.linux@gmail.com> wrote:
>
> On Fri, 4 Apr 2025 23:33:16 +0000
> Abraham Samuel Adekunle <abrahamadekunle50@gmail.com> wrote:
>
> > Replace the bitwise AND operator `&` with a modulo
> > operator `%` and decimal number to make the upper limit visible
> > and clear what the semantic of it is.
>
> Use 4096u to make absolutely certain an unsigned module is used.
Hello David,
Thank you very much for this suggestion.
Adekunle.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-06 21:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-04 23:33 [PATCH] staging: rtl8723bs: Use % 4096 instead of & 0xfff Abraham Samuel Adekunle
2025-04-05 9:13 ` David Laight
2025-04-06 21:55 ` Samuel Abraham
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox