From: Dave Penkler <dpenkler@gmail.com>
To: Michael Rubin <matchstick@neverthere.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 00/20] Removing typedef for gpib_board
Date: Thu, 20 Mar 2025 09:18:00 +0100 [thread overview]
Message-ID: <Z9vPOKAFv3Jw5l1r@egonzo> (raw)
In-Reply-To: <20250319215924.19387-1-matchstick@neverthere.org>
On Wed, Mar 19, 2025 at 09:59:04PM +0000, Michael Rubin wrote:
> staging: gpib: Removing typedef for gpib_board
>
> Adhering to Linux code style.
>
> In general, a pointer, or a struct that has elements that can reasonably be
> directly accessed should never be a typedef.
>
> * Patch 1: struct typing for gpib_board
>
> Introduces struct gpib_board replacing gpib_board_t
>
> * Patch 2 - Patch 18
>
> Adopting "struct gpib_board" as opposed to "gpib_board_t" for each
> subsystem in gpib.
>
> * staging: gpib: agilent_82350b: struct gpib_board
> * staging: gpib: agilent_82357a: struct gpib_board
> * staging: gpib: cb7210: struct gpib_board
> * staging: gpib: cec_gpib: struct gpib_board
> * staging: gpib: common: struct gpib_board
> * staging: gpib: eastwood: struct gpib_board
> * staging: gpib: fmh_gpib: struct gpib_board
> * staging: gpib: gpio: struct gpib_board
> * staging: gpib: hp2335: struct gpib_board
> * staging: gpib: hp_82341: struct gpib_board
> * staging: gpib: ines: struct gpib_board
> * staging: gpib: lpvo_usb_gpib: struct gpib_board
> * staging: gpib: nec7210 struct gpib_board
> * staging: gpib: ni_usb_gpib: struct gpib_board
> * staging: gpib: pc2: struct gpib_board
> * staging: gpib: tms9914: struct gpib_board
> * staging: gpib: tnt4882: struct gpib_board
>
> * Patch 19: staging: gpib: struct typing for gpib_gboard_t
>
> Adopting "struct gbip_board" as opposed to "gpib_board_t" for include files.
>
> * Patch 20: staging: gpib: Removing typedef for gpib_board
>
> Removing typedef for gpib_board_t
>
> Michael Rubin (20):
> staging: gpib: struct typing for gpib_board
> staging: gpib: agilent_82350b: struct gpib_board
> staging: gpib: agilent_82357a: struct gpib_board
> staging: gpib: cb7210: struct gpib_board
> staging: gpib: cec_gpib: struct gpib_board
> staging: gpib: common: struct gpib_board
> staging: gpib: eastwood: struct gpib_board
> staging: gpib: fmh_gpib: struct gpib_board
> staging: gpib: gpio: struct gpib_board
> staging: gpib: hp2335: struct gpib_board
> staging: gpib: hp_82341: struct gpib_board
> staging: gpib: ines: struct gpib_board
> staging: gpib: lpvo_usb_gpib: struct gpib_board
> staging: gpib: nec7210 struct gpib_board
> staging: gpib: ni_usb_gpib: struct gpib_board
> staging: gpib: pc2: struct gpib_board
> staging: gpib: tms9914: struct gpib_board
> staging: gpib: tnt4882: struct gpib_board
> staging: gpib: struct typing for gpib_gboard_t
> staging: gpib: Removing typedef for gpib_board
>
> .../gpib/agilent_82350b/agilent_82350b.c | 99 +++++----
> .../gpib/agilent_82357a/agilent_82357a.c | 85 ++++----
> drivers/staging/gpib/cb7210/cb7210.c | 107 +++++-----
> drivers/staging/gpib/cec/cec_gpib.c | 59 +++---
> drivers/staging/gpib/common/gpib_os.c | 196 +++++++++---------
> drivers/staging/gpib/common/iblib.c | 50 ++---
> drivers/staging/gpib/common/ibsys.h | 14 +-
> drivers/staging/gpib/eastwood/fluke_gpib.c | 93 +++++----
> drivers/staging/gpib/fmh_gpib/fmh_gpib.c | 122 +++++------
> drivers/staging/gpib/gpio/gpib_bitbang.c | 72 +++----
> drivers/staging/gpib/hp_82335/hp82335.c | 56 ++---
> drivers/staging/gpib/hp_82341/hp_82341.c | 68 +++---
> drivers/staging/gpib/include/gpibP.h | 10 +-
> drivers/staging/gpib/include/gpib_proto.h | 58 +++---
> drivers/staging/gpib/include/gpib_types.h | 58 +++---
> drivers/staging/gpib/include/nec7210.h | 58 +++---
> drivers/staging/gpib/include/tms9914.h | 52 ++---
> drivers/staging/gpib/ines/ines.h | 54 ++---
> drivers/staging/gpib/ines/ines_gpib.c | 111 +++++-----
> .../gpib/lpvo_usb_gpib/lpvo_usb_gpib.c | 66 +++---
> drivers/staging/gpib/nec7210/nec7210.c | 76 +++----
> drivers/staging/gpib/ni_usb/ni_usb_gpib.c | 70 +++----
> drivers/staging/gpib/pc2/pc2_gpib.c | 68 +++---
> drivers/staging/gpib/tms9914/tms9914.c | 66 +++---
> drivers/staging/gpib/tnt4882/tnt4882_gpib.c | 100 ++++-----
> 25 files changed, 947 insertions(+), 921 deletions(-)
>
> --
> 2.43.0
>
Acked-By: Dave Penkler <dpenkler@gmail.com>
prev parent reply other threads:[~2025-03-20 8:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 21:59 [PATCH v1 00/20] Removing typedef for gpib_board Michael Rubin
2025-03-19 21:59 ` [PATCH v1 01/20] staging: gpib: struct typing " Michael Rubin
2025-03-19 21:59 ` [PATCH v1 02/20] staging: gpib: agilent_82350b: struct gpib_board Michael Rubin
2025-03-19 21:59 ` [PATCH v1 03/20] staging: gpib: agilent_82357a: " Michael Rubin
2025-03-19 21:59 ` [PATCH v1 04/20] staging: gpib: cb7210: " Michael Rubin
2025-03-19 21:59 ` [PATCH v1 05/20] staging: gpib: cec_gpib: " Michael Rubin
2025-03-19 21:59 ` [PATCH v1 06/20] staging: gpib: common: " Michael Rubin
2025-03-19 21:59 ` [PATCH v1 07/20] staging: gpib: eastwood: " Michael Rubin
2025-03-19 21:59 ` [PATCH v1 08/20] staging: gpib: fmh_gpib: " Michael Rubin
2025-03-19 21:59 ` [PATCH v1 09/20] staging: gpib: gpio: " Michael Rubin
2025-03-19 21:59 ` [PATCH v1 10/20] staging: gpib: hp2335: " Michael Rubin
2025-03-19 21:59 ` [PATCH v1 11/20] staging: gpib: hp_82341: " Michael Rubin
2025-03-19 21:59 ` [PATCH v1 12/20] staging: gpib: ines: " Michael Rubin
2025-03-19 21:59 ` [PATCH v1 13/20] staging: gpib: lpvo_usb_gpib: " Michael Rubin
2025-03-19 21:59 ` [PATCH v1 14/20] staging: gpib: nec7210 " Michael Rubin
2025-03-19 21:59 ` [PATCH v1 15/20] staging: gpib: ni_usb_gpib: " Michael Rubin
2025-03-19 21:59 ` [PATCH v1 16/20] staging: gpib: pc2: " Michael Rubin
2025-03-19 21:59 ` [PATCH v1 17/20] staging: gpib: tms9914: " Michael Rubin
2025-03-19 21:59 ` [PATCH v1 18/20] staging: gpib: tnt4882: " Michael Rubin
2025-03-19 21:59 ` [PATCH v1 19/20] staging: gpib: struct typing for gpib_gboard_t Michael Rubin
2025-03-19 21:59 ` [PATCH v1 20/20] staging: gpib: Removing typedef for gpib_board Michael Rubin
2025-03-20 8:18 ` Dave Penkler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9vPOKAFv3Jw5l1r@egonzo \
--to=dpenkler@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=matchstick@neverthere.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox