From: Daniel Watson <ozzloy@gmail.com>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: av7110: put spaces around operators
Date: Tue, 21 Mar 2023 11:30:26 -0700 [thread overview]
Message-ID: <ZBn3wmTkcZ0WC6iW@trent-reznor> (raw)
In-Reply-To: <487b75ea-aecd-5fdc-c2a2-5f5080f8647e@xs4all.nl>
On Tue, Mar 21, 2023 at 04:08:30PM +0100, Hans Verkuil wrote:
> Hi Daniel,
>
Hi!
> I'm not sure what the point it of these two fixes since this driver is
> full of such things.
these fixes were the only ones where checkpatch said "spaces required
around that ..." for this file.
> In any case, I'm rejecting this. Just leave this driver alone, it's not
> worth the effort.
ok.
> If you are doing this as part of some mentorship program, then skip the
i'm doing this on my own. i read that newbies should do about 10 minor
patches to get familiar with the process before doing something more
substantial.
> drivers/staging/media directory, it's not suitable for that.
ok, i'll try other drivers in staging. i'll also see about getting a
mentor.
thanks again!
prev parent reply other threads:[~2023-03-21 18:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 6:45 [PATCH] media: av7110: put spaces around operators Daniel Watson
2023-03-21 15:08 ` Hans Verkuil
2023-03-21 18:30 ` Daniel Watson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBn3wmTkcZ0WC6iW@trent-reznor \
--to=ozzloy@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox