[PATCH] media: av7110: put spaces around operators

[PATCH] media: av7110: put spaces around operators

[Daniel Watson]

put spaces around '=' and '<=' to match style from checkpatch

Signed-off-by: Daniel Watson <ozzloy@gmail.com>
---
 drivers/staging/media/av7110/av7110_hw.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/media/av7110/av7110_hw.h b/drivers/staging/media/av7110/av7110_hw.h
index 6380d8950c695..3274146c401f1 100644
--- a/drivers/staging/media/av7110/av7110_hw.h
+++ b/drivers/staging/media/av7110/av7110_hw.h
@@ -402,8 +402,8 @@ static inline u32 irdebi(struct av7110 *av7110, u32 config, int addr, u32 val, u
 {
 	u32 res;
 
-	res=av7110_debiread(av7110, config, addr, count);
-	if (count<=4)
+	res = av7110_debiread(av7110, config, addr, count);
+	if (count <= 4)
 		memcpy(av7110->debi_virt, (char *) &res, count);
 	return res;
 }
@@ -424,7 +424,7 @@ static inline u32 rdebi(struct av7110 *av7110, u32 config, int addr, u32 val, un
 	u32 res;
 
 	spin_lock_irqsave(&av7110->debilock, flags);
-	res=av7110_debiread(av7110, config, addr, count);
+	res = av7110_debiread(av7110, config, addr, count);
 	spin_unlock_irqrestore(&av7110->debilock, flags);
 	return res;
 }
-- 
2.34.1

Re: [PATCH] media: av7110: put spaces around operators

[Hans Verkuil]

Hi Daniel,

On 21/03/2023 07:45, Daniel Watson wrote:
> put spaces around '=' and '<=' to match style from checkpatch
> 
> Signed-off-by: Daniel Watson <ozzloy@gmail.com>
> ---
>  drivers/staging/media/av7110/av7110_hw.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/media/av7110/av7110_hw.h b/drivers/staging/media/av7110/av7110_hw.h
> index 6380d8950c695..3274146c401f1 100644
> --- a/drivers/staging/media/av7110/av7110_hw.h
> +++ b/drivers/staging/media/av7110/av7110_hw.h
> @@ -402,8 +402,8 @@ static inline u32 irdebi(struct av7110 *av7110, u32 config, int addr, u32 val, u
>  {
>  	u32 res;
>  
> -	res=av7110_debiread(av7110, config, addr, count);
> -	if (count<=4)
> +	res = av7110_debiread(av7110, config, addr, count);
> +	if (count <= 4)
>  		memcpy(av7110->debi_virt, (char *) &res, count);
>  	return res;
>  }
> @@ -424,7 +424,7 @@ static inline u32 rdebi(struct av7110 *av7110, u32 config, int addr, u32 val, un
>  	u32 res;
>  
>  	spin_lock_irqsave(&av7110->debilock, flags);
> -	res=av7110_debiread(av7110, config, addr, count);
> +	res = av7110_debiread(av7110, config, addr, count);
>  	spin_unlock_irqrestore(&av7110->debilock, flags);
>  	return res;
>  }

I'm not sure what the point it of these two fixes since this driver is
full of such things.

In any case, I'm rejecting this. Just leave this driver alone, it's not
worth the effort.

If you are doing this as part of some mentorship program, then skip the
drivers/staging/media directory, it's not suitable for that.

Regards,

	Hans

Re: [PATCH] media: av7110: put spaces around operators

[Daniel Watson]

On Tue, Mar 21, 2023 at 04:08:30PM +0100, Hans Verkuil wrote:
> Hi Daniel,
> 
Hi!

> I'm not sure what the point it of these two fixes since this driver is
> full of such things.
these fixes were the only ones where checkpatch said "spaces required
around that ..." for this file.

> In any case, I'm rejecting this. Just leave this driver alone, it's not
> worth the effort.
ok.

> If you are doing this as part of some mentorship program, then skip the
i'm doing this on my own.  i read that newbies should do about 10 minor
patches to get familiar with the process before doing something more
substantial.

> drivers/staging/media directory, it's not suitable for that.
ok, i'll try other drivers in staging.  i'll also see about getting a
mentor.

thanks again!