* [PATCH 1/3] staging: vt6655: Type encoding info dropped from array name "abyBBVGA"
@ 2023-09-28 15:06 Pavan Bobba
2023-09-28 18:34 ` Philipp Hortmann
0 siblings, 1 reply; 4+ messages in thread
From: Pavan Bobba @ 2023-09-28 15:06 UTC (permalink / raw)
To: Forest Bond, Greg Kroah-Hartman, Michael Straube
Cc: linux-staging, linux-kernel
array name "abyBBVGA" updated like below:
a.type encoding info dropped from name
b.camelcase name replaced by snakecase
Issue found by checkpatch
Signed-off-by: Pavan Bobba <opensource206@gmail.com>
---
drivers/staging/vt6655/baseband.c | 38 ++++++++++++++--------------
drivers/staging/vt6655/channel.c | 4 +--
drivers/staging/vt6655/device.h | 2 +-
drivers/staging/vt6655/device_main.c | 8 +++---
4 files changed, 26 insertions(+), 26 deletions(-)
diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c
index 0ae2ab3987c6..a19a75f5d761 100644
--- a/drivers/staging/vt6655/baseband.c
+++ b/drivers/staging/vt6655/baseband.c
@@ -2016,10 +2016,10 @@ bool bb_vt3253_init(struct vnt_private *priv)
iowrite32(0x23, iobase + MAC_REG_ITRTMSET);
vt6655_mac_reg_bits_on(iobase, MAC_REG_PAPEDELAY, BIT(0));
}
- priv->abyBBVGA[0] = 0x18;
- priv->abyBBVGA[1] = 0x0A;
- priv->abyBBVGA[2] = 0x0;
- priv->abyBBVGA[3] = 0x0;
+ priv->bbvga[0] = 0x18;
+ priv->bbvga[1] = 0x0A;
+ priv->bbvga[2] = 0x0;
+ priv->bbvga[3] = 0x0;
priv->dbm_threshold[0] = -70;
priv->dbm_threshold[1] = -50;
priv->dbm_threshold[2] = 0;
@@ -2034,10 +2034,10 @@ bool bb_vt3253_init(struct vnt_private *priv)
result &= bb_write_embedded(priv,
vt3253b0_agc[ii][0], vt3253b0_agc[ii][1]);
- priv->abyBBVGA[0] = 0x1C;
- priv->abyBBVGA[1] = 0x10;
- priv->abyBBVGA[2] = 0x0;
- priv->abyBBVGA[3] = 0x0;
+ priv->bbvga[0] = 0x1C;
+ priv->bbvga[1] = 0x10;
+ priv->bbvga[2] = 0x0;
+ priv->bbvga[3] = 0x0;
priv->dbm_threshold[0] = -70;
priv->dbm_threshold[1] = -48;
priv->dbm_threshold[2] = 0;
@@ -2056,10 +2056,10 @@ bool bb_vt3253_init(struct vnt_private *priv)
iowrite8(0x23, iobase + MAC_REG_ITRTMSET);
vt6655_mac_reg_bits_on(iobase, MAC_REG_PAPEDELAY, BIT(0));
- priv->abyBBVGA[0] = 0x14;
- priv->abyBBVGA[1] = 0x0A;
- priv->abyBBVGA[2] = 0x0;
- priv->abyBBVGA[3] = 0x0;
+ priv->bbvga[0] = 0x14;
+ priv->bbvga[1] = 0x0A;
+ priv->bbvga[2] = 0x0;
+ priv->bbvga[3] = 0x0;
priv->dbm_threshold[0] = -60;
priv->dbm_threshold[1] = -50;
priv->dbm_threshold[2] = 0;
@@ -2074,10 +2074,10 @@ bool bb_vt3253_init(struct vnt_private *priv)
result &= bb_write_embedded(priv,
vt3253b0_agc[ii][0], vt3253b0_agc[ii][1]);
- priv->abyBBVGA[0] = 0x1C;
- priv->abyBBVGA[1] = 0x10;
- priv->abyBBVGA[2] = 0x0;
- priv->abyBBVGA[3] = 0x0;
+ priv->bbvga[0] = 0x1C;
+ priv->bbvga[1] = 0x10;
+ priv->bbvga[2] = 0x0;
+ priv->bbvga[3] = 0x0;
priv->dbm_threshold[0] = -70;
priv->dbm_threshold[1] = -48;
priv->dbm_threshold[2] = 0;
@@ -2088,7 +2088,7 @@ bool bb_vt3253_init(struct vnt_private *priv)
} else {
/* No VGA Table now */
priv->bUpdateBBVGA = false;
- priv->abyBBVGA[0] = 0x1C;
+ priv->bbvga[0] = 0x1C;
}
if (by_local_id > REV_ID_VT3253_A1) {
@@ -2126,7 +2126,7 @@ bb_set_short_slot_time(struct vnt_private *priv)
/* patch for 3253B0 Baseband with Cardbus module */
bb_read_embedded(priv, 0xE7, &by_bb_vga);
- if (by_bb_vga == priv->abyBBVGA[0])
+ if (by_bb_vga == priv->bbvga[0])
by_bb_rx_conf |= 0x20; /* 0010 0000 */
bb_write_embedded(priv, 0x0A, by_bb_rx_conf); /* CR10 */
@@ -2140,7 +2140,7 @@ void bb_set_vga_gain_offset(struct vnt_private *priv, unsigned char by_data)
bb_read_embedded(priv, 0x0A, &by_bb_rx_conf); /* CR10 */
/* patch for 3253B0 Baseband with Cardbus module */
- if (by_data == priv->abyBBVGA[0])
+ if (by_data == priv->bbvga[0])
by_bb_rx_conf |= 0x20; /* 0010 0000 */
else if (priv->short_slot_time)
by_bb_rx_conf &= 0xDF; /* 1101 1111 */
diff --git a/drivers/staging/vt6655/channel.c b/drivers/staging/vt6655/channel.c
index e90e0b43505d..e20701815db9 100644
--- a/drivers/staging/vt6655/channel.c
+++ b/drivers/staging/vt6655/channel.c
@@ -87,8 +87,8 @@ bool set_channel(struct vnt_private *priv, struct ieee80211_channel *ch)
/* Set VGA to max sensitivity */
if (priv->bUpdateBBVGA &&
- priv->byBBVGACurrent != priv->abyBBVGA[0]) {
- priv->byBBVGACurrent = priv->abyBBVGA[0];
+ priv->byBBVGACurrent != priv->bbvga[0]) {
+ priv->byBBVGACurrent = priv->bbvga[0];
bb_set_vga_gain_offset(priv, priv->byBBVGACurrent);
}
diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
index 8c90539cc3d7..b662c74a2dc7 100644
--- a/drivers/staging/vt6655/device.h
+++ b/drivers/staging/vt6655/device.h
@@ -250,7 +250,7 @@ struct vnt_private {
unsigned int uBBVGADiffCount;
unsigned char byBBVGANew;
unsigned char byBBVGACurrent;
- unsigned char abyBBVGA[BB_VGA_LEVEL];
+ unsigned char bbvga[BB_VGA_LEVEL];
long dbm_threshold[BB_VGA_LEVEL];
unsigned char byBBPreEDRSSI;
diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index f76f482f4c06..385848df8848 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -424,9 +424,9 @@ static void device_init_registers(struct vnt_private *priv)
bb_vt3253_init(priv);
if (priv->bUpdateBBVGA) {
- priv->byBBVGACurrent = priv->abyBBVGA[0];
+ priv->byBBVGACurrent = priv->bbvga[0];
priv->byBBVGANew = priv->byBBVGACurrent;
- bb_set_vga_gain_offset(priv, priv->abyBBVGA[0]);
+ bb_set_vga_gain_offset(priv, priv->bbvga[0]);
}
bb_set_rx_antenna_mode(priv, priv->byRxAntennaMode);
@@ -1053,7 +1053,7 @@ static void vnt_check_bb_vga(struct vnt_private *priv)
for (i = 0; i < BB_VGA_LEVEL; i++) {
if (dbm < priv->dbm_threshold[i]) {
- priv->byBBVGANew = priv->abyBBVGA[i];
+ priv->byBBVGANew = priv->bbvga[i];
break;
}
}
@@ -1510,7 +1510,7 @@ static void vnt_bss_info_changed(struct ieee80211_hw *hw,
priv->short_slot_time = false;
CARDbSetPhyParameter(priv, priv->byBBType);
- bb_set_vga_gain_offset(priv, priv->abyBBVGA[0]);
+ bb_set_vga_gain_offset(priv, priv->bbvga[0]);
}
if (changed & BSS_CHANGED_TXPOWER)
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/3] staging: vt6655: Type encoding info dropped from array name "abyBBVGA"
2023-09-28 15:06 [PATCH 1/3] staging: vt6655: Type encoding info dropped from array name "abyBBVGA" Pavan Bobba
@ 2023-09-28 18:34 ` Philipp Hortmann
2023-09-29 7:19 ` Dan Carpenter
0 siblings, 1 reply; 4+ messages in thread
From: Philipp Hortmann @ 2023-09-28 18:34 UTC (permalink / raw)
To: Pavan Bobba, Forest Bond, Greg Kroah-Hartman, Michael Straube
Cc: linux-staging, linux-kernel
On 9/28/23 17:06, Pavan Bobba wrote:
> array name "abyBBVGA" updated like below:
>
> a.type encoding info dropped from name
> b.camelcase name replaced by snakecase
>
> Issue found by checkpatch
>
> Signed-off-by: Pavan Bobba<opensource206@gmail.com>
A coverletter is missing.
I tested all three patches.
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/3] staging: vt6655: Type encoding info dropped from array name "abyBBVGA"
2023-09-28 18:34 ` Philipp Hortmann
@ 2023-09-29 7:19 ` Dan Carpenter
2023-10-05 7:56 ` Greg Kroah-Hartman
0 siblings, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2023-09-29 7:19 UTC (permalink / raw)
To: Philipp Hortmann
Cc: Pavan Bobba, Forest Bond, Greg Kroah-Hartman, Michael Straube,
linux-staging, linux-kernel
On Thu, Sep 28, 2023 at 08:34:40PM +0200, Philipp Hortmann wrote:
> On 9/28/23 17:06, Pavan Bobba wrote:
> > array name "abyBBVGA" updated like below:
> >
> > a.type encoding info dropped from name
> > b.camelcase name replaced by snakecase
> >
> > Issue found by checkpatch
> >
> > Signed-off-by: Pavan Bobba<opensource206@gmail.com>
>
>
> A coverletter is missing.
>
The coverletter isn't required, but the more important issue is that the
patchset wasn't sent as a thread but instead as separate emails.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/3] staging: vt6655: Type encoding info dropped from array name "abyBBVGA"
2023-09-29 7:19 ` Dan Carpenter
@ 2023-10-05 7:56 ` Greg Kroah-Hartman
0 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2023-10-05 7:56 UTC (permalink / raw)
To: Dan Carpenter
Cc: Philipp Hortmann, Pavan Bobba, Forest Bond, Michael Straube,
linux-staging, linux-kernel
On Fri, Sep 29, 2023 at 10:19:53AM +0300, Dan Carpenter wrote:
> On Thu, Sep 28, 2023 at 08:34:40PM +0200, Philipp Hortmann wrote:
> > On 9/28/23 17:06, Pavan Bobba wrote:
> > > array name "abyBBVGA" updated like below:
> > >
> > > a.type encoding info dropped from name
> > > b.camelcase name replaced by snakecase
> > >
> > > Issue found by checkpatch
> > >
> > > Signed-off-by: Pavan Bobba<opensource206@gmail.com>
> >
> >
> > A coverletter is missing.
> >
>
> The coverletter isn't required, but the more important issue is that the
> patchset wasn't sent as a thread but instead as separate emails.
I agree, our tools can not handl this.
Pavan, please resend these all as a patch series, properly threaded
together. Tools like 'git send-email' or 'b4' will do this for you
automatically.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-05 7:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-28 15:06 [PATCH 1/3] staging: vt6655: Type encoding info dropped from array name "abyBBVGA" Pavan Bobba
2023-09-28 18:34 ` Philipp Hortmann
2023-09-29 7:19 ` Dan Carpenter
2023-10-05 7:56 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox