From: Alison Schofield <alison.schofield@intel.com>
To: "Felix N. Kimbu" <felixkimbu1@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
outreachy@lists.linux.dev
Subject: Re: [PATCH] staging: p80211conv: Rename local foo to decrypt_check
Date: Mon, 11 Mar 2024 15:46:29 -0700 [thread overview]
Message-ID: <Ze+JxSpqc/eHfCKn@aschofie-mobl2> (raw)
In-Reply-To: <Ze9Ie67PCSvBU+og@MOLeToid>
On Mon, Mar 11, 2024 at 07:07:55PM +0100, Felix N. Kimbu wrote:
> This change renames the local variable foo to decrypt_check in functions
> skb_ether_to_p80211(...) and skb_p80211_to_ether(...), giving intuitive
> meaning to the identifier.
'rc' is typically used for cases like this. If the name of the function
being called is reasonably intuitive, then 'rc' suffices for the return
value.
>
> It also indents the parameters to match the the opening parentheses.
'Also' signals that this patch is trying to do more than one thing.
One type of 'thing' per patch please.
The commit message prefixes are off. Please see First Patch Tutorial
Section: "Following the Driver commit style"
Patch fails checkpatch. Please see First Patch Tutorial Sections:
"Git post-commit hooks" and "Understand patch best practices"
--snip
next prev parent reply other threads:[~2024-03-11 22:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 18:07 [PATCH] staging: p80211conv: Rename local foo to decrypt_check Felix N. Kimbu
2024-03-11 19:31 ` Philipp Hortmann
2024-03-11 21:34 ` [PATCH v2] staging: wlan-ng: p80211conv: fix indentation problems, introduced by previous commit Felix N. Kimbu
2024-03-11 22:52 ` Alison Schofield
2024-03-12 14:19 ` Felix Kimbu
2024-03-11 22:46 ` Alison Schofield [this message]
2024-03-12 9:01 ` [PATCH] staging: p80211conv: Rename local foo to decrypt_check Dan Carpenter
2024-03-12 14:09 ` Felix Kimbu
2024-03-12 9:03 ` Dan Carpenter
2024-03-12 14:16 ` Felix Kimbu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ze+JxSpqc/eHfCKn@aschofie-mobl2 \
--to=alison.schofield@intel.com \
--cc=felixkimbu1@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox