[PATCH] staging: vt6655: Remove unused function from rf.h RFbAL7230SelectChannelPostProcess

[PATCH] staging: vt6655: Remove unused function from rf.h RFbAL7230SelectChannelPostProcess

[Dorine Tipo]

Remove RFbAL7230SelectChannelPostProcess as it is dead code.

This patch removes the dead code to improve code cleanliness and reduce
unnecessary complexity in the driver.

Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
---
 drivers/staging/vt6655/rf.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/staging/vt6655/rf.h b/drivers/staging/vt6655/rf.h
index 057860a5e100..3427341e581f 100644
--- a/drivers/staging/vt6655/rf.h
+++ b/drivers/staging/vt6655/rf.h
@@ -68,9 +68,5 @@ bool RFbRawSetPower(struct vnt_private *priv, unsigned char byPwr,
 void RFvRSSITodBm(struct vnt_private *priv, unsigned char byCurrRSSI,
 		  long *pldBm);

-/* {{ RobertYu: 20050104 */
-bool RFbAL7230SelectChannelPostProcess(struct vnt_private *priv, u16 byOldChannel,
-				       u16 byNewChannel);
-/* }} RobertYu */

 #endif /* __RF_H__ */
--
2.25.1

[PATCH v2] staging: vt6655: Remove unused function RFbAL7230SelectChannelPostProcess

[Dorine Tipo]

Remove RFbAL7230SelectChannelPostProcess as it is dead code.

This commit removes the dead code to improve code cleanliness and reduce
unnecessary complexity in the driver.

Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
---
Changes since V1:
  - Removed unintended blank line introduced after removing dead code

 drivers/staging/vt6655/rf.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/staging/vt6655/rf.h b/drivers/staging/vt6655/rf.h
index 057860a5e100..3427341e581f 100644
--- a/drivers/staging/vt6655/rf.h
+++ b/drivers/staging/vt6655/rf.h
@@ -68,9 +68,5 @@ bool RFbRawSetPower(struct vnt_private *priv, unsigned char byPwr,
 void RFvRSSITodBm(struct vnt_private *priv, unsigned char byCurrRSSI,
 		  long *pldBm);

-/* {{ RobertYu: 20050104 */
-bool RFbAL7230SelectChannelPostProcess(struct vnt_private *priv, u16 byOldChannel,
-				       u16 byNewChannel);
-/* }} RobertYu */

 #endif /* __RF_H__ */
--
2.25.1

Re: [PATCH v2] staging: vt6655: Remove unused function RFbAL7230SelectChannelPostProcess

[Dan Carpenter]

On Mon, Mar 11, 2024 at 03:56:49AM +0000, Dorine Tipo wrote:
> Remove RFbAL7230SelectChannelPostProcess as it is dead code.
> 
> This commit removes the dead code to improve code cleanliness and reduce
> unnecessary complexity in the driver.
> 
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> ---
> Changes since V1:
>   - Removed unintended blank line introduced after removing dead code

Nope.  It's still there.  ;)  I think you sent the wrong version.

regards,
dan carpenter

[PATCH v3] staging: vt6655: Remove unused function RFbAL7230SelectChannelPostProcess

[Dorine Tipo]

Remove RFbAL7230SelectChannelPostProcess as it is dead code.

This commit removes the dead code to improve code cleanliness and reduce
unnecessary complexity in the driver.

staging: vt6655: Remove multiple blank lines

Fix unintended blank line introduced after removing dead code

The previous commit inadvertently introduced a blank line after removing
dead code from the rf.h file in the staging/vt6655 directory. This commit
removes the unintended blank line to maintain code consistency.

Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
---
Changes since V1:

V2: - Removed unintended blank line introduced after removing dead code
V3: - Squashed the commits for V1 and V2 for clarity and to streamline
      the patch history

 drivers/staging/vt6655/rf.h | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/staging/vt6655/rf.h b/drivers/staging/vt6655/rf.h
index 057860a5e100..8eef100c7ef2 100644
--- a/drivers/staging/vt6655/rf.h
+++ b/drivers/staging/vt6655/rf.h
@@ -68,9 +68,4 @@ bool RFbRawSetPower(struct vnt_private *priv, unsigned char byPwr,
 void RFvRSSITodBm(struct vnt_private *priv, unsigned char byCurrRSSI,
 		  long *pldBm);

-/* {{ RobertYu: 20050104 */
-bool RFbAL7230SelectChannelPostProcess(struct vnt_private *priv, u16 byOldChannel,
-				       u16 byNewChannel);
-/* }} RobertYu */
-
 #endif /* __RF_H__ */
--
2.25.1

Re: [PATCH v3] staging: vt6655: Remove unused function RFbAL7230SelectChannelPostProcess

[Dan Carpenter]

The main issue with this patch is that it doesn't apply, but I have a
few other comments as well.

Why is Forest Bond not on the CC list?  Please use get_maintainer.pl.

On Mon, Mar 11, 2024 at 06:07:47AM +0000, Dorine Tipo wrote:
> Remove RFbAL7230SelectChannelPostProcess as it is dead code.
> 

This isn't enough information.  At first I thought the function
declaration was commented out, but then i noticed that it was just the
weird curly braces stuff that was commented.  So I thought maybe it
wasn't dead code.  Then I have to do a grep and search through git log
to find why there isn't a RFbAL7230SelectChannelPostProcess() function.

I want that sort of information in the commit message.
"Commit dd2837bdea0e ("staging: vt6655: Remove unused byRFType in rf.c")
removed the RFbAL7230SelectChannelPostProcess() but accidentally forgot
to delete the declaration in the header file.  Delete it."  Since
Philipp wrote commit dd2837bdea0e, you should add him to the CC list.

> This commit removes the dead code to improve code cleanliness and reduce
> unnecessary complexity in the driver.

This paragraph is unnecessary, we all know why dead code is bad.

> 
> staging: vt6655: Remove multiple blank lines
> 
> Fix unintended blank line introduced after removing dead code
> 
> The previous commit inadvertently introduced a blank line after removing
> dead code from the rf.h file in the staging/vt6655 directory. This commit
> removes the unintended blank line to maintain code consistency.
> 

We aren't going to apply the previous commit...  So the patch is not
going to apply and the commit message kind of doesn't make sense.  I
have written a very short blog about how to send v2 patches.

https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

regards,
dan carpenter

Re: [PATCH v3] staging: vt6655: Remove unused function RFbAL7230SelectChannelPostProcess

[Philipp Hortmann]

On 3/11/24 08:31, Dan Carpenter wrote:
> The main issue with this patch is that it doesn't apply, but I have a
> few other comments as well.
> 
> Why is Forest Bond not on the CC list?  Please use get_maintainer.pl.

Hi Dan,

reason why some omit Forest Bond is that the emailaddress seems to not 
exist anymore - find below. Can I issue a patch to change this?

Who is then entered to the M: in MAINTAINERS?
STAGING - VIA VT665X DRIVERS
M:	Forest Bond <forest@alittletooquiet.net>
S:	Odd Fixes
F:	drivers/staging/vt665?/


Error Delivery incomplete
There was a temporary problem while delivering your message to 
forest@alittletooquiet.net. Gmail will retry for 45 more hours. You'll 
be notified if the delivery fails permanently.
LEARN MORE
The response was:

The recipient server did not accept our requests to connect. For more 
information, go to https://support.google.com/mail/answer/7720 
[alittletooquiet.net 2606:4700:3033::ac43:b367: timed out] 
[alittletooquiet.net 2606:4700:3032::6815:506d: timed out] 
[alittletooquiet.net 104.21.80.109: timed out] [alittletooquiet.net 
172.67.179.103: timed out]

Reporting-MTA: dns; googlemail.com
Received-From-MTA: dns; philipp.g.hortmann@gmail.com
Arrival-Date: Mon, 11 Mar 2024 12:59:14 -0700 (PDT)
X-Original-Message-ID: <424ad0ff-8f66-4e33-829d-88035679e31b@gmail.com>

Final-Recipient: rfc822; forest@alittletooquiet.net
Action: delayed
Status: 4.4.1
Diagnostic-Code: smtp; The recipient server did not accept our requests 
to connect. For more information, go to 
https://support.google.com/mail/answer/7720
  [alittletooquiet.net 2606:4700:3033::ac43:b367: timed out]
  [alittletooquiet.net 2606:4700:3032::6815:506d: timed out]
  [alittletooquiet.net 104.21.80.109: timed out]
  [alittletooquiet.net 172.67.179.103: timed out]
Last-Attempt-Date: Tue, 12 Mar 2024 15:14:29 -0700 (PDT)
Will-Retry-Until: Thu, 14 Mar 2024 12:59:14 -0700 (PDT)

Thanks for your support.

Bye Philipp

Re: [PATCH v3] staging: vt6655: Remove unused function RFbAL7230SelectChannelPostProcess

[Dan Carpenter]

On Thu, Mar 14, 2024 at 06:33:58AM +0100, Philipp Hortmann wrote:
> On 3/11/24 08:31, Dan Carpenter wrote:
> > The main issue with this patch is that it doesn't apply, but I have a
> > few other comments as well.
> > 
> > Why is Forest Bond not on the CC list?  Please use get_maintainer.pl.
> 
> Hi Dan,
> 
> reason why some omit Forest Bond is that the emailaddress seems to not exist
> anymore - find below. Can I issue a patch to change this?
> 
> Who is then entered to the M: in MAINTAINERS?
> STAGING - VIA VT665X DRIVERS
> M:	Forest Bond <forest@alittletooquiet.net>
> S:	Odd Fixes
> F:	drivers/staging/vt665?/
> 

Yeah.  His current email is forest@forestbond.com, but let's mark it as
orphan.  You actually have this hardware, don't you?  Do you want to
take over?

regards,
dan carpenter

Re: [PATCH v3] staging: vt6655: Remove unused function RFbAL7230SelectChannelPostProcess

[Philipp Hortmann]

On 3/14/24 07:36, Dan Carpenter wrote:
> On Thu, Mar 14, 2024 at 06:33:58AM +0100, Philipp Hortmann wrote:
>> On 3/11/24 08:31, Dan Carpenter wrote:
>>> The main issue with this patch is that it doesn't apply, but I have a
>>> few other comments as well.
>>>
>>> Why is Forest Bond not on the CC list?  Please use get_maintainer.pl.
>>
>> Hi Dan,
>>
>> reason why some omit Forest Bond is that the emailaddress seems to not exist
>> anymore - find below. Can I issue a patch to change this?
>>
>> Who is then entered to the M: in MAINTAINERS?
>> STAGING - VIA VT665X DRIVERS
>> M:	Forest Bond <forest@alittletooquiet.net>
>> S:	Odd Fixes
>> F:	drivers/staging/vt665?/
>>
> 
> Yeah.  His current email is forest@forestbond.com, but let's mark it as
> orphan.  You actually have this hardware, don't you?  Do you want to
> take over?
> 
> regards,
> dan carpenter
> 

Hi Dan,

I do have vt6655 and vt6656 hardware.
But I have no idea what commitment I am entering into.
Please send me a link to a description of what my obligations are?

Thanks for your support.

Bye Philipp

Re: [PATCH v3] staging: vt6655: Remove unused function RFbAL7230SelectChannelPostProcess

[Bagas Sanjaya]

[-- Attachment #1: Type: text/plain, Size: 1396 bytes --]

On Thu, Mar 14, 2024 at 07:45:28PM +0100, Philipp Hortmann wrote:
> On 3/14/24 07:36, Dan Carpenter wrote:
> > On Thu, Mar 14, 2024 at 06:33:58AM +0100, Philipp Hortmann wrote:
> > > On 3/11/24 08:31, Dan Carpenter wrote:
> > > > The main issue with this patch is that it doesn't apply, but I have a
> > > > few other comments as well.
> > > > 
> > > > Why is Forest Bond not on the CC list?  Please use get_maintainer.pl.
> > > 
> > > Hi Dan,
> > > 
> > > reason why some omit Forest Bond is that the emailaddress seems to not exist
> > > anymore - find below. Can I issue a patch to change this?
> > > 
> > > Who is then entered to the M: in MAINTAINERS?
> > > STAGING - VIA VT665X DRIVERS
> > > M:	Forest Bond <forest@alittletooquiet.net>
> > > S:	Odd Fixes
> > > F:	drivers/staging/vt665?/
> > > 
> > 
> > Yeah.  His current email is forest@forestbond.com, but let's mark it as
> > orphan.  You actually have this hardware, don't you?  Do you want to
> > take over?
> > 
> > regards,
> > dan carpenter
> > 
> 
> Hi Dan,
> 
> I do have vt6655 and vt6656 hardware.
> But I have no idea what commitment I am entering into.
> Please send me a link to a description of what my obligations are?

Hi Philipp,

You can refer to Documentation/maintainer/feature-and-driver-maintainers.rst.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v3] staging: vt6655: Remove unused function RFbAL7230SelectChannelPostProcess

[Philipp Hortmann]

On 3/15/24 06:00, Bagas Sanjaya wrote:
> On Thu, Mar 14, 2024 at 07:45:28PM +0100, Philipp Hortmann wrote:
>> On 3/14/24 07:36, Dan Carpenter wrote:
>>> On Thu, Mar 14, 2024 at 06:33:58AM +0100, Philipp Hortmann wrote:
>>>> On 3/11/24 08:31, Dan Carpenter wrote:
>>>>> The main issue with this patch is that it doesn't apply, but I have a
>>>>> few other comments as well.
>>>>>
>>>>> Why is Forest Bond not on the CC list?  Please use get_maintainer.pl.
>>>>
>>>> Hi Dan,
>>>>
>>>> reason why some omit Forest Bond is that the emailaddress seems to not exist
>>>> anymore - find below. Can I issue a patch to change this?
>>>>
>>>> Who is then entered to the M: in MAINTAINERS?
>>>> STAGING - VIA VT665X DRIVERS
>>>> M:	Forest Bond <forest@alittletooquiet.net>
>>>> S:	Odd Fixes
>>>> F:	drivers/staging/vt665?/
>>>>
>>>
>>> Yeah.  His current email is forest@forestbond.com, but let's mark it as
>>> orphan.  You actually have this hardware, don't you?  Do you want to
>>> take over?
>>>
>>> regards,
>>> dan carpenter
>>>
>>
>> Hi Dan,
>>
>> I do have vt6655 and vt6656 hardware.
>> But I have no idea what commitment I am entering into.
>> Please send me a link to a description of what my obligations are?
> 
> Hi Philipp,
> 
> You can refer to Documentation/maintainer/feature-and-driver-maintainers.rst.
> 
> Thanks.
> 

Hi Dan,

yes I want to take over driver maintainership for drivers/staging/vt665?/.

Thanks for your proposal.

Bye Philipp

Re: [PATCH v3] staging: vt6655: Remove unused function RFbAL7230SelectChannelPostProcess

[Dan Carpenter]

On Sat, Mar 16, 2024 at 02:33:07PM +0100, Philipp Hortmann wrote:
> On 3/15/24 06:00, Bagas Sanjaya wrote:
> > On Thu, Mar 14, 2024 at 07:45:28PM +0100, Philipp Hortmann wrote:
> > > On 3/14/24 07:36, Dan Carpenter wrote:
> > > > On Thu, Mar 14, 2024 at 06:33:58AM +0100, Philipp Hortmann wrote:
> > > > > On 3/11/24 08:31, Dan Carpenter wrote:
> > > > > > The main issue with this patch is that it doesn't apply, but I have a
> > > > > > few other comments as well.
> > > > > > 
> > > > > > Why is Forest Bond not on the CC list?  Please use get_maintainer.pl.
> > > > > 
> > > > > Hi Dan,
> > > > > 
> > > > > reason why some omit Forest Bond is that the emailaddress seems to not exist
> > > > > anymore - find below. Can I issue a patch to change this?
> > > > > 
> > > > > Who is then entered to the M: in MAINTAINERS?
> > > > > STAGING - VIA VT665X DRIVERS
> > > > > M:	Forest Bond <forest@alittletooquiet.net>
> > > > > S:	Odd Fixes
> > > > > F:	drivers/staging/vt665?/
> > > > > 
> > > > 
> > > > Yeah.  His current email is forest@forestbond.com, but let's mark it as
> > > > orphan.  You actually have this hardware, don't you?  Do you want to
> > > > take over?
> > > > 
> > > > regards,
> > > > dan carpenter
> > > > 
> > > 
> > > Hi Dan,
> > > 
> > > I do have vt6655 and vt6656 hardware.
> > > But I have no idea what commitment I am entering into.
> > > Please send me a link to a description of what my obligations are?
> > 
> > Hi Philipp,
> > 
> > You can refer to Documentation/maintainer/feature-and-driver-maintainers.rst.
> > 
> > Thanks.
> > 
> 
> Hi Dan,
> 
> yes I want to take over driver maintainership for drivers/staging/vt665?/.

Awesome!  Thanks!

regards,
dan carpenter