Linux kernel staging patches
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Cc: Aleksandr Mishin <amishin@t-argos.ru>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Dan Carpenter <dan.carpenter@linaro.org>,
	Zhang Shurong <zhang_shurong@foxmail.com>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	lvc-project@linuxtesting.org
Subject: Re: [PATCH] staging: ks7010: Remove unneeded check in ks_wlan_get_range()
Date: Sat, 6 Jul 2024 16:34:26 +0200	[thread overview]
Message-ID: <ZolV8vtD4KKo-gg3@shikoro> (raw)
In-Reply-To: <bf57e119-d957-484b-be23-ea43811f30e3@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1188 bytes --]

Hi Philipp,

> no the driver is not removed yet. Planned to do this on the next cycle. I

Ah, this is good to know!

> did remove two others and wanted to wait some time to see if any complains
> arise. I am a bit scared.

No worries, it is okay to be rather a tad too cautios than too careless
IMO.

> Please always consider: If you do not use the driver, it does not mean that
> anybody else is also not using it.

I am very well aware of that. However, hardware is super-rare (it was
even some years ago) and it doesn't support network encryptions we
really want users to use. Risk is low. And even in the unlikely case of
someone complaining, we can revert, right?

> But may be you are right. I am a bit slow and to hesitant.

I don't think removing it next cycle is "slow". But it is good, of
course, to let people know of your plans. Like a reply to my mail saying
"OK, let's remove it next cycle" would keep me in the loop. But no harm
done, I can also ask what the status is. Like I did now. All good.

> I plan to send deletion in 3 weeks.

Perfect. You can already add my

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Thank you and happy hacking,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2024-07-06 14:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-05 20:44 [PATCH] staging: ks7010: Remove unneeded check in ks_wlan_get_range() Aleksandr Mishin
2024-07-05 21:15 ` Dan Carpenter
2024-07-06 14:16 ` Wolfram Sang
2024-07-06 14:23   ` Philipp Hortmann
2024-07-06 14:34     ` Wolfram Sang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZolV8vtD4KKo-gg3@shikoro \
    --to=wsa+renesas@sang-engineering.com \
    --cc=amishin@t-argos.ru \
    --cc=dan.carpenter@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=lvc-project@linuxtesting.org \
    --cc=philipp.g.hortmann@gmail.com \
    --cc=zhang_shurong@foxmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox