From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Aleksandr Mishin <amishin@t-argos.ru>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dan Carpenter <dan.carpenter@linaro.org>,
Zhang Shurong <zhang_shurong@foxmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org
Subject: Re: [PATCH] staging: ks7010: Remove unneeded check in ks_wlan_get_range()
Date: Sat, 6 Jul 2024 16:23:55 +0200 [thread overview]
Message-ID: <bf57e119-d957-484b-be23-ea43811f30e3@gmail.com> (raw)
In-Reply-To: <ZolRoeaPETSmJMGJ@shikoro>
On 7/6/24 16:16, Wolfram Sang wrote:
> On Fri, Jul 05, 2024 at 11:44:34PM +0300, Aleksandr Mishin wrote:
>> In ks_wlan_get_range() variable 'i' which value is always 12, is compared
>> to 2. This check is unneeded and should be removed.
>>
>> Remove unneeded check to clean up the code.
>>
>> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>>
>> Fixes: 13a9930d15b4 ("staging: ks7010: add driver from Nanonote extra-repository")
>> Signed-off-by: Aleksandr Mishin <amishin@t-argos.ru>
>
> I thought this driver was to be removed[1]? Phillip (CCed), what is the
> current status? If you are busy, I can remove it as well...
>
> [1] https://lore.kernel.org/all/igi27iwrzg3ovgj3sym4gsi45timpkt4vkl5ss5dbftdzat6p4@ctxcjocvunpt/
>
Hi Wolfram,
no the driver is not removed yet. Planned to do this on the next cycle.
I did remove two others and wanted to wait some time to see if any
complains arise. I am a bit scared.
Please always consider: If you do not use the driver, it does not mean
that anybody else is also not using it.
But may be you are right. I am a bit slow and to hesitant.
I plan to send deletion in 3 weeks.
Bye Philipp
next prev parent reply other threads:[~2024-07-06 14:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-05 20:44 [PATCH] staging: ks7010: Remove unneeded check in ks_wlan_get_range() Aleksandr Mishin
2024-07-05 21:15 ` Dan Carpenter
2024-07-06 14:16 ` Wolfram Sang
2024-07-06 14:23 ` Philipp Hortmann [this message]
2024-07-06 14:34 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf57e119-d957-484b-be23-ea43811f30e3@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=amishin@t-argos.ru \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lvc-project@linuxtesting.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=zhang_shurong@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox