* [PATCH 1/9] staging: r8188eu: replace one GetAddr3Ptr call
2022-10-15 15:24 [PATCH 0/9] staging: r8188eu: clean up the OnDeAuth function Martin Kaiser
@ 2022-10-15 15:24 ` Martin Kaiser
2022-10-15 15:24 ` [PATCH 2/9] staging: r8188eu: get reason code from mgmt struct Martin Kaiser
` (9 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Martin Kaiser @ 2022-10-15 15:24 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Larry Finger, Phillip Potter, Michael Straube, Pavel Skripkin,
linux-staging, linux-kernel, Martin Kaiser
Define a struct ieee80211_mgmt for the message that we process in
OnDeAuth. Use this struct to read the bssid.
This patch removes one GetAddr3Ptr call, getting us a tiny step closer to
removing GetAddr3Ptr.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/staging/r8188eu/core/rtw_mlme_ext.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
index 07905e2ae8e0..0c4b3b99150d 100644
--- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c
+++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
@@ -1457,6 +1457,7 @@ unsigned int OnAssocRsp(struct adapter *padapter, struct recv_frame *precv_frame
unsigned int OnDeAuth(struct adapter *padapter, struct recv_frame *precv_frame)
{
+ struct ieee80211_mgmt *mgmt = (struct ieee80211_mgmt *)precv_frame->rx_data;
unsigned short reason;
struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;
@@ -1464,8 +1465,7 @@ unsigned int OnDeAuth(struct adapter *padapter, struct recv_frame *precv_frame)
u8 *pframe = precv_frame->rx_data;
struct wifidirect_info *pwdinfo = &padapter->wdinfo;
- /* check A3 */
- if (!(!memcmp(GetAddr3Ptr(pframe), get_my_bssid(&pmlmeinfo->network), ETH_ALEN)))
+ if (memcmp(mgmt->bssid, get_my_bssid(&pmlmeinfo->network), ETH_ALEN))
return _SUCCESS;
if (pwdinfo->rx_invitereq_info.scan_op_ch_only) {
--
2.30.2
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 2/9] staging: r8188eu: get reason code from mgmt struct
2022-10-15 15:24 [PATCH 0/9] staging: r8188eu: clean up the OnDeAuth function Martin Kaiser
2022-10-15 15:24 ` [PATCH 1/9] staging: r8188eu: replace one GetAddr3Ptr call Martin Kaiser
@ 2022-10-15 15:24 ` Martin Kaiser
2022-10-15 15:24 ` [PATCH 3/9] staging: r8188eu: clarify the bBusyTraffic assignment Martin Kaiser
` (8 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Martin Kaiser @ 2022-10-15 15:24 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Larry Finger, Phillip Potter, Michael Straube, Pavel Skripkin,
linux-staging, linux-kernel, Martin Kaiser
Read the deauth reson code from the newly added mgmt structure instead of
calculating the offset ourselves.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/staging/r8188eu/core/rtw_mlme_ext.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
index 0c4b3b99150d..5c59fc91ecae 100644
--- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c
+++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
@@ -1473,7 +1473,7 @@ unsigned int OnDeAuth(struct adapter *padapter, struct recv_frame *precv_frame)
_set_timer(&pwdinfo->reset_ch_sitesurvey, 10);
}
- reason = le16_to_cpu(*(__le16 *)(pframe + WLAN_HDR_A3_LEN));
+ reason = le16_to_cpu(mgmt->u.disassoc.reason_code);
if (check_fwstate(pmlmepriv, WIFI_AP_STATE)) {
struct sta_info *psta;
--
2.30.2
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 3/9] staging: r8188eu: clarify the bBusyTraffic assignment
2022-10-15 15:24 [PATCH 0/9] staging: r8188eu: clean up the OnDeAuth function Martin Kaiser
2022-10-15 15:24 ` [PATCH 1/9] staging: r8188eu: replace one GetAddr3Ptr call Martin Kaiser
2022-10-15 15:24 ` [PATCH 2/9] staging: r8188eu: get reason code from mgmt struct Martin Kaiser
@ 2022-10-15 15:24 ` Martin Kaiser
2022-10-15 15:24 ` [PATCH 4/9] staging: r8188eu: use sa instead of Addr2 Martin Kaiser
` (7 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Martin Kaiser @ 2022-10-15 15:24 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Larry Finger, Phillip Potter, Michael Straube, Pavel Skripkin,
linux-staging, linux-kernel, Martin Kaiser
bBusyTraffic is set only if we're not in WIFI_AP_STATE, i.e. in the else
branch. If we were not in WIFI_AP_STATE, we'd go into the if branch and
return _SUCCESS before making it to the bBusyTraffic assignment.
Move the assignment into the else branch to make this clearer.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/staging/r8188eu/core/rtw_mlme_ext.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
index 5c59fc91ecae..fd2daeca7112 100644
--- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c
+++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
@@ -1515,8 +1515,9 @@ unsigned int OnDeAuth(struct adapter *padapter, struct recv_frame *precv_frame)
if (!ignore_received_deauth)
receive_disconnect(padapter, GetAddr3Ptr(pframe), reason);
+
+ pmlmepriv->LinkDetectInfo.bBusyTraffic = false;
}
- pmlmepriv->LinkDetectInfo.bBusyTraffic = false;
return _SUCCESS;
}
--
2.30.2
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 4/9] staging: r8188eu: use sa instead of Addr2
2022-10-15 15:24 [PATCH 0/9] staging: r8188eu: clean up the OnDeAuth function Martin Kaiser
` (2 preceding siblings ...)
2022-10-15 15:24 ` [PATCH 3/9] staging: r8188eu: clarify the bBusyTraffic assignment Martin Kaiser
@ 2022-10-15 15:24 ` Martin Kaiser
2022-10-15 15:24 ` [PATCH 5/9] staging: r8188eu: get bssid from mgmt struct Martin Kaiser
` (6 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Martin Kaiser @ 2022-10-15 15:24 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Larry Finger, Phillip Potter, Michael Straube, Pavel Skripkin,
linux-staging, linux-kernel, Martin Kaiser
For management frames, Addr2 is the Source Address (SA).
Use sa from the mgmt structure and remove the GetAddr2Ptr call.
GetAddr2Ptr is a driver-specific function that we should eventually
remove.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/staging/r8188eu/core/rtw_mlme_ext.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
index fd2daeca7112..732ada6ab932 100644
--- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c
+++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
@@ -1479,7 +1479,7 @@ unsigned int OnDeAuth(struct adapter *padapter, struct recv_frame *precv_frame)
struct sta_info *psta;
struct sta_priv *pstapriv = &padapter->stapriv;
- psta = rtw_get_stainfo(pstapriv, GetAddr2Ptr(pframe));
+ psta = rtw_get_stainfo(pstapriv, mgmt->sa);
if (psta) {
u8 updated = 0;
--
2.30.2
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 5/9] staging: r8188eu: get bssid from mgmt struct
2022-10-15 15:24 [PATCH 0/9] staging: r8188eu: clean up the OnDeAuth function Martin Kaiser
` (3 preceding siblings ...)
2022-10-15 15:24 ` [PATCH 4/9] staging: r8188eu: use sa instead of Addr2 Martin Kaiser
@ 2022-10-15 15:24 ` Martin Kaiser
2022-10-15 15:24 ` [PATCH 6/9] staging: r8188eu: exit for deauth from unknown station Martin Kaiser
` (5 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Martin Kaiser @ 2022-10-15 15:24 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Larry Finger, Phillip Potter, Michael Straube, Pavel Skripkin,
linux-staging, linux-kernel, Martin Kaiser
For management frames, Addr3 is the BSSID. Read it from the mgmt
structure instead of calling GetAddr3Ptr.
The pframe variable is now unused and can be removed.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/staging/r8188eu/core/rtw_mlme_ext.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
index 732ada6ab932..742976c38cd5 100644
--- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c
+++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
@@ -1462,7 +1462,6 @@ unsigned int OnDeAuth(struct adapter *padapter, struct recv_frame *precv_frame)
struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;
struct mlme_ext_info *pmlmeinfo = &pmlmeext->mlmext_info;
- u8 *pframe = precv_frame->rx_data;
struct wifidirect_info *pwdinfo = &padapter->wdinfo;
if (memcmp(mgmt->bssid, get_my_bssid(&pmlmeinfo->network), ETH_ALEN))
@@ -1514,7 +1513,7 @@ unsigned int OnDeAuth(struct adapter *padapter, struct recv_frame *precv_frame)
}
if (!ignore_received_deauth)
- receive_disconnect(padapter, GetAddr3Ptr(pframe), reason);
+ receive_disconnect(padapter, mgmt->bssid, reason);
pmlmepriv->LinkDetectInfo.bBusyTraffic = false;
}
--
2.30.2
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 6/9] staging: r8188eu: exit for deauth from unknown station
2022-10-15 15:24 [PATCH 0/9] staging: r8188eu: clean up the OnDeAuth function Martin Kaiser
` (4 preceding siblings ...)
2022-10-15 15:24 ` [PATCH 5/9] staging: r8188eu: get bssid from mgmt struct Martin Kaiser
@ 2022-10-15 15:24 ` Martin Kaiser
2022-10-15 15:24 ` [PATCH 7/9] staging: r8188eu: remove unnecessary return Martin Kaiser
` (4 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Martin Kaiser @ 2022-10-15 15:24 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Larry Finger, Phillip Potter, Michael Straube, Pavel Skripkin,
linux-staging, linux-kernel, Martin Kaiser
If we receive a deauth message from an unknown station, we can drop this
message and exit immediately. Reorder the code to make this clearer, don't
wrap everything in an if statement.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/staging/r8188eu/core/rtw_mlme_ext.c | 22 ++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
index 742976c38cd5..40df0f9982f4 100644
--- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c
+++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
@@ -1477,21 +1477,21 @@ unsigned int OnDeAuth(struct adapter *padapter, struct recv_frame *precv_frame)
if (check_fwstate(pmlmepriv, WIFI_AP_STATE)) {
struct sta_info *psta;
struct sta_priv *pstapriv = &padapter->stapriv;
+ u8 updated = 0;
psta = rtw_get_stainfo(pstapriv, mgmt->sa);
- if (psta) {
- u8 updated = 0;
-
- spin_lock_bh(&pstapriv->asoc_list_lock);
- if (!list_empty(&psta->asoc_list)) {
- list_del_init(&psta->asoc_list);
- pstapriv->asoc_list_cnt--;
- updated = ap_free_sta(padapter, psta, false, reason);
- }
- spin_unlock_bh(&pstapriv->asoc_list_lock);
+ if (!psta)
+ return _SUCCESS;
- associated_clients_update(padapter, updated);
+ spin_lock_bh(&pstapriv->asoc_list_lock);
+ if (!list_empty(&psta->asoc_list)) {
+ list_del_init(&psta->asoc_list);
+ pstapriv->asoc_list_cnt--;
+ updated = ap_free_sta(padapter, psta, false, reason);
}
+ spin_unlock_bh(&pstapriv->asoc_list_lock);
+
+ associated_clients_update(padapter, updated);
return _SUCCESS;
} else {
--
2.30.2
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 7/9] staging: r8188eu: remove unnecessary return
2022-10-15 15:24 [PATCH 0/9] staging: r8188eu: clean up the OnDeAuth function Martin Kaiser
` (5 preceding siblings ...)
2022-10-15 15:24 ` [PATCH 6/9] staging: r8188eu: exit for deauth from unknown station Martin Kaiser
@ 2022-10-15 15:24 ` Martin Kaiser
2022-10-15 15:24 ` [PATCH 8/9] staging: r8188eu: summarize two flags checks Martin Kaiser
` (3 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Martin Kaiser @ 2022-10-15 15:24 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Larry Finger, Phillip Potter, Michael Straube, Pavel Skripkin,
linux-staging, linux-kernel, Martin Kaiser
Remove the return statement at the end of the if branch. We can continue
to the final return after the if-else.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/staging/r8188eu/core/rtw_mlme_ext.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
index 40df0f9982f4..465f51bce0e3 100644
--- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c
+++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
@@ -1492,8 +1492,6 @@ unsigned int OnDeAuth(struct adapter *padapter, struct recv_frame *precv_frame)
spin_unlock_bh(&pstapriv->asoc_list_lock);
associated_clients_update(padapter, updated);
-
- return _SUCCESS;
} else {
int ignore_received_deauth = 0;
--
2.30.2
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 8/9] staging: r8188eu: summarize two flags checks
2022-10-15 15:24 [PATCH 0/9] staging: r8188eu: clean up the OnDeAuth function Martin Kaiser
` (6 preceding siblings ...)
2022-10-15 15:24 ` [PATCH 7/9] staging: r8188eu: remove unnecessary return Martin Kaiser
@ 2022-10-15 15:24 ` Martin Kaiser
2022-10-15 15:24 ` [PATCH 9/9] staging: r8188eu: ignore_received_deauth is a boolean Martin Kaiser
` (2 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Martin Kaiser @ 2022-10-15 15:24 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Larry Finger, Phillip Potter, Michael Straube, Pavel Skripkin,
linux-staging, linux-kernel, Martin Kaiser
Summarize the two statements to check if either WIFI_FW_AUTH_STATE or
WIFI_FW_ASSOC_STATE is set.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/staging/r8188eu/core/rtw_mlme_ext.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
index 465f51bce0e3..09ffecc5b2b3 100644
--- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c
+++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
@@ -1500,8 +1500,7 @@ unsigned int OnDeAuth(struct adapter *padapter, struct recv_frame *precv_frame)
* However, the Win8.1 with BRCM Wi-Fi will send the deauth with reason code 6 to us after receieving our deauth.
* Added the following code to avoid this case.
*/
- if ((pmlmeinfo->state & WIFI_FW_AUTH_STATE) ||
- (pmlmeinfo->state & WIFI_FW_ASSOC_STATE)) {
+ if (pmlmeinfo->state & (WIFI_FW_AUTH_STATE | WIFI_FW_ASSOC_STATE)) {
if (reason == WLAN_REASON_CLASS2_FRAME_FROM_NONAUTH_STA) {
ignore_received_deauth = 1;
} else if (reason == WLAN_REASON_PREV_AUTH_NOT_VALID) {
--
2.30.2
^ permalink raw reply related [flat|nested] 12+ messages in thread* [PATCH 9/9] staging: r8188eu: ignore_received_deauth is a boolean
2022-10-15 15:24 [PATCH 0/9] staging: r8188eu: clean up the OnDeAuth function Martin Kaiser
` (7 preceding siblings ...)
2022-10-15 15:24 ` [PATCH 8/9] staging: r8188eu: summarize two flags checks Martin Kaiser
@ 2022-10-15 15:24 ` Martin Kaiser
2022-10-15 15:56 ` [PATCH 0/9] staging: r8188eu: clean up the OnDeAuth function Pavel Skripkin
2022-10-15 20:31 ` Philipp Hortmann
10 siblings, 0 replies; 12+ messages in thread
From: Martin Kaiser @ 2022-10-15 15:24 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Larry Finger, Phillip Potter, Michael Straube, Pavel Skripkin,
linux-staging, linux-kernel, Martin Kaiser
The ignore_received_deauth is in fact a boolean variable. Change its type
to bool and use true, false for its values.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/staging/r8188eu/core/rtw_mlme_ext.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
index 09ffecc5b2b3..fda446b6779c 100644
--- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c
+++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c
@@ -1493,7 +1493,7 @@ unsigned int OnDeAuth(struct adapter *padapter, struct recv_frame *precv_frame)
associated_clients_update(padapter, updated);
} else {
- int ignore_received_deauth = 0;
+ bool ignore_received_deauth = false;
/* Before sending the auth frame to start the STA/GC mode connection with AP/GO,
* we will send the deauth first.
@@ -1502,10 +1502,10 @@ unsigned int OnDeAuth(struct adapter *padapter, struct recv_frame *precv_frame)
*/
if (pmlmeinfo->state & (WIFI_FW_AUTH_STATE | WIFI_FW_ASSOC_STATE)) {
if (reason == WLAN_REASON_CLASS2_FRAME_FROM_NONAUTH_STA) {
- ignore_received_deauth = 1;
+ ignore_received_deauth = true;
} else if (reason == WLAN_REASON_PREV_AUTH_NOT_VALID) {
// TODO: 802.11r
- ignore_received_deauth = 1;
+ ignore_received_deauth = true;
}
}
--
2.30.2
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 0/9] staging: r8188eu: clean up the OnDeAuth function
2022-10-15 15:24 [PATCH 0/9] staging: r8188eu: clean up the OnDeAuth function Martin Kaiser
` (8 preceding siblings ...)
2022-10-15 15:24 ` [PATCH 9/9] staging: r8188eu: ignore_received_deauth is a boolean Martin Kaiser
@ 2022-10-15 15:56 ` Pavel Skripkin
2022-10-15 20:31 ` Philipp Hortmann
10 siblings, 0 replies; 12+ messages in thread
From: Pavel Skripkin @ 2022-10-15 15:56 UTC (permalink / raw)
To: Martin Kaiser, Greg Kroah-Hartman
Cc: Larry Finger, Phillip Potter, Michael Straube, linux-staging,
linux-kernel
Hi Martin,
Martin Kaiser <martin@kaiser.cx> says:
> This series cleans up the OnDeAuth function and tries to replace
> driver-specific parsing code with helpers from ieee80211.h.
>
> Martin Kaiser (9):
> staging: r8188eu: replace one GetAddr3Ptr call
> staging: r8188eu: get reason code from mgmt struct
> staging: r8188eu: clarify the bBusyTraffic assignment
> staging: r8188eu: use sa instead of Addr2
> staging: r8188eu: get bssid from mgmt struct
> staging: r8188eu: exit for deauth from unknown station
> staging: r8188eu: remove unnecessary return
> staging: r8188eu: summarize two flags checks
> staging: r8188eu: ignore_received_deauth is a boolean
>
> drivers/staging/r8188eu/core/rtw_mlme_ext.c | 45 ++++++++++-----------
> 1 file changed, 21 insertions(+), 24 deletions(-)
>
works for me, thanks
Acked-by: Pavel Skripkin <paskripkin@gmail.com>
With regards,
Pavel Skripkin
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/9] staging: r8188eu: clean up the OnDeAuth function
2022-10-15 15:24 [PATCH 0/9] staging: r8188eu: clean up the OnDeAuth function Martin Kaiser
` (9 preceding siblings ...)
2022-10-15 15:56 ` [PATCH 0/9] staging: r8188eu: clean up the OnDeAuth function Pavel Skripkin
@ 2022-10-15 20:31 ` Philipp Hortmann
10 siblings, 0 replies; 12+ messages in thread
From: Philipp Hortmann @ 2022-10-15 20:31 UTC (permalink / raw)
To: Martin Kaiser, Greg Kroah-Hartman
Cc: Larry Finger, Phillip Potter, Michael Straube, Pavel Skripkin,
linux-staging, linux-kernel
On 10/15/22 17:24, Martin Kaiser wrote:
> This series cleans up the OnDeAuth function and tries to replace
> driver-specific parsing code with helpers from ieee80211.h.
>
> Martin Kaiser (9):
> staging: r8188eu: replace one GetAddr3Ptr call
> staging: r8188eu: get reason code from mgmt struct
> staging: r8188eu: clarify the bBusyTraffic assignment
> staging: r8188eu: use sa instead of Addr2
> staging: r8188eu: get bssid from mgmt struct
> staging: r8188eu: exit for deauth from unknown station
> staging: r8188eu: remove unnecessary return
> staging: r8188eu: summarize two flags checks
> staging: r8188eu: ignore_received_deauth is a boolean
>
> drivers/staging/r8188eu/core/rtw_mlme_ext.c | 45 ++++++++++-----------
> 1 file changed, 21 insertions(+), 24 deletions(-)
>
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150
^ permalink raw reply [flat|nested] 12+ messages in thread