* [FIRST-PATCH] staging: gpib : gpio : gpib_bitbang.c : fixed parentheses error.
@ 2025-05-07 17:18 rujra
2025-05-07 18:53 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: rujra @ 2025-05-07 17:18 UTC (permalink / raw)
To: Dave Penkler, Greg KH; +Cc: linux-staging, linux-kernel
To pass it as one parameter, wrapped the entire macro expansion in parentheses.
and build it successfully.
Signed-off-by: Rujra Bhatt <braker.noob.kernel@gmail.com>
---
drivers/staging/gpib/gpio/gpib_bitbang.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/gpib/gpio/gpib_bitbang.c
b/drivers/staging/gpib/gpio/gpib_bitbang.c
index 9670522fe36e..a1f9c99c5ad2 100644
--- a/drivers/staging/gpib/gpio/gpib_bitbang.c
+++ b/drivers/staging/gpib/gpio/gpib_bitbang.c
@@ -47,10 +47,10 @@
dev_dbg(board->gpib_dev, frm, ## __VA_ARGS__); } \
while (0)
-#define LINVAL gpiod_get_value(DAV), \
+#define LINVAL (gpiod_get_value(DAV), \
gpiod_get_value(NRFD), \
gpiod_get_value(NDAC), \
- gpiod_get_value(SRQ)
+ gpiod_get_value(SRQ))
#define LINFMT "DAV: %d NRFD:%d NDAC: %d SRQ: %d"
#include "gpibP.h"
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [FIRST-PATCH] staging: gpib : gpio : gpib_bitbang.c : fixed parentheses error.
2025-05-07 17:18 [FIRST-PATCH] staging: gpib : gpio : gpib_bitbang.c : fixed parentheses error rujra
@ 2025-05-07 18:53 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2025-05-07 18:53 UTC (permalink / raw)
To: rujra; +Cc: Dave Penkler, Greg KH, linux-staging, linux-kernel
On Wed, May 07, 2025 at 10:48:45PM +0530, rujra wrote:
> To pass it as one parameter, wrapped the entire macro expansion in parentheses.
> and build it successfully.
^^^^^^^^^^^^^^^^^^^^^^
No, it doesn't build.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-07 18:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-07 17:18 [FIRST-PATCH] staging: gpib : gpio : gpib_bitbang.c : fixed parentheses error rujra
2025-05-07 18:53 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox