From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Minu Jin <s9430939@naver.com>
Cc: gregkh@linuxfoundation.org, abrahamadekunle50@gmail.com,
dan.carpenter@linaro.org, milospuric856@gmail.com,
zxcv2569763104@gmail.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: rtl8723bs: fix unchecked return value of skb_copy_bits
Date: Tue, 20 Jan 2026 15:43:50 +0200 [thread overview]
Message-ID: <aW-GlpEkWUYNZsg1@smile.fi.intel.com> (raw)
In-Reply-To: <20260120132241.2119454-1-s9430939@naver.com>
On Tue, Jan 20, 2026 at 10:22:41PM +0900, Minu Jin wrote:
> The function _rtw_pktfile_read() incorrectly updated the file pointer
> even when skb_copy_bits() failed.
>
> This patch fixes the issue by:
>
> 1. Propagating the negative error code from skb_copy_bits() if it fails,
> preventing internal pointer updates.
>
> 2. Updating all callers to check the return value and handle errors
> appropriately.
>
> Signed-off-by: Minu Jin <s9430939@naver.com>
> ---
Ick, and what has been changed? Where is the changelog?
...
> struct qos_priv *pqospriv = &pmlmepriv->qospriv;
> signed int res = _SUCCESS;
>
> + signed int ret;
No way. This should be attached to the definition block, id est no blank lines
should be in between.
> s32 rtw_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, struct
> s32 bmcst = is_multicast_ether_addr(pattrib->ra);
> s32 res = _SUCCESS;
>
> + signed int ret;
Ditto.
...
> extern uint rtw_remainder_len(struct pkt_file *pfile);
> extern void _rtw_open_pktfile(struct sk_buff *pkt, struct pkt_file *pfile);
> -extern uint _rtw_pktfile_read(struct pkt_file *pfile, u8 *rmem, uint rlen);
> +extern int _rtw_pktfile_read(struct pkt_file *pfile, u8 *rmem, uint rlen);
Drop 'extern' at the same time. Or even better, submit a followup patch to drop
all of them at once.
...
Also you can submit the patches to convert types:
uint --> unsigned int
signed int --> int // this one is optional, signed int longer, but still well
// known standard. etc...
...
> -uint _rtw_pktfile_read(struct pkt_file *pfile, u8 *rmem, uint rlen)
> +int _rtw_pktfile_read(struct pkt_file *pfile, u8 *rmem, uint rlen)
> {
> - uint len = 0;
> + int ret;
> + int len = 0;
Reversed xmas tree ordering?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-01-20 13:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 13:22 [PATCH v2] staging: rtl8723bs: fix unchecked return value of skb_copy_bits Minu Jin
2026-01-20 13:43 ` Andy Shevchenko [this message]
2026-01-20 13:59 ` Dan Carpenter
2026-01-20 14:03 ` Andy Shevchenko
2026-01-20 14:28 ` Dan Carpenter
2026-01-20 14:57 ` Greg KH
2026-01-20 14:03 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aW-GlpEkWUYNZsg1@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=abrahamadekunle50@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=milospuric856@gmail.com \
--cc=s9430939@naver.com \
--cc=zxcv2569763104@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox