From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Minu Jin <s9430939@naver.com>,
gregkh@linuxfoundation.org, abrahamadekunle50@gmail.com,
milospuric856@gmail.com, zxcv2569763104@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: rtl8723bs: fix unchecked return value of skb_copy_bits
Date: Tue, 20 Jan 2026 16:03:37 +0200 [thread overview]
Message-ID: <aW-LOZdXo6zLhT_x@smile.fi.intel.com> (raw)
In-Reply-To: <aW-KQbHblIy-MTIu@stanley.mountain>
On Tue, Jan 20, 2026 at 04:59:29PM +0300, Dan Carpenter wrote:
> On Tue, Jan 20, 2026 at 10:22:41PM +0900, Minu Jin wrote:
...
> > + signed int ret;
>
> Don't put a blank line in the middle of the declaration block. Just do
> "int ret;". Everyone knows "int" is signed. Don't follow the local
> style when the local style is wrong. Also only use s32 when it's part
> of a networking or hardware spec. Just use int. Do people imagine that
> we'll change int to be unsigned?
Not in a far past we changed char to be unsigned :-)
*Yes I know that it's a bit different case.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-01-20 14:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 13:22 [PATCH v2] staging: rtl8723bs: fix unchecked return value of skb_copy_bits Minu Jin
2026-01-20 13:43 ` Andy Shevchenko
2026-01-20 13:59 ` Dan Carpenter
2026-01-20 14:03 ` Andy Shevchenko [this message]
2026-01-20 14:28 ` Dan Carpenter
2026-01-20 14:57 ` Greg KH
2026-01-20 14:03 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aW-LOZdXo6zLhT_x@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=abrahamadekunle50@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=milospuric856@gmail.com \
--cc=s9430939@naver.com \
--cc=zxcv2569763104@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox