* [PATCH v2] staging/rtl8723bs: remove unused variable warning
@ 2026-01-19 19:24 Meeri Kallio
2026-01-20 6:43 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Meeri Kallio @ 2026-01-19 19:24 UTC (permalink / raw)
To: linux-kernel; +Cc: gregkh, linux-staging, Meeri Kallio
This is a resend of my first kernel patch, now CC'd to the staging maintainer.
The patch removes an unused variable in rtl8723bs to silence a compiler warning.
No functional changes.
Feedback welcome.
Signed-off-by: Meeri Kallio <meeri.kallio91@gmail.com>
---
drivers/staging/rtl8723bs/foo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/foo.c b/drivers/staging/rtl8723bs/foo.c
index abcdef0..1234567 100644
--- a/drivers/staging/rtl8723bs/foo.c
+++ b/drivers/staging/rtl8723bs/foo.c
@@ -1,3 +1,3 @@
-int unused_variable = 0;
+/* removed unused_variable to silence warning */
int rtl8723bs_init(void)
{
return 0;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] staging/rtl8723bs: remove unused variable warning
2026-01-19 19:24 [PATCH v2] staging/rtl8723bs: remove unused variable warning Meeri Kallio
@ 2026-01-20 6:43 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2026-01-20 6:43 UTC (permalink / raw)
To: Meeri Kallio; +Cc: linux-kernel, gregkh, linux-staging
What tree are you working off? It looks like you're accidentally
working off an example tree with deliberate nonsense code. You're
just supposed to fix the bugs privately as practice about how to do
a git commit, not send the fix upstream.
In time you will look back at this with amusement. It certainly gave
me a good chuckle.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-20 6:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-19 19:24 [PATCH v2] staging/rtl8723bs: remove unused variable warning Meeri Kallio
2026-01-20 6:43 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox