* [PATCH] staging: rtl8723bs: remove unnecessary blank lines
@ 2025-12-27 23:45 Ofir Mirovsky
0 siblings, 0 replies; 6+ messages in thread
From: Ofir Mirovsky @ 2025-12-27 23:45 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, Ofir Mirovsky
Remove unnecessary blank lines to fix checkpatch checks:
- "Blank lines aren't necessary before a close brace '}'"
- "Blank lines aren't necessary after an open brace '{'"
This improves code readability and adheres to the kernel coding style.
Signed-off-by: Ofir Mirovsky <ofirmirovsky@gmail.com>
---
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
index 6ca6dc548..e66b9684d 100644
--- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
@@ -553,7 +553,6 @@ static void rtw_init_default_value(struct adapter *padapter)
padapter->fix_rate = 0xFF;
padapter->driver_ampdu_spacing = 0xFF;
padapter->driver_rx_ampdu_factor = 0xFF;
-
}
struct dvobj_priv *devobj_init(void)
@@ -898,7 +897,6 @@ void rtw_ips_pwr_down(struct adapter *padapter)
void rtw_ips_dev_unload(struct adapter *padapter)
{
-
if (!padapter->bSurpriseRemoved)
rtw_hal_deinit(padapter);
}
@@ -980,7 +978,6 @@ void rtw_dev_unload(struct adapter *padapter)
u8 cnt = 0;
if (padapter->bup) {
-
padapter->bDriverStopped = true;
if (padapter->xmitpriv.ack_tx)
rtw_ack_tx_done(&padapter->xmitpriv, RTW_SCTX_DONE_DRV_STOP);
@@ -1022,7 +1019,6 @@ void rtw_dev_unload(struct adapter *padapter)
}
padapter->bup = false;
-
}
}
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] staging: rtl8723bs: remove unnecessary blank lines
2025-12-28 19:44 [PATCH] staging: rtl8723bs: fix block comment coding style Ofir Mirovsky
@ 2025-12-28 19:45 ` Ofir Mirovsky
0 siblings, 0 replies; 6+ messages in thread
From: Ofir Mirovsky @ 2025-12-28 19:45 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, Ofir Mirovsky
Remove unnecessary blank lines to fix checkpatch checks:
- "Blank lines aren't necessary before a close brace '}'"
- "Blank lines aren't necessary after an open brace '{'"
This improves code readability and adheres to the kernel coding style.
Signed-off-by: Ofir Mirovsky <ofirmirovsky@gmail.com>
---
drivers/staging/rtl8723bs/os_dep/os_intfs.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
index 6ca6dc548..e66b9684d 100644
--- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c
@@ -553,7 +553,6 @@ static void rtw_init_default_value(struct adapter *padapter)
padapter->fix_rate = 0xFF;
padapter->driver_ampdu_spacing = 0xFF;
padapter->driver_rx_ampdu_factor = 0xFF;
-
}
struct dvobj_priv *devobj_init(void)
@@ -898,7 +897,6 @@ void rtw_ips_pwr_down(struct adapter *padapter)
void rtw_ips_dev_unload(struct adapter *padapter)
{
-
if (!padapter->bSurpriseRemoved)
rtw_hal_deinit(padapter);
}
@@ -980,7 +978,6 @@ void rtw_dev_unload(struct adapter *padapter)
u8 cnt = 0;
if (padapter->bup) {
-
padapter->bDriverStopped = true;
if (padapter->xmitpriv.ack_tx)
rtw_ack_tx_done(&padapter->xmitpriv, RTW_SCTX_DONE_DRV_STOP);
@@ -1022,7 +1019,6 @@ void rtw_dev_unload(struct adapter *padapter)
}
padapter->bup = false;
-
}
}
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] staging: rtl8723bs: remove unnecessary blank lines
[not found] <20260205151229.240586-1-kaizhetan.ref@yahoo.com>
@ 2026-02-05 15:12 ` Tan Kai Zhe
2026-02-05 17:00 ` Ethan Tidmore
0 siblings, 1 reply; 6+ messages in thread
From: Tan Kai Zhe @ 2026-02-05 15:12 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel
Adhere to Linux kernel coding style.
Reported by checkpatch:
CHECK: Blank lines aren't necessary before a close brace '}'
Signed-off-by: Tan Kai Zhe <kaizhetan@yahoo.com>
---
drivers/staging/rtl8723bs/core/rtw_cmd.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
index ef2d92b5588a..7f1bf20300fe 100644
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
@@ -1224,7 +1224,6 @@ u8 traffic_status_watchdog(struct adapter *padapter, u8 from_timer)
pmlmepriv->LinkDetectInfo.bHigherBusyTxTraffic = bHigherBusyTxTraffic;
return bEnterPS;
-
}
static void dynamic_chk_wk_hdl(struct adapter *padapter)
@@ -1446,7 +1445,6 @@ u8 rtw_dm_ra_mask_wk_cmd(struct adapter *padapter, u8 *psta)
exit:
return res;
-
}
u8 rtw_ps_cmd(struct adapter *padapter)
@@ -1516,9 +1514,7 @@ static void rtw_chk_hi_queue_hdl(struct adapter *padapter)
} else {/* re check again */
rtw_chk_hi_queue_cmd(padapter);
}
-
}
-
}
u8 rtw_chk_hi_queue_cmd(struct adapter *padapter)
@@ -1877,7 +1873,6 @@ void rtw_createbss_cmd_callback(struct adapter *padapter, struct cmd_obj *pcmd)
spin_unlock_bh(&pmlmepriv->scanned_queue.lock);
/* we will set _FW_LINKED when there is one more sat to join us (rtw_stassoc_event_callback) */
-
}
createbss_cmd_fail:
--
2.53.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: rtl8723bs: remove unnecessary blank lines
2026-02-05 15:12 ` [PATCH] staging: rtl8723bs: remove unnecessary blank lines Tan Kai Zhe
@ 2026-02-05 17:00 ` Ethan Tidmore
2026-02-06 0:24 ` Kai
0 siblings, 1 reply; 6+ messages in thread
From: Ethan Tidmore @ 2026-02-05 17:00 UTC (permalink / raw)
To: Tan Kai Zhe, gregkh; +Cc: linux-staging, linux-kernel
On Thu Feb 5, 2026 at 9:12 AM CST, Tan Kai Zhe wrote:
> Adhere to Linux kernel coding style.
>
> Reported by checkpatch:
>
> CHECK: Blank lines aren't necessary before a close brace '}'
>
> Signed-off-by: Tan Kai Zhe <kaizhetan@yahoo.com>
These blank lines have already been removed in staging-next. Please use
staging-next when creating patches for staging. Thanks.
ET
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: rtl8723bs: remove unnecessary blank lines
2026-02-05 17:00 ` Ethan Tidmore
@ 2026-02-06 0:24 ` Kai
0 siblings, 0 replies; 6+ messages in thread
From: Kai @ 2026-02-06 0:24 UTC (permalink / raw)
To: Ethan Tidmore; +Cc: gregkh, linux-staging, linux-kernel
On Thu, Feb 05, 2026 at 11:00:29AM -0600, Ethan Tidmore wrote:
> On Thu Feb 5, 2026 at 9:12 AM CST, Tan Kai Zhe wrote:
> > Adhere to Linux kernel coding style.
> >
> > Reported by checkpatch:
> >
> > CHECK: Blank lines aren't necessary before a close brace '}'
> >
> > Signed-off-by: Tan Kai Zhe <kaizhetan@yahoo.com>
>
> These blank lines have already been removed in staging-next. Please use
> staging-next when creating patches for staging. Thanks.
>
> ET
Sorry and thanks! I'll use staging-next from now on.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] staging: rtl8723bs: remove unnecessary blank lines
@ 2026-05-01 16:38 Stepan Ionichev
0 siblings, 0 replies; 6+ messages in thread
From: Stepan Ionichev @ 2026-05-01 16:38 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, Stepan Ionichev
Drop blank lines flagged by checkpatch.pl in rtw_ioctl_set.c:
CHECK: Blank lines aren't necessary before a close brace '}'
CHECK: Please don't use multiple blank lines
CHECK: Blank lines aren't necessary after an open brace '{'
No functional change.
Signed-off-by: Stepan Ionichev <sozdayvek@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
index c70541f95..8edc62752 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
@@ -120,9 +120,7 @@ u8 rtw_do_join(struct adapter *padapter)
pmlmepriv->to_join = false;
}
}
-
}
-
}
exit:
@@ -340,7 +338,6 @@ u8 rtw_set_802_11_infrastructure_mode(struct adapter *padapter,
return true;
}
-
u8 rtw_set_802_11_disassociate(struct adapter *padapter)
{
struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
@@ -417,7 +414,6 @@ u8 rtw_set_802_11_authentication_mode(struct adapter *padapter, enum ndis_802_11
u8 rtw_set_802_11_add_wep(struct adapter *padapter, struct ndis_802_11_wep *wep)
{
-
signed int keyid, res;
struct security_priv *psecuritypriv = &(padapter->securitypriv);
u8 ret = _SUCCESS;
--
2.33.0.windows.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-05-01 17:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260205151229.240586-1-kaizhetan.ref@yahoo.com>
2026-02-05 15:12 ` [PATCH] staging: rtl8723bs: remove unnecessary blank lines Tan Kai Zhe
2026-02-05 17:00 ` Ethan Tidmore
2026-02-06 0:24 ` Kai
2026-05-01 16:38 Stepan Ionichev
-- strict thread matches above, loose matches on Subject: below --
2025-12-28 19:44 [PATCH] staging: rtl8723bs: fix block comment coding style Ofir Mirovsky
2025-12-28 19:45 ` [PATCH] staging: rtl8723bs: remove unnecessary blank lines Ofir Mirovsky
2025-12-27 23:45 Ofir Mirovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox