[PATCH] staging: greybus: camera: add comment for mutex

[PATCH] staging: greybus: camera: add comment for mutex

[Jose A. Perez de Azpillaga]

Add a comment to the mutex definition in struct gb_camera to
describe what it protects, satisfying a checkpatch.pl CHECK.

Signed-off-by: Jose A. Perez de Azpillaga <azpijr@gmail.com>
---
Hi,

I noticed a CHECK for alignment in this file on line 267. However,
fixing it pushed the line over 100 characters. I felt that adding
extreme indentation might add more noise than value, so I've only
included the mutex comment fix here.

I'd appreciate your guidance on whether you prefer strict alignment
even if it breaks the 100-column rule in these specific cases.
---
 drivers/staging/greybus/camera.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c
index 62b55bb28408..a6f3637b8871 100644
--- a/drivers/staging/greybus/camera.c
+++ b/drivers/staging/greybus/camera.c
@@ -53,7 +53,7 @@ struct gb_camera {
 	struct gb_connection *data_connection;
 	u16 data_cport_id;

-	struct mutex mutex;
+	struct mutex mutex; /* Protects camera state */
 	enum gb_camera_state state;

 	struct {
--
2.53.0

Re: [PATCH] staging: greybus: camera: add comment for mutex

[Dan Carpenter]

On Wed, Feb 25, 2026 at 12:05:06PM +0100, Jose A. Perez de Azpillaga wrote:
> diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c
> index 62b55bb28408..a6f3637b8871 100644
> --- a/drivers/staging/greybus/camera.c
> +++ b/drivers/staging/greybus/camera.c
> @@ -53,7 +53,7 @@ struct gb_camera {
>  	struct gb_connection *data_connection;
>  	u16 data_cport_id;
> 
> -	struct mutex mutex;
> +	struct mutex mutex; /* Protects camera state */

I'm not sure what it means, and looking at how the mutex is used I
don't feel it's accurate either.

To be honest, I rarely love these lock documentation patches...  :/
They're often really vague and sometimes seem like just guessing based
on the name.

regards,
dan carpenter

>  	enum gb_camera_state state;
> 
>  	struct {

Re: [PATCH] staging: greybus: camera: add comment for mutex

[Jose A. Perez de Azpillaga]

Thank you for the honest feedback. I'm a new contributor and I was
trying to resolve the checkpatch.pl CHECKs to get familiar with the
process, but I see now that vague documentation can be worse than none
at all.

I'll withdraw this patch. Since I'm looking to make my first meaningful
contribution to staging, do you have any suggestions on what types of
issues in Greybus are actually helpful for a beginner to tackle?

regards, jose