* [PATCH] staging: media: av7110: remove dead code in av7110.c [not found] <20260319-av7110-dead-code-v1-1-da6e76804817.ref@yahoo.pl> @ 2026-03-19 10:16 ` Tomasz Unger 2026-03-19 15:45 ` Dan Carpenter 0 siblings, 1 reply; 3+ messages in thread From: Tomasz Unger @ 2026-03-19 10:16 UTC (permalink / raw) To: Mauro Carvalho Chehab, Greg Kroah-Hartman Cc: linux-media, linux-staging, linux-kernel, Tomasz Unger Remove two commented-out lines of dead code that serve no purpose. Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl> --- Checked with scripts/checkpatch.pl - no errors, no warnings. --- drivers/staging/media/av7110/av7110.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/media/av7110/av7110.c b/drivers/staging/media/av7110/av7110.c index 607992100baf..490963c0ccce 100644 --- a/drivers/staging/media/av7110/av7110.c +++ b/drivers/staging/media/av7110/av7110.c @@ -314,7 +314,6 @@ static int DvbDmxFilterCallback(u8 *buffer1, size_t buffer1_len, } } -//#define DEBUG_TIMING static inline void print_time(char *s) { #ifdef DEBUG_TIMING @@ -762,7 +761,6 @@ static int StartHWFilter(struct dvb_demux_filter *dvbdmxfilter) u16 buf[20]; int ret, i; u16 handle; -// u16 mode = 0x0320; u16 mode = 0xb96a; dprintk(4, "%p\n", av7110); --- base-commit: f3f5d52d6bcdf190891601a11910cdd596963c1e change-id: 20260319-av7110-dead-code-ef974a5d7faf Best regards, -- Tomasz Unger <tomasz.unger@yahoo.pl> ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: media: av7110: remove dead code in av7110.c 2026-03-19 10:16 ` [PATCH] staging: media: av7110: remove dead code in av7110.c Tomasz Unger @ 2026-03-19 15:45 ` Dan Carpenter 0 siblings, 0 replies; 3+ messages in thread From: Dan Carpenter @ 2026-03-19 15:45 UTC (permalink / raw) To: Tomasz Unger Cc: Mauro Carvalho Chehab, Greg Kroah-Hartman, linux-media, linux-staging, linux-kernel On Thu, Mar 19, 2026 at 11:16:37AM +0100, Tomasz Unger wrote: > Remove two commented-out lines of dead code that serve no purpose. > > Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl> > --- > Checked with scripts/checkpatch.pl - no errors, no warnings. > --- > drivers/staging/media/av7110/av7110.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/staging/media/av7110/av7110.c b/drivers/staging/media/av7110/av7110.c > index 607992100baf..490963c0ccce 100644 > --- a/drivers/staging/media/av7110/av7110.c > +++ b/drivers/staging/media/av7110/av7110.c > @@ -314,7 +314,6 @@ static int DvbDmxFilterCallback(u8 *buffer1, size_t buffer1_len, > } > } > > -//#define DEBUG_TIMING > static inline void print_time(char *s) > { > #ifdef DEBUG_TIMING ^^^^^^^^^^^^^^^^^^^ Get rid of this stuff too. > @@ -762,7 +761,6 @@ static int StartHWFilter(struct dvb_demux_filter *dvbdmxfilter) > u16 buf[20]; > int ret, i; > u16 handle; > -// u16 mode = 0x0320; At that point, you'll probably want to split it into two patches. regards, dan carpenter > u16 mode = 0xb96a; > > dprintk(4, "%p\n", av7110); > ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <20260320-av7110-dead-code-v1-1-70ad36eba662.ref@yahoo.pl>]
* [PATCH] staging: media: av7110: remove dead code in av7110.c [not found] <20260320-av7110-dead-code-v1-1-70ad36eba662.ref@yahoo.pl> @ 2026-03-20 7:31 ` Tomasz Unger 0 siblings, 0 replies; 3+ messages in thread From: Tomasz Unger @ 2026-03-20 7:31 UTC (permalink / raw) To: Mauro Carvalho Chehab, Greg Kroah-Hartman Cc: linux-media, linux-staging, linux-kernel, Tomasz Unger Remove commented-out line of dead code that serves no purpose. Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl> --- Checked with scripts/checkpatch.pl - no errors, no warnings. --- drivers/staging/media/av7110/av7110.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/media/av7110/av7110.c b/drivers/staging/media/av7110/av7110.c index 607992100baf..c4d54d10d753 100644 --- a/drivers/staging/media/av7110/av7110.c +++ b/drivers/staging/media/av7110/av7110.c @@ -762,7 +762,6 @@ static int StartHWFilter(struct dvb_demux_filter *dvbdmxfilter) u16 buf[20]; int ret, i; u16 handle; -// u16 mode = 0x0320; u16 mode = 0xb96a; dprintk(4, "%p\n", av7110); --- base-commit: 82e1c68ac206efe42854296c462aa83f541ea22c change-id: 20260320-av7110-dead-code-e50a245de380 Best regards, -- Tomasz Unger <tomasz.unger@yahoo.pl> ^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-20 8:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260319-av7110-dead-code-v1-1-da6e76804817.ref@yahoo.pl>
2026-03-19 10:16 ` [PATCH] staging: media: av7110: remove dead code in av7110.c Tomasz Unger
2026-03-19 15:45 ` Dan Carpenter
[not found] <20260320-av7110-dead-code-v1-1-70ad36eba662.ref@yahoo.pl>
2026-03-20 7:31 ` Tomasz Unger
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox