[PATCH] media: tegra-video: tegra210: ensure PHY is disabled in pg_mode stop path

[PATCH] media: tegra-video: tegra210: ensure PHY is disabled in pg_mode stop path

[Hungyu Lin]

tegra210_csi_port_start_streaming() enables the CSI PHY regardless
of pg_mode, but tegra210_csi_port_stop_streaming() skips disabling
the PHY when pg_mode is set due to an early return.

Remove the early return so that the PHY disable path is always
executed, ensuring consistent teardown.

Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
---
 drivers/staging/media/tegra-video/tegra210.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/media/tegra-video/tegra210.c b/drivers/staging/media/tegra-video/tegra210.c
index da99f19a39e7..57b5da11da93 100644
--- a/drivers/staging/media/tegra-video/tegra210.c
+++ b/drivers/staging/media/tegra-video/tegra210.c
@@ -1095,11 +1095,9 @@ tegra210_csi_port_stop_streaming(struct tegra_csi_channel *csi_chan, u8 portno)
 		 (0xf << CSI_PP_START_MARKER_FRAME_MAX_OFFSET) |
 		 CSI_PP_DISABLE);
 
-	if (csi_chan->pg_mode) {
+	if (csi_chan->pg_mode)
 		tpg_write(csi, portno, TEGRA_CSI_PATTERN_GENERATOR_CTRL,
 			  PG_DISABLE);
-		return;
-	}
 
 	if (csi_chan->numlanes == 4) {
 		csi_write(csi, portno, TEGRA_CSI_PHY_CIL_COMMAND,
-- 
2.34.1

Re: [PATCH] media: tegra-video: tegra210: ensure PHY is disabled in pg_mode stop path

[Dan Carpenter]

On Sun, Apr 12, 2026 at 04:36:00PM +0000, Hungyu Lin wrote:
> tegra210_csi_port_start_streaming() enables the CSI PHY regardless
> of pg_mode, but tegra210_csi_port_stop_streaming() skips disabling
> the PHY when pg_mode is set due to an early return.
> 
> Remove the early return so that the PHY disable path is always
> executed, ensuring consistent teardown.
> 
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> ---

The obvious complaint is that this patch needs a Fixes tag.

The early return is suspicious but I don't believe you have tested this
patch.  It would be better to not send untested patches like this,
because there is a risk that the author wrote what they did deliberately.
This code is six years old now, so the original author has probably
moved on to a different project.  It's not necessarily that easy to
review and test the patch.

On the other hand, if someone from Nvidia wants to Ack this patch
then of course we'll merge the v2 of this which has a Fixes tag.
Just wait for someone from Nvidia to respond before resending.

regards,
dan carpenter

Re: [PATCH] media: tegra-video: tegra210: ensure PHY is disabled in pg_mode stop path

[Denny Lin]

Hi Dan,

Thanks, I'll wait for feedback from Nvidia before resending.

Best regards,
Hungyu

On Mon, Apr 13, 2026 at 1:03 AM Dan Carpenter <error27@gmail.com> wrote:
>
> On Sun, Apr 12, 2026 at 04:36:00PM +0000, Hungyu Lin wrote:
> > tegra210_csi_port_start_streaming() enables the CSI PHY regardless
> > of pg_mode, but tegra210_csi_port_stop_streaming() skips disabling
> > the PHY when pg_mode is set due to an early return.
> >
> > Remove the early return so that the PHY disable path is always
> > executed, ensuring consistent teardown.
> >
> > Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> > ---
>
> The obvious complaint is that this patch needs a Fixes tag.
>
> The early return is suspicious but I don't believe you have tested this
> patch.  It would be better to not send untested patches like this,
> because there is a risk that the author wrote what they did deliberately.
> This code is six years old now, so the original author has probably
> moved on to a different project.  It's not necessarily that easy to
> review and test the patch.
>
> On the other hand, if someone from Nvidia wants to Ack this patch
> then of course we'll merge the v2 of this which has a Fixes tag.
> Just wait for someone from Nvidia to respond before resending.
>
> regards,
> dan carpenter
>