* [PATCH] staging: atomisp: remove useless return statement in atomisp_cmd.c
@ 2026-03-01 21:29 Oskar Ray-Frayssinet
2026-03-01 21:39 ` Ethan Tidmore
2026-04-18 8:43 ` Sakari Ailus
0 siblings, 2 replies; 3+ messages in thread
From: Oskar Ray-Frayssinet @ 2026-03-01 21:29 UTC (permalink / raw)
To: hansg, gregkh; +Cc: linux-staging, linux-media, Oskar Ray-Frayssinet
Remove unnecessary return statement at the end of void function.
Signed-off-by: Oskar Ray-Frayssinet <rayfraytech@gmail.com>
---
drivers/staging/media/atomisp/pci/atomisp_cmd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
index d5c5895e06e2..de0446997154 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
@@ -1417,7 +1417,6 @@ static void atomisp_update_grid_info(struct atomisp_sub_device *asd,
err:
atomisp_css_free_stat_buffers(asd);
- return;
}
static void atomisp_curr_user_grid_info(struct atomisp_sub_device *asd,
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: atomisp: remove useless return statement in atomisp_cmd.c
2026-03-01 21:29 [PATCH] staging: atomisp: remove useless return statement in atomisp_cmd.c Oskar Ray-Frayssinet
@ 2026-03-01 21:39 ` Ethan Tidmore
2026-04-18 8:43 ` Sakari Ailus
1 sibling, 0 replies; 3+ messages in thread
From: Ethan Tidmore @ 2026-03-01 21:39 UTC (permalink / raw)
To: Oskar Ray-Frayssinet, hansg, gregkh; +Cc: linux-staging, linux-media
On Sun Mar 1, 2026 at 3:29 PM CST, Oskar Ray-Frayssinet wrote:
> Remove unnecessary return statement at the end of void function.
>
> Signed-off-by: Oskar Ray-Frayssinet <rayfraytech@gmail.com>
> ---
LGTM.
Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>
Thanks,
ET
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: atomisp: remove useless return statement in atomisp_cmd.c
2026-03-01 21:29 [PATCH] staging: atomisp: remove useless return statement in atomisp_cmd.c Oskar Ray-Frayssinet
2026-03-01 21:39 ` Ethan Tidmore
@ 2026-04-18 8:43 ` Sakari Ailus
1 sibling, 0 replies; 3+ messages in thread
From: Sakari Ailus @ 2026-04-18 8:43 UTC (permalink / raw)
To: Oskar Ray-Frayssinet; +Cc: hansg, gregkh, linux-staging, linux-media
Hi Oskar,
On Sun, Mar 01, 2026 at 10:29:00PM +0100, Oskar Ray-Frayssinet wrote:
> Remove unnecessary return statement at the end of void function.
>
> Signed-off-by: Oskar Ray-Frayssinet <rayfraytech@gmail.com>
> ---
> drivers/staging/media/atomisp/pci/atomisp_cmd.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> index d5c5895e06e2..de0446997154 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> @@ -1417,7 +1417,6 @@ static void atomisp_update_grid_info(struct atomisp_sub_device *asd,
>
> err:
> atomisp_css_free_stat_buffers(asd);
> - return;
I'm sure there are more of these in the driver.
> }
>
> static void atomisp_curr_user_grid_info(struct atomisp_sub_device *asd,
--
Regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-04-18 8:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-01 21:29 [PATCH] staging: atomisp: remove useless return statement in atomisp_cmd.c Oskar Ray-Frayssinet
2026-03-01 21:39 ` Ethan Tidmore
2026-04-18 8:43 ` Sakari Ailus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox