public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Mylena Angelica <mylena.asf@gmail.com>
Cc: hansg@kernel.org, mchehab@kernel.org,
	sakari.ailus@linux.intel.com, andy@kernel.org,
	gregkh@linuxfoundation.org, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
	~lkcamp/patches@lists.sr.ht, koike@igalia.com
Subject: Re: [PATCH] media: atomisp: pci: hive_isp_css_common: host: vmem: fix line ending with '('
Date: Fri, 24 Apr 2026 11:45:38 +0300	[thread overview]
Message-ID: <aestsiuGrr6-AEws@ashevche-desk.local> (raw)
In-Reply-To: <20260424010008.325784-1-mylena.asf@gmail.com>

On Thu, Apr 23, 2026 at 10:00:08PM -0300, Mylena Angelica wrote:

...

> Hello!! This is is my first patch,I appreciate any feedback, thanks!

Please, start reviewing others' patches for the same driver and read other
reviews and learn from them first.

I'm not going to repeat what I said already several times on a patches like
this over the very same driver (atomisp).

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2026-04-24  8:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-24  1:00 [PATCH] media: atomisp: pci: hive_isp_css_common: host: vmem: fix line ending with '(' Mylena Angelica
2026-04-24  8:45 ` Andy Shevchenko [this message]
2026-04-28  1:58   ` Helen Koike

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aestsiuGrr6-AEws@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hansg@kernel.org \
    --cc=koike@igalia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mchehab@kernel.org \
    --cc=mylena.asf@gmail.com \
    --cc=sakari.ailus@linux.intel.com \
    --cc=~lkcamp/patches@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox