[PATCH] media: atomisp: pci: hive_isp_css_common: host: vmem: fix line ending with '('

[PATCH] media: atomisp: pci: hive_isp_css_common: host: vmem: fix line ending with '('

[Mylena Angelica]

Adjust the formatting of the function call so the line no longer ends
with '(', fixing the checkpatch warning in vmem.c

Signed-off-by: Mylena Angelica <mylena.asf@gmail.com>

---

Hello!! This is is my first patch,I appreciate any feedback, thanks!
---
 .../media/atomisp/pci/hive_isp_css_common/host/vmem.c     | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/vmem.c b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/vmem.c
index 722b684fbc37..3831092154d1 100644
--- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/vmem.c
+++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/host/vmem.c
@@ -38,12 +38,8 @@ inv_subword(hive_uedge w, unsigned int start, unsigned int end)
 #define move_word(target, target_bit, src) move_subword(target, target_bit, src, 0, uedge_bits)
 
 static void
-move_subword(
-    hive_uedge *target,
-    unsigned int target_bit,
-    hive_uedge src,
-    unsigned int src_start,
-    unsigned int src_end)
+move_subword(hive_uedge *target, unsigned int target_bit, hive_uedge src, unsigned int src_start,
+	     unsigned int src_end)
 {
 	unsigned int start_elem = target_bit / uedge_bits;
 	unsigned int start_bit  = target_bit % uedge_bits;
-- 
2.39.5

Re: [PATCH] media: atomisp: pci: hive_isp_css_common: host: vmem: fix line ending with '('

[Andy Shevchenko]

On Thu, Apr 23, 2026 at 10:00:08PM -0300, Mylena Angelica wrote:

...

> Hello!! This is is my first patch,I appreciate any feedback, thanks!

Please, start reviewing others' patches for the same driver and read other
reviews and learn from them first.

I'm not going to repeat what I said already several times on a patches like
this over the very same driver (atomisp).

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] media: atomisp: pci: hive_isp_css_common: host: vmem: fix line ending with '('

[Helen Koike]

Hi Mylena,

Thanks for your patch, please see my comments below.

On 4/24/26 5:45 AM, Andy Shevchenko wrote:
> On Thu, Apr 23, 2026 at 10:00:08PM -0300, Mylena Angelica wrote:
> 
> ...
> 
>> Hello!! This is is my first patch,I appreciate any feedback, thanks!
> 
> Please, start reviewing others' patches for the same driver and read other
> reviews and learn from them first.

fyi, you can check previous reviews on this driver on lore.kernel.org, 
for instance: https://lore.kernel.org/all/?q=atomisp

> 
> I'm not going to repeat what I said already several times on a patches like
> this over the very same driver (atomisp).
> 

You can see in the previous reviews a few comments to not fix just a 
single occurrence of the issue on the driver, but to fix in a set of 
files or in the entire driver.

This same error occurs multiple times on the same file, and also in the 
entire driver.

My suggestion is for you to fix all this sort of errors under the folder
    drivers/staging/media/atomisp/pci/hive_isp_css_common/host/
otherwise it might become a big commit for a first contribution (unless 
others think otherwise).

i.e.:

    ./scripts/checkpatch.pl 
drivers/staging/media/atomisp/pci/hive_isp_css_common/host/* | \
    grep -a3 "CHECK: Lines should not end with a '('"

I hope this helps.

Regards,
Helen