[PATCH] staging: media: atomisp: consolidate function declarations

[PATCH] staging: media: atomisp: consolidate function declarations

[Shyam Sunder Reddy Padira]

Consolidate split function declarations into a single
lines to fix checkpatch.pl warnings and improve code
readability.This change aligns with the kernel coding
style.

No functional changes.

Signed-off-by: Shyam Sunder Reddy Padira <shyamsunderreddypadira@gmail.com>
---
 drivers/staging/media/atomisp/pci/atomisp_ioctl.h | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/atomisp_ioctl.h b/drivers/staging/media/atomisp/pci/atomisp_ioctl.h
index 57f608f9db56..93f8937699ce 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_ioctl.h
+++ b/drivers/staging/media/atomisp/pci/atomisp_ioctl.h
@@ -17,11 +17,9 @@ struct atomisp_video_pipe;
 
 extern const struct atomisp_format_bridge atomisp_output_fmts[];
 
-const struct
-atomisp_format_bridge *atomisp_get_format_bridge(unsigned int pixelformat);
+const struct atomisp_format_bridge *atomisp_get_format_bridge(unsigned int pixelformat);
 
-const struct
-atomisp_format_bridge *atomisp_get_format_bridge_from_mbus(u32 mbus_code);
+const struct atomisp_format_bridge *atomisp_get_format_bridge_from_mbus(u32 mbus_code);
 
 int atomisp_pipe_check(struct atomisp_video_pipe *pipe, bool streaming_ok);
 
-- 
2.43.0

Re: [PATCH] staging: media: atomisp: consolidate function declarations

[Andy Shevchenko]

On Sun, May 03, 2026 at 11:08:46PM +0530, Shyam Sunder Reddy Padira wrote:
> Consolidate split function declarations into a single
> lines to fix checkpatch.pl warnings and improve code
> readability.This change aligns with the kernel coding
> style.

Too condensed text. We have room for ~72 character per line.

> No functional changes.

...

> -const struct
> -atomisp_format_bridge *atomisp_get_format_bridge(unsigned int pixelformat);
> +const struct atomisp_format_bridge *atomisp_get_format_bridge(unsigned int pixelformat);
>  
> -const struct
> -atomisp_format_bridge *atomisp_get_format_bridge_from_mbus(u32 mbus_code);
> +const struct atomisp_format_bridge *atomisp_get_format_bridge_from_mbus(u32 mbus_code);

It breaks V4L2 coding style expectations.

NAK.

Also other problems mentioned many times in the mailing list. Please, start
reviewing others' patches and learn from other reviews before doing your
changes.

-- 
With Best Regards,
Andy Shevchenko