[PATCH v3] staging: fbtft: convert sysfs attributes to use ATTRIBUTE

Linux kernel staging patches
 help / color / mirror / Atom feed

* [PATCH v3] staging: fbtft: convert sysfs attributes to use ATTRIBUTE_GROUPS
@ 2026-05-12 20:01 Harshit Shaw
  2026-05-12 20:19 ` Andy Shevchenko
  2026-05-13  4:19 ` kernel test robot
  0 siblings, 2 replies; 4+ messages in thread
From: Harshit Shaw @ 2026-05-12 20:01 UTC (permalink / raw)
  To: andriy.shevchenko
  Cc: gregkh, error27, deller, chintanlike, tzimmermann, linux-staging,
	linux-kernel, Harshit Shaw

Replace direct device_create_file() calls with the correct
ATTRIBUTE_GROUPS() macro. Add fbtft_groups as dev_groups in the
driver structure so the driver core automatically adds and removes
the sysfs attributes when a device is bound or unbound.

Signed-off-by: Harshit Shaw <shawharshit116@gmail.com>
---
v3: Remove stray blank line in fbtft_attrs[] array
v2: - Use DEVICE_ATTR_RW() macro instead of DEVICE_ATTR()
    - Move DEVICE_ATTR_RW() definitions closer to their callbacks
    - Remove trailing comma after NULL in attribute array
    - Remove extern declaration from internal.h, not needed
    - Use ATTRIBUTE_GROUPS() macro and add dev_groups to driver
      structure as suggested by Greg KH and Andy Shevchenko
    - Compile tested with: make M=drivers/staging/fbtft modules

 drivers/staging/fbtft/fbtft-core.c  |  3 --
 drivers/staging/fbtft/fbtft-sysfs.c | 81 +++++++++++------------------
 drivers/staging/fbtft/fbtft.h       |  2 +
 drivers/staging/fbtft/internal.h    |  2 -
 4 files changed, 32 insertions(+), 56 deletions(-)

diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
index 3da42c8ca6e3..e6d33127cecc 100644
--- a/drivers/staging/fbtft/fbtft-core.c
+++ b/drivers/staging/fbtft/fbtft-core.c
@@ -782,8 +782,6 @@ int fbtft_register_framebuffer(struct fb_info *fb_info)
 	if (ret < 0)
 		goto reg_fail;
 
-	fbtft_sysfs_init(par);
-
 	if (par->txbuf.buf && par->txbuf.len >= 1024)
 		sprintf(text1, ", %zu KiB buffer memory", par->txbuf.len >> 10);
 	if (spi)
@@ -826,7 +824,6 @@ int fbtft_unregister_framebuffer(struct fb_info *fb_info)
 
 	if (par->fbtftops.unregister_backlight)
 		par->fbtftops.unregister_backlight(par);
-	fbtft_sysfs_exit(par);
 	unregister_framebuffer(fb_info);
 
 	return 0;
diff --git a/drivers/staging/fbtft/fbtft-sysfs.c b/drivers/staging/fbtft/fbtft-sysfs.c
index d05599d80011..579ac9dcdd9f 100644
--- a/drivers/staging/fbtft/fbtft-sysfs.c
+++ b/drivers/staging/fbtft/fbtft-sysfs.c
@@ -107,9 +107,18 @@ sprintf_gamma(struct fbtft_par *par, u32 *curves, char *buf)
 	return len;
 }
 
-static ssize_t store_gamma_curve(struct device *device,
-				 struct device_attribute *attr,
-				 const char *buf, size_t count)
+static ssize_t gamma_show(struct device *device,
+			  struct device_attribute *attr, char *buf)
+{
+	struct fb_info *fb_info = dev_get_drvdata(device);
+	struct fbtft_par *par = fb_info->par;
+
+	return sprintf_gamma(par, par->gamma.curves, buf);
+}
+
+static ssize_t gamma_store(struct device *device,
+			   struct device_attribute *attr,
+			   const char *buf, size_t count)
 {
 	struct fb_info *fb_info = dev_get_drvdata(device);
 	struct fbtft_par *par = fb_info->par;
@@ -133,18 +142,7 @@ static ssize_t store_gamma_curve(struct device *device,
 	return count;
 }
 
-static ssize_t show_gamma_curve(struct device *device,
-				struct device_attribute *attr, char *buf)
-{
-	struct fb_info *fb_info = dev_get_drvdata(device);
-	struct fbtft_par *par = fb_info->par;
-
-	return sprintf_gamma(par, par->gamma.curves, buf);
-}
-
-static struct device_attribute gamma_device_attrs[] = {
-	__ATTR(gamma, 0660, show_gamma_curve, store_gamma_curve),
-};
+static DEVICE_ATTR_RW(gamma);
 
 void fbtft_expand_debug_value(unsigned long *debug)
 {
@@ -173,7 +171,16 @@ void fbtft_expand_debug_value(unsigned long *debug)
 	}
 }
 
-static ssize_t store_debug(struct device *device,
+static ssize_t debug_show(struct device *device,
+			  struct device_attribute *attr, char *buf)
+{
+	struct fb_info *fb_info = dev_get_drvdata(device);
+	struct fbtft_par *par = fb_info->par;
+
+	return sysfs_emit(buf, "%lu\n", par->debug);
+}
+
+static ssize_t debug_store(struct device *device,
 			   struct device_attribute *attr,
 			   const char *buf, size_t count)
 {
@@ -189,40 +196,12 @@ static ssize_t store_debug(struct device *device,
 	return count;
 }
 
-static ssize_t show_debug(struct device *device,
-			  struct device_attribute *attr, char *buf)
-{
-	struct fb_info *fb_info = dev_get_drvdata(device);
-	struct fbtft_par *par = fb_info->par;
-
-	return sysfs_emit(buf, "%lu\n", par->debug);
-}
+static DEVICE_ATTR_RW(debug);
 
-static struct device_attribute debug_device_attr =
-	__ATTR(debug, 0660, show_debug, store_debug);
-
-void fbtft_sysfs_init(struct fbtft_par *par)
-{
-	struct device *dev;
-
-	dev = dev_of_fbinfo(par->info);
-	if (!dev)
-		return;
-
-	device_create_file(dev, &debug_device_attr);
-	if (par->gamma.curves && par->fbtftops.set_gamma)
-		device_create_file(dev, &gamma_device_attrs[0]);
-}
-
-void fbtft_sysfs_exit(struct fbtft_par *par)
-{
-	struct device *dev;
-
-	dev = dev_of_fbinfo(par->info);
-	if (!dev)
-		return;
+static struct attribute *fbtft_attrs[] = {
+	&dev_attr_debug.attr,
+	&dev_attr_gamma.attr,
+	NULL
+};
 
-	device_remove_file(dev, &debug_device_attr);
-	if (par->gamma.curves && par->fbtftops.set_gamma)
-		device_remove_file(dev, &gamma_device_attrs[0]);
-}
+ATTRIBUTE_GROUPS(fbtft);
diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h
index 317be17b95c1..ab71db017d05 100644
--- a/drivers/staging/fbtft/fbtft.h
+++ b/drivers/staging/fbtft/fbtft.h
@@ -299,6 +299,7 @@ static struct spi_driver fbtft_driver_spi_driver = {				\
 	.driver = {								\
 		.name = _name,							\
 		.of_match_table = dt_ids,					\
+		.dev_groups = fbtft_groups,					\
 	},									\
 	.id_table = _spi_ids,							\
 	.probe = fbtft_driver_probe_spi,					\
@@ -328,6 +329,7 @@ static struct platform_driver fbtft_driver_platform_driver = {             \
 		.name   = _name,                                           \
 		.owner  = THIS_MODULE,                                     \
 		.of_match_table = dt_ids,                                  \
+		.dev_groups = fbtft_groups,                                \
 	},                                                                 \
 	.probe  = fbtft_driver_probe_pdev,                                 \
 	.remove = fbtft_driver_remove_pdev,				   \
diff --git a/drivers/staging/fbtft/internal.h b/drivers/staging/fbtft/internal.h
index ae2ff4a4a472..7869cf8dbf2a 100644
--- a/drivers/staging/fbtft/internal.h
+++ b/drivers/staging/fbtft/internal.h
@@ -4,8 +4,6 @@
 #ifndef __LINUX_FBTFT_INTERNAL_H
 #define __LINUX_FBTFT_INTERNAL_H
 
-void fbtft_sysfs_init(struct fbtft_par *par);
-void fbtft_sysfs_exit(struct fbtft_par *par);
 void fbtft_expand_debug_value(unsigned long *debug);
 int fbtft_gamma_parse_str(struct fbtft_par *par, u32 *curves,
 			  const char *str, int size);
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v3] staging: fbtft: convert sysfs attributes to use ATTRIBUTE_GROUPS
  2026-05-12 20:01 [PATCH v3] staging: fbtft: convert sysfs attributes to use ATTRIBUTE_GROUPS Harshit Shaw
@ 2026-05-12 20:19 ` Andy Shevchenko
  2026-05-13  4:19 ` kernel test robot
  1 sibling, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2026-05-12 20:19 UTC (permalink / raw)
  To: Harshit Shaw
  Cc: gregkh, error27, deller, chintanlike, tzimmermann, linux-staging,
	linux-kernel

On Tue, May 12, 2026 at 08:01:04PM +0000, Harshit Shaw wrote:
> Replace direct device_create_file() calls with the correct
> ATTRIBUTE_GROUPS() macro. Add fbtft_groups as dev_groups in the
> driver structure so the driver core automatically adds and removes
> the sysfs attributes when a device is bound or unbound.

You ignored my tag (why?!) and what about Sashiko review? Did it pass?

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v3] staging: fbtft: convert sysfs attributes to use ATTRIBUTE_GROUPS
  2026-05-12 20:01 [PATCH v3] staging: fbtft: convert sysfs attributes to use ATTRIBUTE_GROUPS Harshit Shaw
  2026-05-12 20:19 ` Andy Shevchenko
@ 2026-05-13  4:19 ` kernel test robot
  1 sibling, 0 replies; 4+ messages in thread
From: kernel test robot @ 2026-05-13  4:19 UTC (permalink / raw)
  To: Harshit Shaw, andriy.shevchenko
  Cc: llvm, oe-kbuild-all, gregkh, error27, deller, chintanlike,
	tzimmermann, linux-staging, linux-kernel, Harshit Shaw

Hi Harshit,

kernel test robot noticed the following build errors:

[auto build test ERROR on staging/staging-testing]

url:    https://github.com/intel-lab-lkp/linux/commits/Harshit-Shaw/staging-fbtft-convert-sysfs-attributes-to-use-ATTRIBUTE_GROUPS/20260513-044051
base:   staging/staging-testing
patch link:    https://lore.kernel.org/r/20260512200104.19002-1-shawharshit116%40gmail.com
patch subject: [PATCH v3] staging: fbtft: convert sysfs attributes to use ATTRIBUTE_GROUPS
config: powerpc64-randconfig-002-20260513 (https://download.01.org/0day-ci/archive/20260513/202605131232.m3YE1tEv-lkp@intel.com/config)
compiler: clang version 23.0.0git (https://github.com/llvm/llvm-project 5bac06718f502014fade905512f1d26d578a18f3)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260513/202605131232.m3YE1tEv-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202605131232.m3YE1tEv-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/staging/fbtft/fb_ssd1305.c:198:1: error: use of undeclared identifier 'fbtft_groups'; did you mean 'set_groups'?
     198 | FBTFT_REGISTER_DRIVER(DRVNAME, "solomon,ssd1305", &display);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:323:13: note: expanded from macro 'FBTFT_REGISTER_DRIVER'
     323 |                                                                            \
         |                                                                            ^
     324 | FBTFT_SPI_DRIVER(_name, _compatible, _display, NULL)                       \
         | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:301:17: note: expanded from macro '\
   FBTFT_SPI_DRIVER'
     301 |                 .dev_groups = fbtft_groups,                                     \
         |                               ^~~~~~~~~~~~
   include/linux/cred.h:70:13: note: 'set_groups' declared here
      70 | extern void set_groups(struct cred *, struct group_info *);
         |             ^
>> drivers/staging/fbtft/fb_ssd1305.c:198:1: error: incompatible pointer types initializing 'const struct attribute_group **' with an expression of type 'void (struct cred *, struct group_info *)' [-Wincompatible-pointer-types]
     198 | FBTFT_REGISTER_DRIVER(DRVNAME, "solomon,ssd1305", &display);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:323:13: note: expanded from macro 'FBTFT_REGISTER_DRIVER'
     323 |                                                                            \
         |                                                                            ^
     324 | FBTFT_SPI_DRIVER(_name, _compatible, _display, NULL)                       \
         | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:301:17: note: expanded from macro '\
   FBTFT_SPI_DRIVER'
     301 |                 .dev_groups = fbtft_groups,                                     \
         |                               ^~~~~~~~~~~~
   drivers/staging/fbtft/fb_ssd1305.c:198:1: error: use of undeclared identifier 'fbtft_groups'; did you mean 'set_groups'?
     198 | FBTFT_REGISTER_DRIVER(DRVNAME, "solomon,ssd1305", &display);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:331:17: note: expanded from macro 'FBTFT_REGISTER_DRIVER'
     331 |                 .dev_groups = fbtft_groups,                                \
         |                               ^~~~~~~~~~~~
   include/linux/cred.h:70:13: note: 'set_groups' declared here
      70 | extern void set_groups(struct cred *, struct group_info *);
         |             ^
>> drivers/staging/fbtft/fb_ssd1305.c:198:1: error: incompatible pointer types initializing 'const struct attribute_group **' with an expression of type 'void (struct cred *, struct group_info *)' [-Wincompatible-pointer-types]
     198 | FBTFT_REGISTER_DRIVER(DRVNAME, "solomon,ssd1305", &display);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:331:17: note: expanded from macro 'FBTFT_REGISTER_DRIVER'
     331 |                 .dev_groups = fbtft_groups,                                \
         |                               ^~~~~~~~~~~~
   4 errors generated.
--
   drivers/staging/fbtft/fb_upd161704.c:175:1: error: use of undeclared identifier 'fbtft_groups'; did you mean 'set_groups'?
     175 | FBTFT_REGISTER_DRIVER(DRVNAME, "nec,upd161704", &display);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:323:13: note: expanded from macro 'FBTFT_REGISTER_DRIVER'
     323 |                                                                            \
         |                                                                            ^
     324 | FBTFT_SPI_DRIVER(_name, _compatible, _display, NULL)                       \
         | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:301:17: note: expanded from macro '\
   FBTFT_SPI_DRIVER'
     301 |                 .dev_groups = fbtft_groups,                                     \
         |                               ^~~~~~~~~~~~
   include/linux/cred.h:70:13: note: 'set_groups' declared here
      70 | extern void set_groups(struct cred *, struct group_info *);
         |             ^
>> drivers/staging/fbtft/fb_upd161704.c:175:1: error: incompatible pointer types initializing 'const struct attribute_group **' with an expression of type 'void (struct cred *, struct group_info *)' [-Wincompatible-pointer-types]
     175 | FBTFT_REGISTER_DRIVER(DRVNAME, "nec,upd161704", &display);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:323:13: note: expanded from macro 'FBTFT_REGISTER_DRIVER'
     323 |                                                                            \
         |                                                                            ^
     324 | FBTFT_SPI_DRIVER(_name, _compatible, _display, NULL)                       \
         | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:301:17: note: expanded from macro '\
   FBTFT_SPI_DRIVER'
     301 |                 .dev_groups = fbtft_groups,                                     \
         |                               ^~~~~~~~~~~~
   drivers/staging/fbtft/fb_upd161704.c:175:1: error: use of undeclared identifier 'fbtft_groups'; did you mean 'set_groups'?
     175 | FBTFT_REGISTER_DRIVER(DRVNAME, "nec,upd161704", &display);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:331:17: note: expanded from macro 'FBTFT_REGISTER_DRIVER'
     331 |                 .dev_groups = fbtft_groups,                                \
         |                               ^~~~~~~~~~~~
   include/linux/cred.h:70:13: note: 'set_groups' declared here
      70 | extern void set_groups(struct cred *, struct group_info *);
         |             ^
>> drivers/staging/fbtft/fb_upd161704.c:175:1: error: incompatible pointer types initializing 'const struct attribute_group **' with an expression of type 'void (struct cred *, struct group_info *)' [-Wincompatible-pointer-types]
     175 | FBTFT_REGISTER_DRIVER(DRVNAME, "nec,upd161704", &display);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:331:17: note: expanded from macro 'FBTFT_REGISTER_DRIVER'
     331 |                 .dev_groups = fbtft_groups,                                \
         |                               ^~~~~~~~~~~~
   4 errors generated.
--
   drivers/staging/fbtft/fb_tls8204.c:153:1: error: use of undeclared identifier 'fbtft_groups'; did you mean 'set_groups'?
     153 | FBTFT_REGISTER_DRIVER(DRVNAME, "teralane,tls8204", &display);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:323:13: note: expanded from macro 'FBTFT_REGISTER_DRIVER'
     323 |                                                                            \
         |                                                                            ^
     324 | FBTFT_SPI_DRIVER(_name, _compatible, _display, NULL)                       \
         | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:301:17: note: expanded from macro '\
   FBTFT_SPI_DRIVER'
     301 |                 .dev_groups = fbtft_groups,                                     \
         |                               ^~~~~~~~~~~~
   include/linux/cred.h:70:13: note: 'set_groups' declared here
      70 | extern void set_groups(struct cred *, struct group_info *);
         |             ^
>> drivers/staging/fbtft/fb_tls8204.c:153:1: error: incompatible pointer types initializing 'const struct attribute_group **' with an expression of type 'void (struct cred *, struct group_info *)' [-Wincompatible-pointer-types]
     153 | FBTFT_REGISTER_DRIVER(DRVNAME, "teralane,tls8204", &display);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:323:13: note: expanded from macro 'FBTFT_REGISTER_DRIVER'
     323 |                                                                            \
         |                                                                            ^
     324 | FBTFT_SPI_DRIVER(_name, _compatible, _display, NULL)                       \
         | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:301:17: note: expanded from macro '\
   FBTFT_SPI_DRIVER'
     301 |                 .dev_groups = fbtft_groups,                                     \
         |                               ^~~~~~~~~~~~
   drivers/staging/fbtft/fb_tls8204.c:153:1: error: use of undeclared identifier 'fbtft_groups'; did you mean 'set_groups'?
     153 | FBTFT_REGISTER_DRIVER(DRVNAME, "teralane,tls8204", &display);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:331:17: note: expanded from macro 'FBTFT_REGISTER_DRIVER'
     331 |                 .dev_groups = fbtft_groups,                                \
         |                               ^~~~~~~~~~~~
   include/linux/cred.h:70:13: note: 'set_groups' declared here
      70 | extern void set_groups(struct cred *, struct group_info *);
         |             ^
>> drivers/staging/fbtft/fb_tls8204.c:153:1: error: incompatible pointer types initializing 'const struct attribute_group **' with an expression of type 'void (struct cred *, struct group_info *)' [-Wincompatible-pointer-types]
     153 | FBTFT_REGISTER_DRIVER(DRVNAME, "teralane,tls8204", &display);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:331:17: note: expanded from macro 'FBTFT_REGISTER_DRIVER'
     331 |                 .dev_groups = fbtft_groups,                                \
         |                               ^~~~~~~~~~~~
   4 errors generated.
--
   drivers/staging/fbtft/fb_ili9341.c:136:1: error: use of undeclared identifier 'fbtft_groups'; did you mean 'set_groups'?
     136 | FBTFT_REGISTER_SPI_DRIVER(DRVNAME, "ilitek", "ili9341", &display);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:368:11: note: expanded from macro 'FBTFT_REGISTER_SPI_DRIVER'
     368 |                                                                                 \
         |                                                                                 ^
     369 | FBTFT_SPI_DRIVER(_name, _comp_vend "," _comp_dev, _display, spi_ids)            \
         | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:301:17: note: expanded from macro '\
   FBTFT_SPI_DRIVER'
     301 |                 .dev_groups = fbtft_groups,                                     \
         |                               ^~~~~~~~~~~~
   include/linux/cred.h:70:13: note: 'set_groups' declared here
      70 | extern void set_groups(struct cred *, struct group_info *);
         |             ^
>> drivers/staging/fbtft/fb_ili9341.c:136:1: error: incompatible pointer types initializing 'const struct attribute_group **' with an expression of type 'void (struct cred *, struct group_info *)' [-Wincompatible-pointer-types]
     136 | FBTFT_REGISTER_SPI_DRIVER(DRVNAME, "ilitek", "ili9341", &display);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:368:11: note: expanded from macro 'FBTFT_REGISTER_SPI_DRIVER'
     368 |                                                                                 \
         |                                                                                 ^
     369 | FBTFT_SPI_DRIVER(_name, _comp_vend "," _comp_dev, _display, spi_ids)            \
         | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:301:17: note: expanded from macro '\
   FBTFT_SPI_DRIVER'
     301 |                 .dev_groups = fbtft_groups,                                     \
         |                               ^~~~~~~~~~~~
   2 errors generated.
--
   drivers/staging/fbtft/fb_st7735r.c:165:1: error: use of undeclared identifier 'fbtft_groups'; did you mean 'set_groups'?
     165 | FBTFT_REGISTER_DRIVER(DRVNAME, "sitronix,st7735r", &display);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:323:13: note: expanded from macro 'FBTFT_REGISTER_DRIVER'
     323 |                                                                            \
         |                                                                            ^
     324 | FBTFT_SPI_DRIVER(_name, _compatible, _display, NULL)                       \
         | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:301:17: note: expanded from macro '\
   FBTFT_SPI_DRIVER'
     301 |                 .dev_groups = fbtft_groups,                                     \
         |                               ^~~~~~~~~~~~
   include/linux/cred.h:70:13: note: 'set_groups' declared here
      70 | extern void set_groups(struct cred *, struct group_info *);
         |             ^
>> drivers/staging/fbtft/fb_st7735r.c:165:1: error: incompatible pointer types initializing 'const struct attribute_group **' with an expression of type 'void (struct cred *, struct group_info *)' [-Wincompatible-pointer-types]
     165 | FBTFT_REGISTER_DRIVER(DRVNAME, "sitronix,st7735r", &display);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:323:13: note: expanded from macro 'FBTFT_REGISTER_DRIVER'
     323 |                                                                            \
         |                                                                            ^
     324 | FBTFT_SPI_DRIVER(_name, _compatible, _display, NULL)                       \
         | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:301:17: note: expanded from macro '\
   FBTFT_SPI_DRIVER'
     301 |                 .dev_groups = fbtft_groups,                                     \
         |                               ^~~~~~~~~~~~
   drivers/staging/fbtft/fb_st7735r.c:165:1: error: use of undeclared identifier 'fbtft_groups'; did you mean 'set_groups'?
     165 | FBTFT_REGISTER_DRIVER(DRVNAME, "sitronix,st7735r", &display);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:331:17: note: expanded from macro 'FBTFT_REGISTER_DRIVER'
     331 |                 .dev_groups = fbtft_groups,                                \
         |                               ^~~~~~~~~~~~
   include/linux/cred.h:70:13: note: 'set_groups' declared here
      70 | extern void set_groups(struct cred *, struct group_info *);
         |             ^
>> drivers/staging/fbtft/fb_st7735r.c:165:1: error: incompatible pointer types initializing 'const struct attribute_group **' with an expression of type 'void (struct cred *, struct group_info *)' [-Wincompatible-pointer-types]
     165 | FBTFT_REGISTER_DRIVER(DRVNAME, "sitronix,st7735r", &display);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:331:17: note: expanded from macro 'FBTFT_REGISTER_DRIVER'
     331 |                 .dev_groups = fbtft_groups,                                \
         |                               ^~~~~~~~~~~~
   4 errors generated.
--
   drivers/staging/fbtft/fb_hx8357d.c:178:1: error: use of undeclared identifier 'fbtft_groups'; did you mean 'set_groups'?
     178 | FBTFT_REGISTER_DRIVER(DRVNAME, "himax,hx8357d", &display);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:323:13: note: expanded from macro 'FBTFT_REGISTER_DRIVER'
     323 |                                                                            \
         |                                                                            ^
     324 | FBTFT_SPI_DRIVER(_name, _compatible, _display, NULL)                       \
         | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:301:17: note: expanded from macro '\
   FBTFT_SPI_DRIVER'
     301 |                 .dev_groups = fbtft_groups,                                     \
         |                               ^~~~~~~~~~~~
   include/linux/cred.h:70:13: note: 'set_groups' declared here
      70 | extern void set_groups(struct cred *, struct group_info *);
         |             ^
>> drivers/staging/fbtft/fb_hx8357d.c:178:1: error: incompatible pointer types initializing 'const struct attribute_group **' with an expression of type 'void (struct cred *, struct group_info *)' [-Wincompatible-pointer-types]
     178 | FBTFT_REGISTER_DRIVER(DRVNAME, "himax,hx8357d", &display);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:323:13: note: expanded from macro 'FBTFT_REGISTER_DRIVER'
     323 |                                                                            \
         |                                                                            ^
     324 | FBTFT_SPI_DRIVER(_name, _compatible, _display, NULL)                       \
         | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:301:17: note: expanded from macro '\
   FBTFT_SPI_DRIVER'
     301 |                 .dev_groups = fbtft_groups,                                     \
         |                               ^~~~~~~~~~~~
   drivers/staging/fbtft/fb_hx8357d.c:178:1: error: use of undeclared identifier 'fbtft_groups'; did you mean 'set_groups'?
     178 | FBTFT_REGISTER_DRIVER(DRVNAME, "himax,hx8357d", &display);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:331:17: note: expanded from macro 'FBTFT_REGISTER_DRIVER'
     331 |                 .dev_groups = fbtft_groups,                                \
         |                               ^~~~~~~~~~~~
   include/linux/cred.h:70:13: note: 'set_groups' declared here
      70 | extern void set_groups(struct cred *, struct group_info *);
         |             ^
>> drivers/staging/fbtft/fb_hx8357d.c:178:1: error: incompatible pointer types initializing 'const struct attribute_group **' with an expression of type 'void (struct cred *, struct group_info *)' [-Wincompatible-pointer-types]
     178 | FBTFT_REGISTER_DRIVER(DRVNAME, "himax,hx8357d", &display);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:331:17: note: expanded from macro 'FBTFT_REGISTER_DRIVER'
     331 |                 .dev_groups = fbtft_groups,                                \
         |                               ^~~~~~~~~~~~
   4 errors generated.
--
   drivers/staging/fbtft/fb_hx8347d.c:174:1: error: use of undeclared identifier 'fbtft_groups'; did you mean 'set_groups'?
     174 | FBTFT_REGISTER_DRIVER(DRVNAME, "himax,hx8347d", &display);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:323:13: note: expanded from macro 'FBTFT_REGISTER_DRIVER'
     323 |                                                                            \
         |                                                                            ^
     324 | FBTFT_SPI_DRIVER(_name, _compatible, _display, NULL)                       \
         | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:301:17: note: expanded from macro '\
   FBTFT_SPI_DRIVER'
     301 |                 .dev_groups = fbtft_groups,                                     \
         |                               ^~~~~~~~~~~~
   include/linux/cred.h:70:13: note: 'set_groups' declared here
      70 | extern void set_groups(struct cred *, struct group_info *);
         |             ^
>> drivers/staging/fbtft/fb_hx8347d.c:174:1: error: incompatible pointer types initializing 'const struct attribute_group **' with an expression of type 'void (struct cred *, struct group_info *)' [-Wincompatible-pointer-types]
     174 | FBTFT_REGISTER_DRIVER(DRVNAME, "himax,hx8347d", &display);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:323:13: note: expanded from macro 'FBTFT_REGISTER_DRIVER'
     323 |                                                                            \
         |                                                                            ^
     324 | FBTFT_SPI_DRIVER(_name, _compatible, _display, NULL)                       \
         | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:301:17: note: expanded from macro '\
   FBTFT_SPI_DRIVER'
     301 |                 .dev_groups = fbtft_groups,                                     \
         |                               ^~~~~~~~~~~~
   drivers/staging/fbtft/fb_hx8347d.c:174:1: error: use of undeclared identifier 'fbtft_groups'; did you mean 'set_groups'?
     174 | FBTFT_REGISTER_DRIVER(DRVNAME, "himax,hx8347d", &display);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:331:17: note: expanded from macro 'FBTFT_REGISTER_DRIVER'
     331 |                 .dev_groups = fbtft_groups,                                \
         |                               ^~~~~~~~~~~~
   include/linux/cred.h:70:13: note: 'set_groups' declared here
      70 | extern void set_groups(struct cred *, struct group_info *);
         |             ^
>> drivers/staging/fbtft/fb_hx8347d.c:174:1: error: incompatible pointer types initializing 'const struct attribute_group **' with an expression of type 'void (struct cred *, struct group_info *)' [-Wincompatible-pointer-types]
     174 | FBTFT_REGISTER_DRIVER(DRVNAME, "himax,hx8347d", &display);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:331:17: note: expanded from macro 'FBTFT_REGISTER_DRIVER'
     331 |                 .dev_groups = fbtft_groups,                                \
         |                               ^~~~~~~~~~~~
   4 errors generated.
--
   drivers/staging/fbtft/fb_uc1611.c:325:1: error: use of undeclared identifier 'fbtft_groups'; did you mean 'set_groups'?
     325 | FBTFT_REGISTER_DRIVER(DRVNAME, "ultrachip,uc1611", &display);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:323:13: note: expanded from macro 'FBTFT_REGISTER_DRIVER'
     323 |                                                                            \
         |                                                                            ^
     324 | FBTFT_SPI_DRIVER(_name, _compatible, _display, NULL)                       \
         | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:301:17: note: expanded from macro '\
   FBTFT_SPI_DRIVER'
     301 |                 .dev_groups = fbtft_groups,                                     \
         |                               ^~~~~~~~~~~~
   include/linux/cred.h:70:13: note: 'set_groups' declared here
      70 | extern void set_groups(struct cred *, struct group_info *);
         |             ^
>> drivers/staging/fbtft/fb_uc1611.c:325:1: error: incompatible pointer types initializing 'const struct attribute_group **' with an expression of type 'void (struct cred *, struct group_info *)' [-Wincompatible-pointer-types]
     325 | FBTFT_REGISTER_DRIVER(DRVNAME, "ultrachip,uc1611", &display);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:323:13: note: expanded from macro 'FBTFT_REGISTER_DRIVER'
     323 |                                                                            \
         |                                                                            ^
     324 | FBTFT_SPI_DRIVER(_name, _compatible, _display, NULL)                       \
         | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:301:17: note: expanded from macro '\
   FBTFT_SPI_DRIVER'
     301 |                 .dev_groups = fbtft_groups,                                     \
         |                               ^~~~~~~~~~~~
   drivers/staging/fbtft/fb_uc1611.c:325:1: error: use of undeclared identifier 'fbtft_groups'; did you mean 'set_groups'?
     325 | FBTFT_REGISTER_DRIVER(DRVNAME, "ultrachip,uc1611", &display);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:331:17: note: expanded from macro 'FBTFT_REGISTER_DRIVER'
     331 |                 .dev_groups = fbtft_groups,                                \
         |                               ^~~~~~~~~~~~
   include/linux/cred.h:70:13: note: 'set_groups' declared here
      70 | extern void set_groups(struct cred *, struct group_info *);
         |             ^
>> drivers/staging/fbtft/fb_uc1611.c:325:1: error: incompatible pointer types initializing 'const struct attribute_group **' with an expression of type 'void (struct cred *, struct group_info *)' [-Wincompatible-pointer-types]
     325 | FBTFT_REGISTER_DRIVER(DRVNAME, "ultrachip,uc1611", &display);
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/staging/fbtft/fbtft.h:331:17: note: expanded from macro 'FBTFT_REGISTER_DRIVER'
     331 |                 .dev_groups = fbtft_groups,                                \
         |                               ^~~~~~~~~~~~
   4 errors generated.
..


vim +198 drivers/staging/fbtft/fb_ssd1305.c

5795354f75132a Alexey Mednyy 2016-01-27  197  
5795354f75132a Alexey Mednyy 2016-01-27 @198  FBTFT_REGISTER_DRIVER(DRVNAME, "solomon,ssd1305", &display);
5795354f75132a Alexey Mednyy 2016-01-27  199  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v3] staging: fbtft: convert sysfs attributes to use ATTRIBUTE_GROUPS
@ 2026-05-12 20:34 Harshit Shaw
  0 siblings, 0 replies; 4+ messages in thread
From: Harshit Shaw @ 2026-05-12 20:34 UTC (permalink / raw)
  To: andriy.shevchenko
  Cc: gregkh, error27, deller, chintanlike, tzimmermann, linux-staging,
	linux-kernel, Harshit Shaw

Replace direct device_create_file() calls with the correct
ATTRIBUTE_GROUPS() macro. Add fbtft_groups as dev_groups in the
driver structure so the driver core automatically adds and removes
the sysfs attributes when a device is bound or unbound.

Signed-off-by: Harshit Shaw <shawharshit116@gmail.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
---
v3: Remove stray blank line in fbtft_attrs[] array
v2: - Use DEVICE_ATTR_RW() macro instead of DEVICE_ATTR()
    - Move DEVICE_ATTR_RW() definitions closer to their callbacks
    - Remove trailing comma after NULL in attribute array
    - Remove extern declaration from internal.h, not needed
    - Use ATTRIBUTE_GROUPS() macro and add dev_groups to driver
      structure as suggested by Greg KH and Andy Shevchenko
    - Compile tested with: make M=drivers/staging/fbtft modules

 drivers/staging/fbtft/fbtft-core.c  |  3 --
 drivers/staging/fbtft/fbtft-sysfs.c | 81 +++++++++++------------------
 drivers/staging/fbtft/fbtft.h       |  2 +
 drivers/staging/fbtft/internal.h    |  2 -
 4 files changed, 32 insertions(+), 56 deletions(-)

diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
index 3da42c8ca6e3..e6d33127cecc 100644
--- a/drivers/staging/fbtft/fbtft-core.c
+++ b/drivers/staging/fbtft/fbtft-core.c
@@ -782,8 +782,6 @@ int fbtft_register_framebuffer(struct fb_info *fb_info)
 	if (ret < 0)
 		goto reg_fail;
 
-	fbtft_sysfs_init(par);
-
 	if (par->txbuf.buf && par->txbuf.len >= 1024)
 		sprintf(text1, ", %zu KiB buffer memory", par->txbuf.len >> 10);
 	if (spi)
@@ -826,7 +824,6 @@ int fbtft_unregister_framebuffer(struct fb_info *fb_info)
 
 	if (par->fbtftops.unregister_backlight)
 		par->fbtftops.unregister_backlight(par);
-	fbtft_sysfs_exit(par);
 	unregister_framebuffer(fb_info);
 
 	return 0;
diff --git a/drivers/staging/fbtft/fbtft-sysfs.c b/drivers/staging/fbtft/fbtft-sysfs.c
index d05599d80011..579ac9dcdd9f 100644
--- a/drivers/staging/fbtft/fbtft-sysfs.c
+++ b/drivers/staging/fbtft/fbtft-sysfs.c
@@ -107,9 +107,18 @@ sprintf_gamma(struct fbtft_par *par, u32 *curves, char *buf)
 	return len;
 }
 
-static ssize_t store_gamma_curve(struct device *device,
-				 struct device_attribute *attr,
-				 const char *buf, size_t count)
+static ssize_t gamma_show(struct device *device,
+			  struct device_attribute *attr, char *buf)
+{
+	struct fb_info *fb_info = dev_get_drvdata(device);
+	struct fbtft_par *par = fb_info->par;
+
+	return sprintf_gamma(par, par->gamma.curves, buf);
+}
+
+static ssize_t gamma_store(struct device *device,
+			   struct device_attribute *attr,
+			   const char *buf, size_t count)
 {
 	struct fb_info *fb_info = dev_get_drvdata(device);
 	struct fbtft_par *par = fb_info->par;
@@ -133,18 +142,7 @@ static ssize_t store_gamma_curve(struct device *device,
 	return count;
 }
 
-static ssize_t show_gamma_curve(struct device *device,
-				struct device_attribute *attr, char *buf)
-{
-	struct fb_info *fb_info = dev_get_drvdata(device);
-	struct fbtft_par *par = fb_info->par;
-
-	return sprintf_gamma(par, par->gamma.curves, buf);
-}
-
-static struct device_attribute gamma_device_attrs[] = {
-	__ATTR(gamma, 0660, show_gamma_curve, store_gamma_curve),
-};
+static DEVICE_ATTR_RW(gamma);
 
 void fbtft_expand_debug_value(unsigned long *debug)
 {
@@ -173,7 +171,16 @@ void fbtft_expand_debug_value(unsigned long *debug)
 	}
 }
 
-static ssize_t store_debug(struct device *device,
+static ssize_t debug_show(struct device *device,
+			  struct device_attribute *attr, char *buf)
+{
+	struct fb_info *fb_info = dev_get_drvdata(device);
+	struct fbtft_par *par = fb_info->par;
+
+	return sysfs_emit(buf, "%lu\n", par->debug);
+}
+
+static ssize_t debug_store(struct device *device,
 			   struct device_attribute *attr,
 			   const char *buf, size_t count)
 {
@@ -189,40 +196,12 @@ static ssize_t store_debug(struct device *device,
 	return count;
 }
 
-static ssize_t show_debug(struct device *device,
-			  struct device_attribute *attr, char *buf)
-{
-	struct fb_info *fb_info = dev_get_drvdata(device);
-	struct fbtft_par *par = fb_info->par;
-
-	return sysfs_emit(buf, "%lu\n", par->debug);
-}
+static DEVICE_ATTR_RW(debug);
 
-static struct device_attribute debug_device_attr =
-	__ATTR(debug, 0660, show_debug, store_debug);
-
-void fbtft_sysfs_init(struct fbtft_par *par)
-{
-	struct device *dev;
-
-	dev = dev_of_fbinfo(par->info);
-	if (!dev)
-		return;
-
-	device_create_file(dev, &debug_device_attr);
-	if (par->gamma.curves && par->fbtftops.set_gamma)
-		device_create_file(dev, &gamma_device_attrs[0]);
-}
-
-void fbtft_sysfs_exit(struct fbtft_par *par)
-{
-	struct device *dev;
-
-	dev = dev_of_fbinfo(par->info);
-	if (!dev)
-		return;
+static struct attribute *fbtft_attrs[] = {
+	&dev_attr_debug.attr,
+	&dev_attr_gamma.attr,
+	NULL
+};
 
-	device_remove_file(dev, &debug_device_attr);
-	if (par->gamma.curves && par->fbtftops.set_gamma)
-		device_remove_file(dev, &gamma_device_attrs[0]);
-}
+ATTRIBUTE_GROUPS(fbtft);
diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h
index 317be17b95c1..ab71db017d05 100644
--- a/drivers/staging/fbtft/fbtft.h
+++ b/drivers/staging/fbtft/fbtft.h
@@ -299,6 +299,7 @@ static struct spi_driver fbtft_driver_spi_driver = {				\
 	.driver = {								\
 		.name = _name,							\
 		.of_match_table = dt_ids,					\
+		.dev_groups = fbtft_groups,					\
 	},									\
 	.id_table = _spi_ids,							\
 	.probe = fbtft_driver_probe_spi,					\
@@ -328,6 +329,7 @@ static struct platform_driver fbtft_driver_platform_driver = {             \
 		.name   = _name,                                           \
 		.owner  = THIS_MODULE,                                     \
 		.of_match_table = dt_ids,                                  \
+		.dev_groups = fbtft_groups,                                \
 	},                                                                 \
 	.probe  = fbtft_driver_probe_pdev,                                 \
 	.remove = fbtft_driver_remove_pdev,				   \
diff --git a/drivers/staging/fbtft/internal.h b/drivers/staging/fbtft/internal.h
index ae2ff4a4a472..7869cf8dbf2a 100644
--- a/drivers/staging/fbtft/internal.h
+++ b/drivers/staging/fbtft/internal.h
@@ -4,8 +4,6 @@
 #ifndef __LINUX_FBTFT_INTERNAL_H
 #define __LINUX_FBTFT_INTERNAL_H
 
-void fbtft_sysfs_init(struct fbtft_par *par);
-void fbtft_sysfs_exit(struct fbtft_par *par);
 void fbtft_expand_debug_value(unsigned long *debug);
 int fbtft_gamma_parse_str(struct fbtft_par *par, u32 *curves,
 			  const char *str, int size);
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-05-13  4:19 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-12 20:01 [PATCH v3] staging: fbtft: convert sysfs attributes to use ATTRIBUTE_GROUPS Harshit Shaw
2026-05-12 20:19 ` Andy Shevchenko
2026-05-13  4:19 ` kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-12 20:34 Harshit Shaw

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox