From: Dan Carpenter <error27@gmail.com>
To: Pang-Chun Liu <kevin95120@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: remove unused rtl8192c function declarations
Date: Fri, 22 May 2026 08:54:38 +0300 [thread overview]
Message-ID: <ag_vnliWpoxnxw3V@stanley.mountain> (raw)
In-Reply-To: <20260521144113.28869-1-kevin95120@gmail.com>
On Thu, May 21, 2026 at 10:41:12PM +0800, Pang-Chun Liu wrote:
> rtl8192c_translate_rx_signal_stuff() and rtl8192c_query_rx_desc_status()
> are declared in rtl8192c_recv.h but neither has a definition anywhere
> in the driver, and there are no callers. Remove the dead declarations.
>
> Signed-off-by: Pang-Chun Liu <kevin95120@gmail.com>
> ---
This kind of commit doesn't get a Fixes tag since it's not a bug, but
I'm always interested to see how mistakes happen. It's better if the
commit message can say which commit added it. In this case the dead
code was added when we initially merged the driver so it's fine.
Reviewed-by: Dan Carpenter <error27@gmail.com>
regards,
dan carpenter
next prev parent reply other threads:[~2026-05-22 5:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 14:41 [PATCH] staging: rtl8723bs: remove unused rtl8192c function declarations Pang-Chun Liu
2026-05-22 5:54 ` Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-07-08 14:22 Jad Keskes
2026-07-10 14:47 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ag_vnliWpoxnxw3V@stanley.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kevin95120@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox