[PATCH] staging: rtl8723bs: remove unused rtl8192c function declarations

[PATCH] staging: rtl8723bs: remove unused rtl8192c function declarations

[Pang-Chun Liu]

rtl8192c_translate_rx_signal_stuff() and rtl8192c_query_rx_desc_status()
are declared in rtl8192c_recv.h but neither has a definition anywhere
in the driver, and there are no callers. Remove the dead declarations.

Signed-off-by: Pang-Chun Liu <kevin95120@gmail.com>
---
 drivers/staging/rtl8723bs/include/rtl8192c_recv.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/include/rtl8192c_recv.h b/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
index 1f86654f0403..b63625ab4e45 100644
--- a/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
+++ b/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
@@ -30,7 +30,4 @@ struct phy_stat {
 /*  Rx smooth factor */
 #define	Rx_Smooth_Factor (20)
 
-void rtl8192c_translate_rx_signal_stuff(union recv_frame *precvframe, struct phy_stat *pphy_status);
-void rtl8192c_query_rx_desc_status(union recv_frame *precvframe, struct recv_stat *pdesc);
-
 #endif
-- 
2.53.0

Re: [PATCH] staging: rtl8723bs: remove unused rtl8192c function declarations

[Dan Carpenter]

On Thu, May 21, 2026 at 10:41:12PM +0800, Pang-Chun Liu wrote:
> rtl8192c_translate_rx_signal_stuff() and rtl8192c_query_rx_desc_status()
> are declared in rtl8192c_recv.h but neither has a definition anywhere
> in the driver, and there are no callers. Remove the dead declarations.
> 
> Signed-off-by: Pang-Chun Liu <kevin95120@gmail.com>
> ---

This kind of commit doesn't get a Fixes tag since it's not a bug, but
I'm always interested to see how mistakes happen.  It's better if the
commit message can say which commit added it.  In this case the dead
code was added when we initially merged the driver so it's fine.

Reviewed-by: Dan Carpenter <error27@gmail.com>

regards,
dan carpenter

[PATCH] staging: rtl8723bs: remove unused rtl8192c function declarations

[Jad Keskes]

Remove two function declarations from rtl8192c_recv.h that have no
implementation and are never called in the rtl8723bs driver:

  - rtl8192c_translate_rx_signal_stuff()
  - rtl8192c_query_rx_desc_status()

These are leftovers from the original Realtek multi-chip codebase
and relate to the RTL8192C family, not the RTL8723B.

Signed-off-by: Jad Keskes <inasj268@gmail.com>
---
v2: Added changelog below the --- line

 drivers/staging/rtl8723bs/include/rtl8192c_recv.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/include/rtl8192c_recv.h b/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
index 1f86654f0403..b63625ab4e45 100644
--- a/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
+++ b/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
@@ -30,7 +30,4 @@ struct phy_stat {
 /*  Rx smooth factor */
 #define	Rx_Smooth_Factor (20)
 
-void rtl8192c_translate_rx_signal_stuff(union recv_frame *precvframe, struct phy_stat *pphy_status);
-void rtl8192c_query_rx_desc_status(union recv_frame *precvframe, struct recv_stat *pdesc);
-
 #endif
-- 
2.55.0

Re: [PATCH] staging: rtl8723bs: remove unused rtl8192c function declarations

[Greg Kroah-Hartman]

On Wed, Jul 08, 2026 at 03:22:27PM +0100, Jad Keskes wrote:
> Remove two function declarations from rtl8192c_recv.h that have no
> implementation and are never called in the rtl8723bs driver:
> 
>   - rtl8192c_translate_rx_signal_stuff()
>   - rtl8192c_query_rx_desc_status()
> 
> These are leftovers from the original Realtek multi-chip codebase
> and relate to the RTL8192C family, not the RTL8723B.
> 
> Signed-off-by: Jad Keskes <inasj268@gmail.com>
> ---
> v2: Added changelog below the --- line
> 
>  drivers/staging/rtl8723bs/include/rtl8192c_recv.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/include/rtl8192c_recv.h b/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
> index 1f86654f0403..b63625ab4e45 100644
> --- a/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
> +++ b/drivers/staging/rtl8723bs/include/rtl8192c_recv.h
> @@ -30,7 +30,4 @@ struct phy_stat {
>  /*  Rx smooth factor */
>  #define	Rx_Smooth_Factor (20)
>  
> -void rtl8192c_translate_rx_signal_stuff(union recv_frame *precvframe, struct phy_stat *pphy_status);
> -void rtl8192c_query_rx_desc_status(union recv_frame *precvframe, struct recv_stat *pdesc);
> -
>  #endif
> -- 
> 2.55.0
> 
> 

Someone already sent this before you did, sorry.

greg k-h