From: Dan Carpenter <error27@gmail.com>
To: Eugene Mavick <m@mavick.dev>
Cc: gregkh@linuxfoundation.org, khomenkov@mailbox.org,
ethantidmore06@gmail.com, m.steinmoetzger@gmail.com,
tomasz.unger@yahoo.pl, arthur.stupa@gmail.com,
jannik@jrehkemper.de, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: rtl8723bs: remove unnecessary parentheses
Date: Wed, 3 Jun 2026 11:44:20 +0300 [thread overview]
Message-ID: <ah_pZPamB-HJhawR@stanley.mountain> (raw)
In-Reply-To: <20260603080105.780648-1-m@mavick.dev>
On Wed, Jun 03, 2026 at 04:01:05PM +0800, Eugene Mavick wrote:
> Remove unnecessary parentheses to clear checkpatch.pl warnings
>
> Example of fixed warnings:
> CHECK: Unnecessary parentheses around dvobj->cam_cache[id]
> CHECK: Unnecessary parentheses around 'val != 0xfe'
No, leave these. It's a staging specific rule. I even modified
checkpatch to not warn about these so I'm not sure how you are seeing
them. I just tested again and checkpatch doesn't warn...
regards,
dan carpenter
next prev parent reply other threads:[~2026-06-03 8:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-30 3:16 [PATCH] staging: rtl8723bs: remove unnecessary parentheses Eugene Mavick
2026-05-31 6:10 ` [PATCH v2] " Eugene Mavick
2026-06-01 11:29 ` Dan Carpenter
[not found] ` <20260603080105.780648-1-m@mavick.dev>
2026-06-03 8:44 ` Dan Carpenter [this message]
[not found] ` <DIZB2839PXFV.3A5L73XAO2X67@mavick.dev>
2026-06-03 10:18 ` [PATCH v3] " Dan Carpenter
2026-06-04 4:51 ` [PATCH v4] " Eugene Mavick
2026-06-04 5:29 ` Dan Carpenter
[not found] <20260601-staging-fix-1-v3-1-331ec58683c0.ref@yahoo.pl>
2026-06-01 18:11 ` [PATCH v3] " Tomasz Unger
2026-06-01 18:29 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ah_pZPamB-HJhawR@stanley.mountain \
--to=error27@gmail.com \
--cc=arthur.stupa@gmail.com \
--cc=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jannik@jrehkemper.de \
--cc=khomenkov@mailbox.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=m.steinmoetzger@gmail.com \
--cc=m@mavick.dev \
--cc=tomasz.unger@yahoo.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox