From: Dan Carpenter <error27@gmail.com>
To: Eugene Mavick <m@mavick.dev>
Cc: gregkh@linuxfoundation.org, khomenkov@mailbox.org,
ethantidmore06@gmail.com, m.steinmoetzger@gmail.com,
tomasz.unger@yahoo.pl, arthur.stupa@gmail.com,
jannik@jrehkemper.de, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] staging: rtl8723bs: remove unnecessary parentheses
Date: Thu, 4 Jun 2026 10:54:30 +0300 [thread overview]
Message-ID: <aiEvNg3_j4xtiLSN@stanley.mountain> (raw)
In-Reply-To: <20260604074923.841460-1-m@mavick.dev>
On Thu, Jun 04, 2026 at 03:49:23PM +0800, Eugene Mavick wrote:
> Remove unnecessary parantheses around &(foo->bar) type statements to
> improve code readability
>
> Signed-off-by: Eugene Mavick <m@mavick.dev>
> ---
From my perspective I'm seeing this patch twice in a day... Just wait
a bit... Remove this part as well.
if ((pmlmepriv->timeBcnInfoChkStart != 0) && (jiffies_to_msecs(jiffies - pmlmepriv->timeBcnInfoChkStart) <= DISCONNECT_BY_CHK_BCN_FAIL_OBSERV_PERIOD_IN_MS)
- && (pmlmepriv->NumOfBcnInfoChkFail >= DISCONNECT_BY_CHK_BCN_FAIL_THRESHOLD)) {
+ && pmlmepriv->NumOfBcnInfoChkFail >= DISCONNECT_BY_CHK_BCN_FAIL_THRESHOLD) {
pmlmepriv->timeBcnInfoChkStart = 0;
pmlmepriv->NumOfBcnInfoChkFail = 0;
return _FAIL;
regards,
dan carpenter
next prev parent reply other threads:[~2026-06-04 7:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-30 3:16 [PATCH] staging: rtl8723bs: remove unnecessary parentheses Eugene Mavick
2026-05-31 6:10 ` [PATCH v2] " Eugene Mavick
2026-06-01 11:29 ` Dan Carpenter
[not found] ` <20260603080105.780648-1-m@mavick.dev>
2026-06-03 8:44 ` [PATCH v3] " Dan Carpenter
[not found] ` <DIZB2839PXFV.3A5L73XAO2X67@mavick.dev>
2026-06-03 10:18 ` Dan Carpenter
2026-06-04 4:51 ` [PATCH v4] " Eugene Mavick
2026-06-04 5:29 ` Dan Carpenter
2026-06-04 7:49 ` [PATCH v5] " Eugene Mavick
2026-06-04 7:54 ` Dan Carpenter [this message]
2026-06-04 9:56 ` [PATCH v6] " Eugene Mavick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aiEvNg3_j4xtiLSN@stanley.mountain \
--to=error27@gmail.com \
--cc=arthur.stupa@gmail.com \
--cc=ethantidmore06@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jannik@jrehkemper.de \
--cc=khomenkov@mailbox.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=m.steinmoetzger@gmail.com \
--cc=m@mavick.dev \
--cc=tomasz.unger@yahoo.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox