* [PATCH] staging: rtl8723bs: remove redundant condition in wlanhdr_to_ethhdr
@ 2026-06-19 10:13 Alonso Garrigues
2026-06-19 10:25 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Alonso Garrigues @ 2026-06-19 10:13 UTC (permalink / raw)
To: gregkh; +Cc: straube.linux, linux-staging, linux-kernel, Alonso Garrigues
Comparing boolean return value to true with == is redundant.
Remove the explicit comparison and the extra parentheses.
Signed-off-by: Alonso Garrigues <agarrigues@riseup.net>
---
drivers/staging/rtl8723bs/core/rtw_recv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
index f78194d508df..71dc6dd6473a 100644
--- a/drivers/staging/rtl8723bs/core/rtw_recv.c
+++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
@@ -1597,7 +1597,7 @@ static signed int wlanhdr_to_ethhdr(union recv_frame *precvframe)
eth_type = ntohs(be_tmp); /* pattrib->ether_type */
pattrib->eth_type = eth_type;
- if ((check_fwstate(pmlmepriv, WIFI_MP_STATE) == true)) {
+ if (check_fwstate(pmlmepriv, WIFI_MP_STATE)) {
ptr += rmv_len;
*ptr = 0x87;
*(ptr + 1) = 0x12;
--
2.54.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtl8723bs: remove redundant condition in wlanhdr_to_ethhdr
2026-06-19 10:13 [PATCH] staging: rtl8723bs: remove redundant condition in wlanhdr_to_ethhdr Alonso Garrigues
@ 2026-06-19 10:25 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2026-06-19 10:25 UTC (permalink / raw)
To: Alonso Garrigues; +Cc: gregkh, straube.linux, linux-staging, linux-kernel
On Fri, Jun 19, 2026 at 11:13:00AM +0100, Alonso Garrigues wrote:
> Comparing boolean return value to true with == is redundant.
> Remove the explicit comparison and the extra parentheses.
>
> Signed-off-by: Alonso Garrigues <agarrigues@riseup.net>
> ---
Someone already did this. Please work against staging-next or
linux-next.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-19 10:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-19 10:13 [PATCH] staging: rtl8723bs: remove redundant condition in wlanhdr_to_ethhdr Alonso Garrigues
2026-06-19 10:25 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox