* [PATCH v2] staging: rtl8723bs: remove unnecessary braces in rtw_wlan_util
@ 2026-06-29 13:26 Ruziev Miraly
2026-06-29 14:05 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Ruziev Miraly @ 2026-06-29 13:26 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging
Remove unnecessary braces from a single statement block in rtw_wlan_util.c
to conform to the kernel coding style.
Changes in v2:
- Drop changes to rtw_xmit.c because the removed NULL check was actually a
false positive by checkpatch.pl, and removing the if-block broke the mandatory
goto logic. Focus only on rtw_wlan_util.c now.
Signed-off-by: Ruziev Miraly <miraly.dev@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
index 1d37c2d5b..cc05decd4 100644
--- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
+++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c
@@ -256,9 +256,8 @@ inline void rtw_set_oper_ch(struct adapter *adapter, u8 ch)
{
struct dvobj_priv *dvobj = adapter_to_dvobj(adapter);
- if (dvobj->oper_channel != ch) {
+ if (dvobj->oper_channel != ch)
dvobj->on_oper_ch_time = jiffies;
- }
dvobj->oper_channel = ch;
}
--
2.54.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] staging: rtl8723bs: remove unnecessary braces in rtw_wlan_util
2026-06-29 13:26 [PATCH v2] staging: rtl8723bs: remove unnecessary braces in rtw_wlan_util Ruziev Miraly
@ 2026-06-29 14:05 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2026-06-29 14:05 UTC (permalink / raw)
To: Ruziev Miraly; +Cc: gregkh, linux-staging
On Mon, Jun 29, 2026 at 06:26:29PM +0500, Ruziev Miraly wrote:
> Remove unnecessary braces from a single statement block in rtw_wlan_util.c
> to conform to the kernel coding style.
>
> Changes in v2:
> - Drop changes to rtw_xmit.c because the removed NULL check was actually a
> false positive by checkpatch.pl, and removing the if-block broke the mandatory
> goto logic. Focus only on rtw_wlan_util.c now.
>
> Signed-off-by: Ruziev Miraly <miraly.dev@gmail.com>
> ---
There is a specific format for a v2.
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
Please wait a day between resends otherwise it's overwhelming to
reviewers.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-06-29 14:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-29 13:26 [PATCH v2] staging: rtl8723bs: remove unnecessary braces in rtw_wlan_util Ruziev Miraly
2026-06-29 14:05 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox