From: Julia Lawall <julia.lawall@inria.fr>
To: Karolina Drobnik <karolinadrobnik@gmail.com>
Cc: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org,
forest@alittletooquiet.net, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [Outreachy kernel] [PATCH 4/7] staging: vt6655: Introduce `data` temporary variable
Date: Thu, 28 Oct 2021 16:40:35 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2110281639360.9518@hadrien> (raw)
In-Reply-To: <186358f460f2093dc8a60a8120be3dc6f830c81f.camel@gmail.com>
> On Thu, 2021-10-28 at 13:32 +0200, Julia Lawall wrote:
> > Would it be better as data[i] ?
> >
> > Could there be a better name than "data"? Perhaps "table"?
>
> Hmm, now when I'm thinking about, it indeed looks like a better option.
> I would even say that `data` (or `table`/`init_table`) can be only used
> in the AL7320 case and we can go with `al2230_init_table` for AL2230.
> The line would be 61 characters long, way below the limit.
>
> What do you think?
That would amount to dropping patch 4? That seems fine. It is better to
avoid creating aliases.
julia
next prev parent reply other threads:[~2021-10-28 14:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 10:35 [PATCH 0/7] staging: vt6655: Fix line wrapping in `RFvWriteWakeProgSyn` Karolina Drobnik
2021-10-28 10:35 ` [PATCH 1/7] staging: vt6655: Introduce `idx` temporary variable Karolina Drobnik
2021-10-29 14:47 ` [Outreachy kernel] " Praveen Kumar
2021-11-04 12:05 ` Dan Carpenter
2021-10-28 10:35 ` [PATCH 2/7] staging: vt6655: Use incrementation in `idx` Karolina Drobnik
2021-10-29 14:56 ` [Outreachy kernel] " Praveen Kumar
2021-10-29 15:41 ` Praveen Kumar
2021-11-01 9:47 ` Karolina Drobnik
2021-10-28 10:35 ` [PATCH 3/7] staging: vt6655: Remove unused `i` increments Karolina Drobnik
2021-10-28 10:35 ` [PATCH 4/7] staging: vt6655: Introduce `data` temporary variable Karolina Drobnik
2021-10-28 11:21 ` [Outreachy kernel] " Fabio M. De Francesco
2021-10-28 11:32 ` Julia Lawall
2021-10-28 11:48 ` Fabio M. De Francesco
2021-10-28 14:31 ` Karolina Drobnik
2021-10-28 14:40 ` Julia Lawall [this message]
2021-10-28 10:35 ` [PATCH 5/7] staging: vt6655: Rewrite conditional in AL7320 initialization Karolina Drobnik
2021-10-28 12:36 ` [Outreachy kernel] " Fabio M. De Francesco
2021-10-28 13:06 ` Julia Lawall
2021-10-28 14:35 ` Karolina Drobnik
2021-10-28 15:36 ` Fabio M. De Francesco
2021-10-28 10:35 ` [PATCH 6/7] staging: vt6655: Rename `RFvWriteWakeProgSyn` function Karolina Drobnik
2021-10-28 10:35 ` [PATCH 7/7] staging: vt6655: Update comment for `rf_write_wake_prog_syn` Karolina Drobnik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2110281639360.9518@hadrien \
--to=julia.lawall@inria.fr \
--cc=fmdefrancesco@gmail.com \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=karolinadrobnik@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox