* [PATCH v4] staging: vt6655: Remove unused function
@ 2024-03-16 16:08 Dorine Tipo
2024-03-16 16:48 ` Julia Lawall
0 siblings, 1 reply; 2+ messages in thread
From: Dorine Tipo @ 2024-03-16 16:08 UTC (permalink / raw)
To: forest, gregkh, linux-staging, outreachy
Cc: Dorine Tipo, dan.carpenter, philipp.g.hortmann, julia.lawall
Remove unused function RFbAL7230SelectChannelPostProcess declared in
rf.h but has no associated implementation.
Commit dd2837bdea0e removed the RFbAL7230SelectChannelPostProcess() but
accidentally forgot to delete the declaration in the header file.
Fixes: dd2837bdea0e ("staging: vt6655: Remove unused byRFType in rf.c"
Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
---
Changes since V1:
V2: - Removed the unintended blank line after removing the dead code
- Removed "in rf.h" from the subject
V3: - Added in the Description Comment about unintended blank line
V4: - Adjusted complete description according to hint from feedback
- Rebased patch
drivers/staging/vt6655/rf.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/vt6655/rf.h b/drivers/staging/vt6655/rf.h
index 6f842ac00526..8eef100c7ef2 100644
--- a/drivers/staging/vt6655/rf.h
+++ b/drivers/staging/vt6655/rf.h
@@ -68,8 +68,4 @@ bool RFbRawSetPower(struct vnt_private *priv, unsigned char byPwr,
void RFvRSSITodBm(struct vnt_private *priv, unsigned char byCurrRSSI,
long *pldBm);
-/* {{ RobertYu: 20050104 */
-bool RFbAL7230SelectChannelPostProcess(struct vnt_private *priv, u16 byOldChannel, u16 byNewChannel);
-/* }} RobertYu */
-
#endif /* __RF_H__ */
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v4] staging: vt6655: Remove unused function
2024-03-16 16:08 [PATCH v4] staging: vt6655: Remove unused function Dorine Tipo
@ 2024-03-16 16:48 ` Julia Lawall
0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2024-03-16 16:48 UTC (permalink / raw)
To: Dorine Tipo
Cc: forest, gregkh, linux-staging, outreachy, dan.carpenter,
philipp.g.hortmann, julia.lawall
On Sat, 16 Mar 2024, Dorine Tipo wrote:
> Remove unused function RFbAL7230SelectChannelPostProcess declared in
> rf.h but has no associated implementation.
>
> Commit dd2837bdea0e removed the RFbAL7230SelectChannelPostProcess() but
> accidentally forgot to delete the declaration in the header file.
>
> Fixes: dd2837bdea0e ("staging: vt6655: Remove unused byRFType in rf.c"
Missing right parenthesis.
julia
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> ---
> Changes since V1:
>
> V2: - Removed the unintended blank line after removing the dead code
> - Removed "in rf.h" from the subject
>
> V3: - Added in the Description Comment about unintended blank line
>
> V4: - Adjusted complete description according to hint from feedback
> - Rebased patch
>
> drivers/staging/vt6655/rf.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/staging/vt6655/rf.h b/drivers/staging/vt6655/rf.h
> index 6f842ac00526..8eef100c7ef2 100644
> --- a/drivers/staging/vt6655/rf.h
> +++ b/drivers/staging/vt6655/rf.h
> @@ -68,8 +68,4 @@ bool RFbRawSetPower(struct vnt_private *priv, unsigned char byPwr,
> void RFvRSSITodBm(struct vnt_private *priv, unsigned char byCurrRSSI,
> long *pldBm);
>
> -/* {{ RobertYu: 20050104 */
> -bool RFbAL7230SelectChannelPostProcess(struct vnt_private *priv, u16 byOldChannel, u16 byNewChannel);
> -/* }} RobertYu */
> -
> #endif /* __RF_H__ */
> --
> 2.25.1
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-16 16:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-16 16:08 [PATCH v4] staging: vt6655: Remove unused function Dorine Tipo
2024-03-16 16:48 ` Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox