[PATCH v7] staging: vt6655: Remove unused declaration of

[PATCH v7] staging: vt6655: Remove unused declaration of

[Dorine Tipo]

Remove unused function RFbAL7230SelectChannelPostProcess declared in
rf.h but has no associated implementation.

Commit dd2837bdea0e removed the RFbAL7230SelectChannelPostProcess() but
accidentally forgot to delete the declaration in the header file.

Fixes: dd2837bdea0e ("staging: vt6655: Remove unused byRFType in rf.c")
Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
---
Changes since V1:

V2: - Removed the unintended blank line after removing the dead code
    - Removed "in rf.h" from the subject

V3: - Added in the Description Comment about unintended blank line

V4: - Adjusted complete description according to hint from feedback
    - Rebased patch
V5: - Added a missing closing parenthesis in the fixes tag

V6: - Sent the wrong patch for v5. This version includes the fix in v5

V7: - Made the subjectline more uniques as suggested by
      fabio.maria.de.francesco@linux.intel.com

 drivers/staging/vt6655/rf.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/staging/vt6655/rf.h b/drivers/staging/vt6655/rf.h
index 6f842ac00526..8eef100c7ef2 100644
--- a/drivers/staging/vt6655/rf.h
+++ b/drivers/staging/vt6655/rf.h
@@ -68,8 +68,4 @@ bool RFbRawSetPower(struct vnt_private *priv, unsigned char byPwr,
 void RFvRSSITodBm(struct vnt_private *priv, unsigned char byCurrRSSI,
 		  long *pldBm);

-/* {{ RobertYu: 20050104 */
-bool RFbAL7230SelectChannelPostProcess(struct vnt_private *priv, u16 byOldChannel, u16 byNewChannel);
-/* }} RobertYu */
-
 #endif /* __RF_H__ */
--
2.25.1

Re: [PATCH v7] staging: vt6655: Remove unused declaration of

[Julia Lawall]

On Sat, 16 Mar 2024, Dorine Tipo wrote:

> Remove unused function RFbAL7230SelectChannelPostProcess declared in
> rf.h but has no associated implementation.
>
> Commit dd2837bdea0e removed the RFbAL7230SelectChannelPostProcess() but
> accidentally forgot to delete the declaration in the header file.
>
> Fixes: dd2837bdea0e ("staging: vt6655: Remove unused byRFType in rf.c")
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> ---
> Changes since V1:
>
> V2: - Removed the unintended blank line after removing the dead code
>     - Removed "in rf.h" from the subject
>
> V3: - Added in the Description Comment about unintended blank line
>
> V4: - Adjusted complete description according to hint from feedback
>     - Rebased patch
> V5: - Added a missing closing parenthesis in the fixes tag
>
> V6: - Sent the wrong patch for v5. This version includes the fix in v5
>
> V7: - Made the subjectline more uniques as suggested by
>       fabio.maria.de.francesco@linux.intel.com

Actually, this doesn't seem to have worked.  The name of the function is
not included.

julia

>
>  drivers/staging/vt6655/rf.h | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/staging/vt6655/rf.h b/drivers/staging/vt6655/rf.h
> index 6f842ac00526..8eef100c7ef2 100644
> --- a/drivers/staging/vt6655/rf.h
> +++ b/drivers/staging/vt6655/rf.h
> @@ -68,8 +68,4 @@ bool RFbRawSetPower(struct vnt_private *priv, unsigned char byPwr,
>  void RFvRSSITodBm(struct vnt_private *priv, unsigned char byCurrRSSI,
>  		  long *pldBm);
>
> -/* {{ RobertYu: 20050104 */
> -bool RFbAL7230SelectChannelPostProcess(struct vnt_private *priv, u16 byOldChannel, u16 byNewChannel);
> -/* }} RobertYu */
> -
>  #endif /* __RF_H__ */
> --
> 2.25.1
>
>