From: Dan Carpenter <error27@gmail.com>
To: Noah Techoueyres <noahtechoueyres@gmail.com>
Cc: pure.logic@nexus-software.ie, johan@kernel.org, elder@kernel.org,
gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: greybus: loopback: Add comment for mutex definition
Date: Sat, 8 Aug 2026 10:27:09 +0300 [thread overview]
Message-ID: <anbaTWYlNVYvOU6x@stanley.mountain> (raw)
In-Reply-To: <20260803020609.693-1-noahtechoueyres@gmail.com>
On Sun, Aug 02, 2026 at 10:06:09PM -0400, Noah Techoueyres wrote:
> Add a comment to the mutex field explaining what it protects,
> as required by kernel coding style for lock definitions.
>
> Signed-off-by: Noah Techoueyres <noahtechoueyres@gmail.com>
> ---
> drivers/staging/greybus/loopback.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
> index c33b8aa5871c..f94077a9d64b 100644
> --- a/drivers/staging/greybus/loopback.c
> +++ b/drivers/staging/greybus/loopback.c
> @@ -61,7 +61,7 @@ struct gb_loopback {
>
> struct dentry *file;
> struct kfifo kfifo_lat;
> - struct mutex mutex;
> + struct mutex mutex; /* Protects sysfs attributes */
This comment is wrong.
regards,
dan carpenter
> struct task_struct *task;
> struct device *dev;
> wait_queue_head_t wq;
> --
> 2.43.0
>
prev parent reply other threads:[~2026-08-08 7:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 2:06 [PATCH] staging: greybus: loopback: Add comment for mutex definition Noah Techoueyres
2026-08-08 7:27 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anbaTWYlNVYvOU6x@stanley.mountain \
--to=error27@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=noahtechoueyres@gmail.com \
--cc=pure.logic@nexus-software.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox