* [PATCH] staging: greybus: loopback: Add comment for mutex definition
@ 2026-08-03 2:06 Noah Techoueyres
2026-08-08 7:27 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Noah Techoueyres @ 2026-08-03 2:06 UTC (permalink / raw)
To: pure.logic, johan, elder, gregkh
Cc: greybus-dev, linux-staging, Noah Techoueyres
Add a comment to the mutex field explaining what it protects,
as required by kernel coding style for lock definitions.
Signed-off-by: Noah Techoueyres <noahtechoueyres@gmail.com>
---
drivers/staging/greybus/loopback.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
index c33b8aa5871c..f94077a9d64b 100644
--- a/drivers/staging/greybus/loopback.c
+++ b/drivers/staging/greybus/loopback.c
@@ -61,7 +61,7 @@ struct gb_loopback {
struct dentry *file;
struct kfifo kfifo_lat;
- struct mutex mutex;
+ struct mutex mutex; /* Protects sysfs attributes */
struct task_struct *task;
struct device *dev;
wait_queue_head_t wq;
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: greybus: loopback: Add comment for mutex definition
2026-08-03 2:06 [PATCH] staging: greybus: loopback: Add comment for mutex definition Noah Techoueyres
@ 2026-08-08 7:27 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2026-08-08 7:27 UTC (permalink / raw)
To: Noah Techoueyres
Cc: pure.logic, johan, elder, gregkh, greybus-dev, linux-staging
On Sun, Aug 02, 2026 at 10:06:09PM -0400, Noah Techoueyres wrote:
> Add a comment to the mutex field explaining what it protects,
> as required by kernel coding style for lock definitions.
>
> Signed-off-by: Noah Techoueyres <noahtechoueyres@gmail.com>
> ---
> drivers/staging/greybus/loopback.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
> index c33b8aa5871c..f94077a9d64b 100644
> --- a/drivers/staging/greybus/loopback.c
> +++ b/drivers/staging/greybus/loopback.c
> @@ -61,7 +61,7 @@ struct gb_loopback {
>
> struct dentry *file;
> struct kfifo kfifo_lat;
> - struct mutex mutex;
> + struct mutex mutex; /* Protects sysfs attributes */
This comment is wrong.
regards,
dan carpenter
> struct task_struct *task;
> struct device *dev;
> wait_queue_head_t wq;
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-08 7:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-03 2:06 [PATCH] staging: greybus: loopback: Add comment for mutex definition Noah Techoueyres
2026-08-08 7:27 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox