From: Dan Carpenter <error27@gmail.com>
To: Noah Techoueyres <noahtechoueyres@gmail.com>
Cc: dtwlin@gmail.com, johan@kernel.org, elder@kernel.org,
gregkh@linuxfoundation.org, greybus-dev@lists.linaro.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: greybus: uart: Add comments for lock definitions
Date: Sat, 8 Aug 2026 10:37:13 +0300 [thread overview]
Message-ID: <anbcqQxPM8CP14HN@stanley.mountain> (raw)
In-Reply-To: <20260803021857.989-1-noahtechoueyres@gmail.com>
On Sun, Aug 02, 2026 at 10:18:57PM -0400, Noah Techoueyres wrote:
> Add comments to spinlock and mutex fields explaining what they
> protect, as required by kernel coding style for lock definitions.
>
> Signed-off-by: Noah Techoueyres <noahtechoueyres@gmail.com>
> ---
To be honest, I don't love this checkpatch warning. It seems like
a really easy task but it's actually difficult so it tricks people
into sending patches that they shouldn't.
We really want a proper analysis of the locking and not a three word
guess. What I *really* want is for people to check for bugs as they are
doing this analysis. If you can't find the bugs then this task is too
difficult at this stage.
regards,
dan carpenter
prev parent reply other threads:[~2026-08-08 7:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 2:18 [PATCH] staging: greybus: uart: Add comments for lock definitions Noah Techoueyres
2026-08-08 7:37 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anbcqQxPM8CP14HN@stanley.mountain \
--to=error27@gmail.com \
--cc=dtwlin@gmail.com \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=noahtechoueyres@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox