[PATCH] staging: rtl8723bs: fix lines over 100 characters in hal_intf.c

[PATCH] staging: rtl8723bs: fix lines over 100 characters in hal_intf.c

[Thomas Prud'homme]

Wrap the parameter list of rtw_hal_set_odm_var() across two lines,
and move the comment on the rtl8723b_HalDmWatchDog_in_LPS() call
above the call instead of trailing it, so both lines fit within the
checkpatch.pl line length limit. No functional change.

Signed-off-by: Thomas Prud'homme <t+linux@prudhomme.li>
---
 drivers/staging/rtl8723bs/hal/hal_intf.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl8723bs/hal/hal_intf.c
index 2caade1a8..1096f5441 100644
--- a/drivers/staging/rtl8723bs/hal/hal_intf.c
+++ b/drivers/staging/rtl8723bs/hal/hal_intf.c
@@ -89,7 +89,8 @@ u8 rtw_hal_get_def_var(struct adapter *padapter, enum hal_def_variable eVariable
 	return GetHalDefVar8723BSDIO(padapter, eVariable, pValue);
 }
 
-void rtw_hal_set_odm_var(struct adapter *padapter, enum hal_odm_variable eVariable, void *pValue1, bool bSet)
+void rtw_hal_set_odm_var(struct adapter *padapter,
+			 enum hal_odm_variable eVariable, void *pValue1, bool bSet)
 {
 	SetHalODMVar(padapter, eVariable, pValue1, bSet);
 }
@@ -216,7 +217,8 @@ void rtw_hal_dm_watchdog(struct adapter *padapter)
 void rtw_hal_dm_watchdog_in_lps(struct adapter *padapter)
 {
 	if (adapter_to_pwrctl(padapter)->fw_current_in_ps_mode)
-		rtl8723b_HalDmWatchDog_in_LPS(padapter); /* this function caller is in interrupt context */
+		/* this function caller is in interrupt context */
+		rtl8723b_HalDmWatchDog_in_LPS(padapter);
 }
 
 void beacon_timing_control(struct adapter *padapter)
-- 
2.55.0.windows.3

Re: [PATCH] staging: rtl8723bs: fix lines over 100 characters in hal_intf.c

[Greg Kroah-Hartman]

On Wed, Sep 09, 2026 at 07:41:52PM +0200, Thomas Prud'homme wrote:
> Wrap the parameter list of rtw_hal_set_odm_var() across two lines,
> and move the comment on the rtl8723b_HalDmWatchDog_in_LPS() call
> above the call instead of trailing it, so both lines fit within the
> checkpatch.pl line length limit. No functional change.
> 
> Signed-off-by: Thomas Prud'homme <t+linux@prudhomme.li>
> ---
>  drivers/staging/rtl8723bs/hal/hal_intf.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl8723bs/hal/hal_intf.c
> index 2caade1a8..1096f5441 100644
> --- a/drivers/staging/rtl8723bs/hal/hal_intf.c
> +++ b/drivers/staging/rtl8723bs/hal/hal_intf.c
> @@ -89,7 +89,8 @@ u8 rtw_hal_get_def_var(struct adapter *padapter, enum hal_def_variable eVariable
>  	return GetHalDefVar8723BSDIO(padapter, eVariable, pValue);
>  }
>  
> -void rtw_hal_set_odm_var(struct adapter *padapter, enum hal_odm_variable eVariable, void *pValue1, bool bSet)
> +void rtw_hal_set_odm_var(struct adapter *padapter,
> +			 enum hal_odm_variable eVariable, void *pValue1, bool bSet)
>  {
>  	SetHalODMVar(padapter, eVariable, pValue1, bSet);
>  }
> @@ -216,7 +217,8 @@ void rtw_hal_dm_watchdog(struct adapter *padapter)
>  void rtw_hal_dm_watchdog_in_lps(struct adapter *padapter)
>  {
>  	if (adapter_to_pwrctl(padapter)->fw_current_in_ps_mode)
> -		rtl8723b_HalDmWatchDog_in_LPS(padapter); /* this function caller is in interrupt context */
> +		/* this function caller is in interrupt context */
> +		rtl8723b_HalDmWatchDog_in_LPS(padapter);

Doesn't this break a different checkpatch issue?

Be careful of multi-line statements like this...

thanks,

greg k-h

Re: [PATCH] staging: rtl8723bs: fix lines over 100 characters in hal_intf.c

[Dan Carpenter]

On Thu, Oct 01, 2026 at 07:41:13AM +0200, Greg Kroah-Hartman wrote:
> On Wed, Sep 09, 2026 at 07:41:52PM +0200, Thomas Prud'homme wrote:
> > Wrap the parameter list of rtw_hal_set_odm_var() across two lines,
> > and move the comment on the rtl8723b_HalDmWatchDog_in_LPS() call
> > above the call instead of trailing it, so both lines fit within the
> > checkpatch.pl line length limit. No functional change.
> > 
> > Signed-off-by: Thomas Prud'homme <t+linux@prudhomme.li>
> > ---
> >  drivers/staging/rtl8723bs/hal/hal_intf.c | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl8723bs/hal/hal_intf.c
> > index 2caade1a8..1096f5441 100644
> > --- a/drivers/staging/rtl8723bs/hal/hal_intf.c
> > +++ b/drivers/staging/rtl8723bs/hal/hal_intf.c
> > @@ -89,7 +89,8 @@ u8 rtw_hal_get_def_var(struct adapter *padapter, enum hal_def_variable eVariable
> >  	return GetHalDefVar8723BSDIO(padapter, eVariable, pValue);
> >  }
> >  
> > -void rtw_hal_set_odm_var(struct adapter *padapter, enum hal_odm_variable eVariable, void *pValue1, bool bSet)
> > +void rtw_hal_set_odm_var(struct adapter *padapter,
> > +			 enum hal_odm_variable eVariable, void *pValue1, bool bSet)
> >  {
> >  	SetHalODMVar(padapter, eVariable, pValue1, bSet);
> >  }
> > @@ -216,7 +217,8 @@ void rtw_hal_dm_watchdog(struct adapter *padapter)
> >  void rtw_hal_dm_watchdog_in_lps(struct adapter *padapter)
> >  {
> >  	if (adapter_to_pwrctl(padapter)->fw_current_in_ps_mode)
> > -		rtl8723b_HalDmWatchDog_in_LPS(padapter); /* this function caller is in interrupt context */
> > +		/* this function caller is in interrupt context */
> > +		rtl8723b_HalDmWatchDog_in_LPS(padapter);
> 
> Doesn't this break a different checkpatch issue?
> 

No, it doesn't.  But, of course, yes, multi-line if statements should
get curly braces.  It's an unwritten rule.

Also I feel like loop macros should get curly braces as well but that
might just be me...

regards,
dan carpenter