* [PATCH] staging: iio: addac: adt7316: clean up and sort headers
@ 2026-10-28 9:43 Abdelnasser Hussein
2026-10-28 13:50 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Abdelnasser Hussein @ 2026-10-28 9:43 UTC (permalink / raw)
To: Jonathan Cameron, Greg Kroah-Hartman, Nuno Sa, Michael Hennerich
Cc: David Lechner, Andy Shevchenko, linux-iio, linux-staging, linux,
linux-kernel, Abdelnasser Hussein
Remove unused header files and
add linux/pm.h and linux/string.h and
sort the remaining include directives alphabetically.
Signed-off-by: Abdelnasser Hussein <abdelnasserhussein11@gmail.com>
---
drivers/staging/iio/addac/adt7316.c | 16 +++++++---------
1 file changed, 7 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
index 20f6052cc7fb..e30d978fea56 100644
--- a/drivers/staging/iio/addac/adt7316.c
+++ b/drivers/staging/iio/addac/adt7316.c
@@ -5,22 +5,20 @@
* Copyright 2010 Analog Devices Inc.
*/
-#include <linux/interrupt.h>
+#include <linux/device.h>
#include <linux/gpio/consumer.h>
+#include <linux/interrupt.h>
#include <linux/irq.h>
-#include <linux/workqueue.h>
-#include <linux/device.h>
#include <linux/kernel.h>
-#include <linux/slab.h>
-#include <linux/sysfs.h>
-#include <linux/list.h>
-#include <linux/i2c.h>
-#include <linux/rtc.h>
#include <linux/module.h>
+#include <linux/pm.h>
+#include <linux/string.h>
+#include <linux/sysfs.h>
-#include <linux/iio/iio.h>
#include <linux/iio/events.h>
+#include <linux/iio/iio.h>
#include <linux/iio/sysfs.h>
+
#include "adt7316.h"
/*
--
2.56.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: iio: addac: adt7316: clean up and sort headers
2026-10-28 9:43 [PATCH] staging: iio: addac: adt7316: clean up and sort headers Abdelnasser Hussein
@ 2026-10-28 13:50 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2026-10-28 13:50 UTC (permalink / raw)
To: Abdelnasser Hussein
Cc: Jonathan Cameron, Greg Kroah-Hartman, Nuno Sa, Michael Hennerich,
David Lechner, Andy Shevchenko, linux-iio, linux-staging, linux,
linux-kernel
On Wed, Oct 28, 2026 at 12:43:07PM +0300, Abdelnasser Hussein wrote:
> Remove unused header files and
> add linux/pm.h and linux/string.h and
This should be a separate patch, it also needs to get rid of "proxy" headers,
such as kernel.h. (The use of device.h needs to be revisited,)
> sort the remaining include directives alphabetically.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-28 13:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-28 9:43 [PATCH] staging: iio: addac: adt7316: clean up and sort headers Abdelnasser Hussein
2026-10-28 13:50 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox