From: Dan Carpenter <error27@gmail.com>
To: Shivani Patel <patelshivani2283@gmail.com>
Cc: outreachy@lists.linux.dev, vaibhav.sr@gmail.com,
mgreer@animalcreek.com, johan@kernel.org,
gregkh@linuxfoundation.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: greybus: audio_manager_module: Add newline to sysfs output
Date: Mon, 9 Nov 2026 10:56:33 +0300 [thread overview]
Message-ID: <avF8sf_Auo0z-_93@stanley.mountain> (raw)
In-Reply-To: <20261109075242.62681-1-patelshivani2283@gmail.com>
On Mon, Nov 09, 2026 at 01:22:42PM +0530, Shivani Patel wrote:
> The sysfs_emit() calls in the show functions for audio manager module
> attributes were missing terminating newlines. Add them to conform to
> the kernel coding style requirement that sysfs output ends with a
> newline character.
>
> Signed-off-by: Shivani Patel <patelshivani2283@gmail.com>
> ---
No. See the archives (lore.kernel.org) for why.
regards,
dan carpenter
next prev parent reply other threads:[~2026-11-09 7:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-09 7:52 [PATCH] staging: greybus: audio_manager_module: Add newline to sysfs output Shivani Patel
2026-11-09 7:56 ` Dan Carpenter [this message]
2026-11-09 10:13 ` Julia Lawall
-- strict thread matches above, loose matches on Subject: below --
2026-10-21 23:38 [PATCH] staging: greybus: audio_manager_module: add " Temitope obabi
2026-10-22 4:39 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avF8sf_Auo0z-_93@stanley.mountain \
--to=error27@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mgreer@animalcreek.com \
--cc=outreachy@lists.linux.dev \
--cc=patelshivani2283@gmail.com \
--cc=vaibhav.sr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox