* [PATCH] staging: greybus: audio_manager_module: add newline to sysfs output
@ 2026-10-21 23:38 Temitope obabi
2026-10-22 4:39 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Temitope obabi @ 2026-10-21 23:38 UTC (permalink / raw)
To: Vaibhav Agarwal, Mark Greer, Johan Hovold, Alex Elder,
Greg Kroah-Hartman, greybus-dev, linux-staging, linux-kernel
Cc: Temitope obabi
sysfs attribute output is expected to end with a newline. The show
functions in this file return values without a trailing newline,
which checkpatch reports as a warning.
Add the missing "\n" to the sysfs_emit() format strings of the
name, vid, pid, intf_id, ip_devices and op_devices attributes.
Compile-tested only.
Signed-off-by: Temitope obabi <obabitemitope765@gmail.com>
---
drivers/staging/greybus/audio_manager_module.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/staging/greybus/audio_manager_module.c
index dc90cc2d2308..5737f2a32f5a 100644
--- a/drivers/staging/greybus/audio_manager_module.c
+++ b/drivers/staging/greybus/audio_manager_module.c
@@ -75,7 +75,7 @@ static void gb_audio_module_release(struct kobject *kobj)
static ssize_t gb_audio_module_name_show(struct gb_audio_manager_module *module,
struct gb_audio_manager_module_attribute *attr, char *buf)
{
- return sysfs_emit(buf, "%s", module->desc.name);
+ return sysfs_emit(buf, "%s\n", module->desc.name);
}
static struct gb_audio_manager_module_attribute gb_audio_module_name_attribute =
@@ -84,7 +84,7 @@ static struct gb_audio_manager_module_attribute gb_audio_module_name_attribute =
static ssize_t gb_audio_module_vid_show(struct gb_audio_manager_module *module,
struct gb_audio_manager_module_attribute *attr, char *buf)
{
- return sysfs_emit(buf, "%d", module->desc.vid);
+ return sysfs_emit(buf, "%d\n", module->desc.vid);
}
static struct gb_audio_manager_module_attribute gb_audio_module_vid_attribute =
@@ -93,7 +93,7 @@ static struct gb_audio_manager_module_attribute gb_audio_module_vid_attribute =
static ssize_t gb_audio_module_pid_show(struct gb_audio_manager_module *module,
struct gb_audio_manager_module_attribute *attr, char *buf)
{
- return sysfs_emit(buf, "%d", module->desc.pid);
+ return sysfs_emit(buf, "%d\n", module->desc.pid);
}
static struct gb_audio_manager_module_attribute gb_audio_module_pid_attribute =
@@ -103,7 +103,7 @@ static ssize_t gb_audio_module_intf_id_show(struct gb_audio_manager_module *modu
struct gb_audio_manager_module_attribute *attr,
char *buf)
{
- return sysfs_emit(buf, "%d", module->desc.intf_id);
+ return sysfs_emit(buf, "%d\n", module->desc.intf_id);
}
static struct gb_audio_manager_module_attribute
@@ -114,7 +114,7 @@ static ssize_t gb_audio_module_ip_devices_show(struct gb_audio_manager_module *m
struct gb_audio_manager_module_attribute *attr,
char *buf)
{
- return sysfs_emit(buf, "0x%X", module->desc.ip_devices);
+ return sysfs_emit(buf, "0x%X\n", module->desc.ip_devices);
}
static struct gb_audio_manager_module_attribute
@@ -125,7 +125,7 @@ static ssize_t gb_audio_module_op_devices_show(struct gb_audio_manager_module *m
struct gb_audio_manager_module_attribute *attr,
char *buf)
{
- return sysfs_emit(buf, "0x%X", module->desc.op_devices);
+ return sysfs_emit(buf, "0x%X\n", module->desc.op_devices);
}
static struct gb_audio_manager_module_attribute
--
2.53.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: greybus: audio_manager_module: add newline to sysfs output
2026-10-21 23:38 [PATCH] staging: greybus: audio_manager_module: add " Temitope obabi
@ 2026-10-22 4:39 ` Greg Kroah-Hartman
0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2026-10-22 4:39 UTC (permalink / raw)
To: Temitope obabi
Cc: Vaibhav Agarwal, Mark Greer, Johan Hovold, Alex Elder,
greybus-dev, linux-staging, linux-kernel
On Thu, Oct 22, 2026 at 02:38:42AM +0300, Temitope obabi wrote:
> sysfs attribute output is expected to end with a newline. The show
> functions in this file return values without a trailing newline,
> which checkpatch reports as a warning.
>
> Add the missing "\n" to the sysfs_emit() format strings of the
> name, vid, pid, intf_id, ip_devices and op_devices attributes.
>
> Compile-tested only.
>
> Signed-off-by: Temitope obabi <obabitemitope765@gmail.com>
> ---
> drivers/staging/greybus/audio_manager_module.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Please read the archives for why this keeps getting rejected.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] staging: greybus: audio_manager_module: Add newline to sysfs output
@ 2026-11-09 7:52 Shivani Patel
2026-11-09 7:56 ` Dan Carpenter
2026-11-09 10:13 ` Julia Lawall
0 siblings, 2 replies; 5+ messages in thread
From: Shivani Patel @ 2026-11-09 7:52 UTC (permalink / raw)
To: outreachy; +Cc: vaibhav.sr, mgreer, johan, gregkh, linux-staging, Shivani Patel
The sysfs_emit() calls in the show functions for audio manager module
attributes were missing terminating newlines. Add them to conform to
the kernel coding style requirement that sysfs output ends with a
newline character.
Signed-off-by: Shivani Patel <patelshivani2283@gmail.com>
---
drivers/staging/greybus/audio_manager_module.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/staging/greybus/audio_manager_module.c
index dc90cc2d2..5737f2a32 100644
--- a/drivers/staging/greybus/audio_manager_module.c
+++ b/drivers/staging/greybus/audio_manager_module.c
@@ -75,7 +75,7 @@ static void gb_audio_module_release(struct kobject *kobj)
static ssize_t gb_audio_module_name_show(struct gb_audio_manager_module *module,
struct gb_audio_manager_module_attribute *attr, char *buf)
{
- return sysfs_emit(buf, "%s", module->desc.name);
+ return sysfs_emit(buf, "%s\n", module->desc.name);
}
static struct gb_audio_manager_module_attribute gb_audio_module_name_attribute =
@@ -84,7 +84,7 @@ static struct gb_audio_manager_module_attribute gb_audio_module_name_attribute =
static ssize_t gb_audio_module_vid_show(struct gb_audio_manager_module *module,
struct gb_audio_manager_module_attribute *attr, char *buf)
{
- return sysfs_emit(buf, "%d", module->desc.vid);
+ return sysfs_emit(buf, "%d\n", module->desc.vid);
}
static struct gb_audio_manager_module_attribute gb_audio_module_vid_attribute =
@@ -93,7 +93,7 @@ static struct gb_audio_manager_module_attribute gb_audio_module_vid_attribute =
static ssize_t gb_audio_module_pid_show(struct gb_audio_manager_module *module,
struct gb_audio_manager_module_attribute *attr, char *buf)
{
- return sysfs_emit(buf, "%d", module->desc.pid);
+ return sysfs_emit(buf, "%d\n", module->desc.pid);
}
static struct gb_audio_manager_module_attribute gb_audio_module_pid_attribute =
@@ -103,7 +103,7 @@ static ssize_t gb_audio_module_intf_id_show(struct gb_audio_manager_module *modu
struct gb_audio_manager_module_attribute *attr,
char *buf)
{
- return sysfs_emit(buf, "%d", module->desc.intf_id);
+ return sysfs_emit(buf, "%d\n", module->desc.intf_id);
}
static struct gb_audio_manager_module_attribute
@@ -114,7 +114,7 @@ static ssize_t gb_audio_module_ip_devices_show(struct gb_audio_manager_module *m
struct gb_audio_manager_module_attribute *attr,
char *buf)
{
- return sysfs_emit(buf, "0x%X", module->desc.ip_devices);
+ return sysfs_emit(buf, "0x%X\n", module->desc.ip_devices);
}
static struct gb_audio_manager_module_attribute
@@ -125,7 +125,7 @@ static ssize_t gb_audio_module_op_devices_show(struct gb_audio_manager_module *m
struct gb_audio_manager_module_attribute *attr,
char *buf)
{
- return sysfs_emit(buf, "0x%X", module->desc.op_devices);
+ return sysfs_emit(buf, "0x%X\n", module->desc.op_devices);
}
static struct gb_audio_manager_module_attribute
--
2.50.1 (Apple Git-155)
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: greybus: audio_manager_module: Add newline to sysfs output
2026-11-09 7:52 [PATCH] staging: greybus: audio_manager_module: Add newline to sysfs output Shivani Patel
@ 2026-11-09 7:56 ` Dan Carpenter
2026-11-09 10:13 ` Julia Lawall
1 sibling, 0 replies; 5+ messages in thread
From: Dan Carpenter @ 2026-11-09 7:56 UTC (permalink / raw)
To: Shivani Patel; +Cc: outreachy, vaibhav.sr, mgreer, johan, gregkh, linux-staging
On Mon, Nov 09, 2026 at 01:22:42PM +0530, Shivani Patel wrote:
> The sysfs_emit() calls in the show functions for audio manager module
> attributes were missing terminating newlines. Add them to conform to
> the kernel coding style requirement that sysfs output ends with a
> newline character.
>
> Signed-off-by: Shivani Patel <patelshivani2283@gmail.com>
> ---
No. See the archives (lore.kernel.org) for why.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] staging: greybus: audio_manager_module: Add newline to sysfs output
2026-11-09 7:52 [PATCH] staging: greybus: audio_manager_module: Add newline to sysfs output Shivani Patel
2026-11-09 7:56 ` Dan Carpenter
@ 2026-11-09 10:13 ` Julia Lawall
1 sibling, 0 replies; 5+ messages in thread
From: Julia Lawall @ 2026-11-09 10:13 UTC (permalink / raw)
To: Shivani Patel; +Cc: outreachy, vaibhav.sr, mgreer, johan, gregkh, linux-staging
On Mon, 9 Nov 2026, Shivani Patel wrote:
> The sysfs_emit() calls in the show functions for audio manager module
> attributes were missing terminating newlines. Add them to conform to
> the kernel coding style requirement that sysfs output ends with a
> newline character.
Patches on this issue have already been rejected. Please check the
mailing list archives before sending patches.
julia
>
> Signed-off-by: Shivani Patel <patelshivani2283@gmail.com>
> ---
> drivers/staging/greybus/audio_manager_module.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/greybus/audio_manager_module.c b/drivers/staging/greybus/audio_manager_module.c
> index dc90cc2d2..5737f2a32 100644
> --- a/drivers/staging/greybus/audio_manager_module.c
> +++ b/drivers/staging/greybus/audio_manager_module.c
> @@ -75,7 +75,7 @@ static void gb_audio_module_release(struct kobject *kobj)
> static ssize_t gb_audio_module_name_show(struct gb_audio_manager_module *module,
> struct gb_audio_manager_module_attribute *attr, char *buf)
> {
> - return sysfs_emit(buf, "%s", module->desc.name);
> + return sysfs_emit(buf, "%s\n", module->desc.name);
> }
>
> static struct gb_audio_manager_module_attribute gb_audio_module_name_attribute =
> @@ -84,7 +84,7 @@ static struct gb_audio_manager_module_attribute gb_audio_module_name_attribute =
> static ssize_t gb_audio_module_vid_show(struct gb_audio_manager_module *module,
> struct gb_audio_manager_module_attribute *attr, char *buf)
> {
> - return sysfs_emit(buf, "%d", module->desc.vid);
> + return sysfs_emit(buf, "%d\n", module->desc.vid);
> }
>
> static struct gb_audio_manager_module_attribute gb_audio_module_vid_attribute =
> @@ -93,7 +93,7 @@ static struct gb_audio_manager_module_attribute gb_audio_module_vid_attribute =
> static ssize_t gb_audio_module_pid_show(struct gb_audio_manager_module *module,
> struct gb_audio_manager_module_attribute *attr, char *buf)
> {
> - return sysfs_emit(buf, "%d", module->desc.pid);
> + return sysfs_emit(buf, "%d\n", module->desc.pid);
> }
>
> static struct gb_audio_manager_module_attribute gb_audio_module_pid_attribute =
> @@ -103,7 +103,7 @@ static ssize_t gb_audio_module_intf_id_show(struct gb_audio_manager_module *modu
> struct gb_audio_manager_module_attribute *attr,
> char *buf)
> {
> - return sysfs_emit(buf, "%d", module->desc.intf_id);
> + return sysfs_emit(buf, "%d\n", module->desc.intf_id);
> }
>
> static struct gb_audio_manager_module_attribute
> @@ -114,7 +114,7 @@ static ssize_t gb_audio_module_ip_devices_show(struct gb_audio_manager_module *m
> struct gb_audio_manager_module_attribute *attr,
> char *buf)
> {
> - return sysfs_emit(buf, "0x%X", module->desc.ip_devices);
> + return sysfs_emit(buf, "0x%X\n", module->desc.ip_devices);
> }
>
> static struct gb_audio_manager_module_attribute
> @@ -125,7 +125,7 @@ static ssize_t gb_audio_module_op_devices_show(struct gb_audio_manager_module *m
> struct gb_audio_manager_module_attribute *attr,
> char *buf)
> {
> - return sysfs_emit(buf, "0x%X", module->desc.op_devices);
> + return sysfs_emit(buf, "0x%X\n", module->desc.op_devices);
> }
>
> static struct gb_audio_manager_module_attribute
> --
> 2.50.1 (Apple Git-155)
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-11-09 10:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-09 7:52 [PATCH] staging: greybus: audio_manager_module: Add newline to sysfs output Shivani Patel
2026-11-09 7:56 ` Dan Carpenter
2026-11-09 10:13 ` Julia Lawall
-- strict thread matches above, loose matches on Subject: below --
2026-10-21 23:38 [PATCH] staging: greybus: audio_manager_module: add " Temitope obabi
2026-10-22 4:39 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox