From: Johannes Berg <johannes@sipsolutions.net>
To: Philipp Hortmann <philipp.g.hortmann@gmail.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Geoff Levand <geoff@infradead.org>,
Simon Horman <horms@kernel.org>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Kalle Valo <kvalo@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jeff Johnson <quic_jjohnson@quicinc.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Pavel Machek <pavel@ucw.cz>, Stanislaw Gruszka <stf_xl@wp.pl>,
Gregory Greenman <gregory.greenman@intel.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
linux-staging@lists.linux.dev, linux-wireless@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>,
Stefan Lippers-Hollmann <s.l-h@gmx.de>
Subject: Re: [PATCH] net: ethernet: toshiba: ps3_gelic_wireless: Remove driver using deprecated API wext
Date: Mon, 30 Dec 2024 09:22:28 +0100 [thread overview]
Message-ID: <b811d4af6a634d61389dfefacd49853c0e77f1d7.camel@sipsolutions.net> (raw)
In-Reply-To: <20241224080755.194508-1-philipp.g.hortmann@gmail.com>
On Tue, 2024-12-24 at 09:07 +0100, Philipp Hortmann wrote:
> Driver was contributed in 2008.
>
> The following reasons lead to the removal:
> - This driver generates maintenance workload for itself and for API wext
So I've been wondering, why are you so concerned about this? And in
particular, more concerned about it than the people actually doing the
maintenance? :)
We got here because I removed a *staging* driver that was in the way of
some wext cleanups, but that had a thousand other reasons to never go
anywhere anyway.
> - wext is deprecated and only used by two wireless drivers in
> mainline kernel
true
> - no progress changing to mac80211
It fundamentally cannot be converted to mac80211, it has a whole
different model. In fact it cannot even be converted to cfg80211 because
some APIs it uses just never existed there, and likely never will.
> Tested a rebased version of this patch on the Playstation 3. Used
> T2 Linux with Kernel 6.12.5 to test the Ethernet connection.
>
Arguably that's a pretty strong argument for *not* removing it, if it's
actually relatively simple today to bring up the latest kernel on a PS3.
johannes
next prev parent reply other threads:[~2024-12-30 8:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-24 8:07 [PATCH] net: ethernet: toshiba: ps3_gelic_wireless: Remove driver using deprecated API wext Philipp Hortmann
2024-12-30 8:22 ` Johannes Berg [this message]
2025-01-03 6:44 ` Philipp Hortmann
2025-01-03 8:53 ` Geert Uytterhoeven
2025-01-03 9:14 ` David Woodhouse
2025-01-03 9:25 ` Geert Uytterhoeven
2025-01-03 9:32 ` Johannes Berg
2025-01-03 11:02 ` Philipp Hortmann
2025-01-03 11:16 ` Geert Uytterhoeven
2025-01-03 11:28 ` Philipp Hortmann
2025-01-03 12:44 ` Johannes Berg
2025-01-04 4:15 ` Arnd Bergmann
2025-01-06 8:06 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b811d4af6a634d61389dfefacd49853c0e77f1d7.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Larry.Finger@lwfinger.net \
--cc=aleksander.lobakin@intel.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew+netdev@lunn.ch \
--cc=arnd@arndb.de \
--cc=claudiu.beznea@tuxon.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geert@linux-m68k.org \
--cc=geoff@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.greenman@intel.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
--cc=pavel@ucw.cz \
--cc=philipp.g.hortmann@gmail.com \
--cc=quic_jjohnson@quicinc.com \
--cc=s.l-h@gmx.de \
--cc=stf_xl@wp.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox