* [PATCH] media: staging: starfive: camss: fix off by one in isp_enum_mbus_code()
@ 2023-11-28 14:40 Dan Carpenter
2023-11-29 2:10 ` Changhuang Liang
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2023-11-28 14:40 UTC (permalink / raw)
To: Jack Zhu
Cc: Changhuang Liang, Mauro Carvalho Chehab, Greg Kroah-Hartman,
Hans Verkuil, linux-media, linux-staging, linux-kernel,
kernel-janitors
These > comparisons should be >=. The formats->fmts[] array is either
a pointer to isp_formats_sink[] or isp_formats_source[] respectively.
Fixes: e57854628f58 ("media: staging: media: starfive: camss: Add ISP driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/staging/media/starfive/camss/stf-isp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/starfive/camss/stf-isp.c b/drivers/staging/media/starfive/camss/stf-isp.c
index 893dbd8cddc8..98d61d71c31b 100644
--- a/drivers/staging/media/starfive/camss/stf-isp.c
+++ b/drivers/staging/media/starfive/camss/stf-isp.c
@@ -120,7 +120,7 @@ static int isp_enum_mbus_code(struct v4l2_subdev *sd,
const struct stf_isp_format_table *formats;
if (code->pad == STF_ISP_PAD_SINK) {
- if (code->index > ARRAY_SIZE(isp_formats_sink))
+ if (code->index >= ARRAY_SIZE(isp_formats_sink))
return -EINVAL;
formats = &isp_dev->formats[SINK_FORMATS_INDEX];
@@ -128,7 +128,7 @@ static int isp_enum_mbus_code(struct v4l2_subdev *sd,
} else {
struct v4l2_mbus_framefmt *sink_fmt;
- if (code->index > ARRAY_SIZE(isp_formats_source))
+ if (code->index >= ARRAY_SIZE(isp_formats_source))
return -EINVAL;
sink_fmt = v4l2_subdev_state_get_format(state,
--
2.42.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] media: staging: starfive: camss: fix off by one in isp_enum_mbus_code()
2023-11-28 14:40 [PATCH] media: staging: starfive: camss: fix off by one in isp_enum_mbus_code() Dan Carpenter
@ 2023-11-29 2:10 ` Changhuang Liang
0 siblings, 0 replies; 2+ messages in thread
From: Changhuang Liang @ 2023-11-29 2:10 UTC (permalink / raw)
To: Dan Carpenter, Jack Zhu
Cc: Mauro Carvalho Chehab, Greg Kroah-Hartman, Hans Verkuil,
linux-media, linux-staging, linux-kernel, kernel-janitors
On 2023/11/28 22:40, Dan Carpenter wrote:
> These > comparisons should be >=. The formats->fmts[] array is either
> a pointer to isp_formats_sink[] or isp_formats_source[] respectively.
>
> Fixes: e57854628f58 ("media: staging: media: starfive: camss: Add ISP driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Changhuang Liang <changhuang.liang@starfivetech.com>
> ---
> drivers/staging/media/starfive/camss/stf-isp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/starfive/camss/stf-isp.c b/drivers/staging/media/starfive/camss/stf-isp.c
> index 893dbd8cddc8..98d61d71c31b 100644
> --- a/drivers/staging/media/starfive/camss/stf-isp.c
> +++ b/drivers/staging/media/starfive/camss/stf-isp.c
> @@ -120,7 +120,7 @@ static int isp_enum_mbus_code(struct v4l2_subdev *sd,
> const struct stf_isp_format_table *formats;
>
> if (code->pad == STF_ISP_PAD_SINK) {
> - if (code->index > ARRAY_SIZE(isp_formats_sink))
> + if (code->index >= ARRAY_SIZE(isp_formats_sink))
> return -EINVAL;
>
> formats = &isp_dev->formats[SINK_FORMATS_INDEX];
> @@ -128,7 +128,7 @@ static int isp_enum_mbus_code(struct v4l2_subdev *sd,
> } else {
> struct v4l2_mbus_framefmt *sink_fmt;
>
> - if (code->index > ARRAY_SIZE(isp_formats_source))
> + if (code->index >= ARRAY_SIZE(isp_formats_source))
> return -EINVAL;
>
> sink_fmt = v4l2_subdev_state_get_format(state,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-29 2:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-28 14:40 [PATCH] media: staging: starfive: camss: fix off by one in isp_enum_mbus_code() Dan Carpenter
2023-11-29 2:10 ` Changhuang Liang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox