Re: [PATCH v2 2/2] media: staging: max96712: Add support for MAX96724

[Julien Massot <julien.massot@collabora.com>]

Hi Tommaso,

On 8/27/24 3:55 PM, Tommaso Merciai wrote:
> Hi Niklas,
> Thanks for your work.
> 
> Hi Julien,
> I think we can adopt a similar approach for the max96716 deserializer using your work
> on max96714 driver. What do you think?
> 
> Thanks in advance.


I don't think that supporting MAX96716 and MAX96714 in the same driver 
is the best option

MAX96714 is a very simple device with one input one output one video pipe.

While the MAX96716 is a two inputs/outputs with four different pipes.

IMHO we should have one driver for the 1 port GMSL2 devices, another 
driver for the dual deserializers which will introduce more complex 
routing, and another one for the quad deserializers since the register 
layout is too much different.

But that's only my opinion let's see when we will implement the dual 
deserializer support.

We can of course share some functions for those drivers like GPIO 
handling or pattern generation.

Regards,
Julien