public inbox for linux-staging@lists.linux.dev
 help / color / mirror / Atom feed
From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Dorine Tipo <dorine.a.tipo@gmail.com>,
	gregkh@linuxfoundation.org, forest@alittletooquiet.net,
	linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: vt6655: Match parenthesis alignment
Date: Sun, 3 Mar 2024 20:40:24 +0100	[thread overview]
Message-ID: <e96bee24-dedd-47e3-aafa-82e176ff8aab@gmail.com> (raw)
In-Reply-To: <20240303075936.16296-1-dorine.a.tipo@gmail.com>

On 3/3/24 08:59, Dorine Tipo wrote:
> Correct parameter alignment in bool card_set_beacon_period().
> 
> This patch aligns the beacon_interval parameter with the opening parenthesis.
> This change improves code readability and maintains consistency with coding
> style guidelines.
> 
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> ---
>   drivers/staging/vt6655/card.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
> index 94784b5c0402..3f807d898607 100644
> --- a/drivers/staging/vt6655/card.c
> +++ b/drivers/staging/vt6655/card.c
> @@ -321,7 +321,7 @@ bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,
>    * Return Value: true if succeed; otherwise false
>    */
>   bool card_set_beacon_period(struct vnt_private *priv,
> -			  unsigned short beacon_interval)
> +			    unsigned short beacon_interval)
>   {
>   	u64 next_tbtt;
>   

Hi Dorine,

in addition: Please include a version history on the next series. It 
needs to have a v2 in the subject. Fix the following checkpatch warning 
as well. Did you run checkpatch on your patches?

WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit 
description?)
#9:
This patch aligns the beacon_interval parameter with the opening 
parenthesis.

Thanks for your support.

Bye Philipp

  reply	other threads:[~2024-03-03 19:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-03  7:59 [PATCH] staging: vt6655: Match parenthesis alignment Dorine Tipo
2024-03-03 19:40 ` Philipp Hortmann [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-03-03  7:40 [PATCH] staging: vt6655: Match parentesis alignment Dorine Tipo
2024-03-03  7:46 ` [PATCH] staging: vt6655: Match parenthesis alignment Dorine Tipo
2024-03-03  7:10 Dorine Tipo
2024-03-03  6:56 Dorine Tipo
2024-03-03 19:30 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e96bee24-dedd-47e3-aafa-82e176ff8aab@gmail.com \
    --to=philipp.g.hortmann@gmail.com \
    --cc=dorine.a.tipo@gmail.com \
    --cc=forest@alittletooquiet.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox