[PATCH] staging: vt6655: Match parenthesis alignment

[PATCH] staging: vt6655: Match parenthesis alignment

[Dorine Tipo]

Align parameters in static void calculate_ofdmr_parameter()

This patch aligns the parameters with the opening parenthesis for better
readability and adherence to coding style guidelines.

Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
---
 drivers/staging/vt6655/card.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index 36183f2a64c1..77662056c52c 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -81,9 +81,9 @@ static void vt6655_mac_set_bb_type(void __iomem *iobase, u32 mask)
  * Return Value: none
  */
 static void calculate_ofdmr_parameter(unsigned char rate,
-				       u8 bb_type,
-				       unsigned char *tx_rate,
-				       unsigned char *rsv_time)
+				      u8 bb_type,
+				      unsigned char *tx_rate,
+				      unsigned char *rsv_time)
 {
 	switch (rate) {
 	case RATE_6M:
-- 
2.25.1

[PATCH] staging: vt6655: Match parenthesis alignment

[Dorine Tipo]

Correct parameter alignment in bool card_update_tsf()

This patch aligns the parameters with the opening parenthesis for better
readability and adherence to coding style guidelines.

Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
---
 drivers/staging/vt6655/card.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index 77662056c52c..2fb2b1da9136 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -288,7 +288,7 @@ bool card_set_phy_parameter(struct vnt_private *priv, u8 bb_type)
  * Return Value: none
  */
 bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,
-		    u64 bss_timestamp)
+		     u64 bss_timestamp)
 {
 	u64 local_tsf;
 	u64 tsf_offset = 0;
-- 
2.25.1

[PATCH] staging: vt6655: Match parenthesis alignment

[Dorine Tipo]

Align parameters in card_get_tsf_offset()

This patch aligns the 'local_tsf' parameter with the open parenthesis.
This change improves code readability and maintains consistency with coding
standards.

Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
---
 drivers/staging/vt6655/card.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index 2fb2b1da9136..94784b5c0402 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -297,7 +297,7 @@ bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,
 
 	if (bss_timestamp != local_tsf) {
 		tsf_offset = card_get_tsf_offset(rx_rate, bss_timestamp,
-						local_tsf);
+						 local_tsf);
 		/* adjust TSF, HW's TSF add TSF Offset reg */
 		tsf_offset =  le64_to_cpu(tsf_offset);
 		iowrite32((u32)tsf_offset, priv->port_offset + MAC_REG_TSFOFST);
-- 
2.25.1

[PATCH] staging: vt6655: Match parenthesis alignment

[Dorine Tipo]

Correct parameter alignment in bool card_set_beacon_period().

This patch aligns the beacon_interval parameter with the opening parenthesis.
This change improves code readability and maintains consistency with coding
style guidelines.

Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
---
 drivers/staging/vt6655/card.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index 94784b5c0402..3f807d898607 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -321,7 +321,7 @@ bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,
  * Return Value: true if succeed; otherwise false
  */
 bool card_set_beacon_period(struct vnt_private *priv,
-			  unsigned short beacon_interval)
+			    unsigned short beacon_interval)
 {
 	u64 next_tbtt;
 
-- 
2.25.1

Re: [PATCH] staging: vt6655: Match parenthesis alignment

[Greg KH]

On Sun, Mar 03, 2024 at 06:56:40AM +0000, Dorine Tipo wrote:
> Align parameters in static void calculate_ofdmr_parameter()
> 
> This patch aligns the parameters with the opening parenthesis for better
> readability and adherence to coding style guidelines.
> 
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> ---
>  drivers/staging/vt6655/card.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Hi,

You sent 5 patches with all the same subject line, yet they did
different things :(

Please resend these, all together as a proper patch series, with unique
subjects so we can review them easier.

thanks,

greg k-h

Re: [PATCH] staging: vt6655: Match parenthesis alignment

[Philipp Hortmann]

On 3/3/24 08:59, Dorine Tipo wrote:
> Correct parameter alignment in bool card_set_beacon_period().
> 
> This patch aligns the beacon_interval parameter with the opening parenthesis.
> This change improves code readability and maintains consistency with coding
> style guidelines.
> 
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> ---
>   drivers/staging/vt6655/card.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
> index 94784b5c0402..3f807d898607 100644
> --- a/drivers/staging/vt6655/card.c
> +++ b/drivers/staging/vt6655/card.c
> @@ -321,7 +321,7 @@ bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,
>    * Return Value: true if succeed; otherwise false
>    */
>   bool card_set_beacon_period(struct vnt_private *priv,
> -			  unsigned short beacon_interval)
> +			    unsigned short beacon_interval)
>   {
>   	u64 next_tbtt;
>   

Hi Dorine,

in addition: Please include a version history on the next series. It 
needs to have a v2 in the subject. Fix the following checkpatch warning 
as well. Did you run checkpatch on your patches?

WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit 
description?)
#9:
This patch aligns the beacon_interval parameter with the opening 
parenthesis.

Thanks for your support.

Bye Philipp