[PATCH] staging: vt6655: Match parenthesis alignment

[PATCH] staging: vt6655: Match parenthesis alignment

[Dorine Tipo]

Align parameters in static void calculate_ofdmr_parameter()

This patch aligns the parameters with the opening parenthesis for better
readability and adherence to coding style guidelines.

Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
---
 drivers/staging/vt6655/card.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index 36183f2a64c1..77662056c52c 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -81,9 +81,9 @@ static void vt6655_mac_set_bb_type(void __iomem *iobase, u32 mask)
  * Return Value: none
  */
 static void calculate_ofdmr_parameter(unsigned char rate,
-				       u8 bb_type,
-				       unsigned char *tx_rate,
-				       unsigned char *rsv_time)
+				      u8 bb_type,
+				      unsigned char *tx_rate,
+				      unsigned char *rsv_time)
 {
 	switch (rate) {
 	case RATE_6M:
-- 
2.25.1

Re: [PATCH] staging: vt6655: Match parenthesis alignment

[Greg KH]

On Sun, Mar 03, 2024 at 06:56:40AM +0000, Dorine Tipo wrote:
> Align parameters in static void calculate_ofdmr_parameter()
> 
> This patch aligns the parameters with the opening parenthesis for better
> readability and adherence to coding style guidelines.
> 
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> ---
>  drivers/staging/vt6655/card.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Hi,

You sent 5 patches with all the same subject line, yet they did
different things :(

Please resend these, all together as a proper patch series, with unique
subjects so we can review them easier.

thanks,

greg k-h

[PATCH v2 0/5] staging: Fix parameters alignment

[Dorine Tipo]

Hello!

This V2 patch series addresses inconsistencies in parameter alignment with
open parantheses, enhancing readability and maintainability of the code.
The patch series includes updates to multiple files in the staging
directory. Each patch focuses on specific functions or sections of code to
ensure comprehensive coverage of the alignment improvements.

Patch 1 fixes the parameter alignment in cvmx_spi_restart_interface() in
octeon-stubs.h in the octeon driver
Patches 2-6 fix the alignment of parameters in various functions inside
card.c in the vt6655 driver

Changelog:
- V2: Modified subjects to be unique for each patch, as requested by
  greg k-h
- Fixed the warnings in the patches as suggested by Philipp


Dorine Tipo (5):
  Staging: octeon: Match parenthesis alignment
  staging: vt6655: Correct parameters alignment
  staging: vt6655: Align parameters with parenthesis
  staging: vt6655: Match open parenthesis alignment
  staging: vt6655: Fix open parenthesis alignment

 drivers/staging/octeon/octeon-stubs.h |  2 +-
 drivers/staging/vt6655/card.c         | 12 ++++++------
 2 files changed, 7 insertions(+), 7 deletions(-)

-- 
2.25.1

[PATCH v2 1/5] Staging: octeon: Match parenthesis alignment

[Dorine Tipo]

Correct parameter alignment in cvmx_spi_restart_interface().

This patch aligns the parameters with the opening parenthesis for better
readability and adherence to coding style guidelines.

Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
---
 drivers/staging/octeon/octeon-stubs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h
index 3e7b92cd2e35..44cced319c11 100644
--- a/drivers/staging/octeon/octeon-stubs.h
+++ b/drivers/staging/octeon/octeon-stubs.h
@@ -1362,7 +1362,7 @@ static inline struct cvmx_wqe *cvmx_pow_work_request_sync(cvmx_pow_wait_t wait)
 }

 static inline int cvmx_spi_restart_interface(int interface,
-					cvmx_spi_mode_t mode, int timeout)
+					     cvmx_spi_mode_t mode, int timeout)
 {
 	return 0;
 }
--
2.25.1

[PATCH v2 2/5] staging: vt6655: Correct parameters alignment

[Dorine Tipo]

Align parameters in static void calculate_ofdmr_parameter()

This patch aligns the parameters with the opening parenthesis for better
readability and adherence to coding style guidelines.

Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
---
 drivers/staging/vt6655/card.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index 36183f2a64c1..77662056c52c 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -81,9 +81,9 @@ static void vt6655_mac_set_bb_type(void __iomem *iobase, u32 mask)
  * Return Value: none
  */
 static void calculate_ofdmr_parameter(unsigned char rate,
-				       u8 bb_type,
-				       unsigned char *tx_rate,
-				       unsigned char *rsv_time)
+				      u8 bb_type,
+				      unsigned char *tx_rate,
+				      unsigned char *rsv_time)
 {
 	switch (rate) {
 	case RATE_6M:
--
2.25.1

[PATCH v2 3/5] staging: vt6655: Align parameters with parenthesis

[Dorine Tipo]

Correct parameter alignment in bool card_update_tsf()

This patch aligns the parameters with the opening parenthesis for better
readability and adherence to coding style guidelines.

Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
---
 drivers/staging/vt6655/card.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index 77662056c52c..2fb2b1da9136 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -288,7 +288,7 @@ bool card_set_phy_parameter(struct vnt_private *priv, u8 bb_type)
  * Return Value: none
  */
 bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,
-		    u64 bss_timestamp)
+		     u64 bss_timestamp)
 {
 	u64 local_tsf;
 	u64 tsf_offset = 0;
--
2.25.1

[PATCH v2 4/5] staging: vt6655: Match open parenthesis alignment

[Dorine Tipo]

Align parameters in card_get_tsf_offset()

This patch aligns the 'local_tsf' parameter with the open parenthesis.
This change improves code readability and maintains consistency with coding
standards.

Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
---
 drivers/staging/vt6655/card.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index 2fb2b1da9136..94784b5c0402 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -297,7 +297,7 @@ bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,

 	if (bss_timestamp != local_tsf) {
 		tsf_offset = card_get_tsf_offset(rx_rate, bss_timestamp,
-						local_tsf);
+						 local_tsf);
 		/* adjust TSF, HW's TSF add TSF Offset reg */
 		tsf_offset =  le64_to_cpu(tsf_offset);
 		iowrite32((u32)tsf_offset, priv->port_offset + MAC_REG_TSFOFST);
--
2.25.1

[PATCH v2 5/5] staging: vt6655: Fix open parenthesis alignment

[Dorine Tipo]

Correct parameter alignment in bool card_set_beacon_period().

This patch aligns the beacon_interval parameter with the opening
parenthesis.
This change improves code readability and adheres to coding style
guidelines.

Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
---
 drivers/staging/vt6655/card.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index 94784b5c0402..3f807d898607 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -321,7 +321,7 @@ bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,
  * Return Value: true if succeed; otherwise false
  */
 bool card_set_beacon_period(struct vnt_private *priv,
-			  unsigned short beacon_interval)
+			    unsigned short beacon_interval)
 {
 	u64 next_tbtt;

--
2.25.1

Re: [PATCH v2 0/5] staging: Fix parameters alignment

[Dan Carpenter]

On Mon, Mar 04, 2024 at 12:40:01PM +0000, Dorine Tipo wrote:
> Hello!
> 
> This V2 patch series addresses inconsistencies in parameter alignment with
> open parantheses, enhancing readability and maintainability of the code.
> The patch series includes updates to multiple files in the staging
> directory. Each patch focuses on specific functions or sections of code to
> ensure comprehensive coverage of the alignment improvements.
> 
> Patch 1 fixes the parameter alignment in cvmx_spi_restart_interface() in
> octeon-stubs.h in the octeon driver
> Patches 2-6 fix the alignment of parameters in various functions inside
> card.c in the vt6655 driver
> 
> Changelog:
> - V2: Modified subjects to be unique for each patch, as requested by
>   greg k-h
> - Fixed the warnings in the patches as suggested by Philipp
> 
> 
> Dorine Tipo (5):
>   Staging: octeon: Match parenthesis alignment

Do the octeon patch as a separate patchset.  It's a totally different
driver.

>   staging: vt6655: Correct parameters alignment
>   staging: vt6655: Align parameters with parenthesis
>   staging: vt6655: Match open parenthesis alignment
>   staging: vt6655: Fix open parenthesis alignment

Combine all these patches into one patch.  The rule is "one thing per
patch"  not "one line per patch".

regards,
dan carpenter

[PATCH v3 0/1] Staging: vt6655: Parameter Alignment Improvements

[Dorine Tipo]

This V3 patch series addresses inconsistencies in parameter alignment with
open parantheses, enhancing readability and maintainability of the code.

Changelog:
V2: Modified subjects to be unique for each patch, as requested by
<gregkh@linuxfoundation.org>
    Fixed the warnings in the patches as suggested by
<philipp.g.hortmann@gmail.com>

V3: Combined the vt6655 patches into one patch as suggested by
<dan.carpenter@linaro.org>

Dorine Tipo (1):
  staging: vt6655: Correct parameters alignment

 drivers/staging/vt6655/card.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

-- 
2.25.1

[PATCH v3 1/1] staging: vt6655: Correct parameters alignment

[Dorine Tipo]

Align parameters in static void calculate_ofdmr_parameter()

This patch aligns the parameters with the opening parenthesis for better
readability and adherence to coding style guidelines.

Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>

Correct parameter alignment in bool card_update_tsf()

This patch aligns the parameters with the opening parenthesis for better
readability and adherence to coding style guidelines.

Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>

Align parameters in card_get_tsf_offset()

This patch aligns the 'local_tsf' parameter with the open parenthesis.
This change improves code readability and maintains consistency with coding
standards.

Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>

Correct parameter alignment in bool card_set_beacon_period().

This patch aligns the beacon_interval parameter with the opening
parenthesis.
This change improves code readability and adheres to coding style
guidelines.

Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
---
 drivers/staging/vt6655/card.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index 36183f2a64c1..3f807d898607 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -81,9 +81,9 @@ static void vt6655_mac_set_bb_type(void __iomem *iobase, u32 mask)
  * Return Value: none
  */
 static void calculate_ofdmr_parameter(unsigned char rate,
-				       u8 bb_type,
-				       unsigned char *tx_rate,
-				       unsigned char *rsv_time)
+				      u8 bb_type,
+				      unsigned char *tx_rate,
+				      unsigned char *rsv_time)
 {
 	switch (rate) {
 	case RATE_6M:
@@ -288,7 +288,7 @@ bool card_set_phy_parameter(struct vnt_private *priv, u8 bb_type)
  * Return Value: none
  */
 bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,
-		    u64 bss_timestamp)
+		     u64 bss_timestamp)
 {
 	u64 local_tsf;
 	u64 tsf_offset = 0;
@@ -297,7 +297,7 @@ bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,
 
 	if (bss_timestamp != local_tsf) {
 		tsf_offset = card_get_tsf_offset(rx_rate, bss_timestamp,
-						local_tsf);
+						 local_tsf);
 		/* adjust TSF, HW's TSF add TSF Offset reg */
 		tsf_offset =  le64_to_cpu(tsf_offset);
 		iowrite32((u32)tsf_offset, priv->port_offset + MAC_REG_TSFOFST);
@@ -321,7 +321,7 @@ bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,
  * Return Value: true if succeed; otherwise false
  */
 bool card_set_beacon_period(struct vnt_private *priv,
-			  unsigned short beacon_interval)
+			    unsigned short beacon_interval)
 {
 	u64 next_tbtt;
 
-- 
2.25.1

Re: [PATCH v3 1/1] staging: vt6655: Correct parameters alignment

[Philipp Hortmann]

On 3/4/24 15:26, Dorine Tipo wrote:
> Align parameters in static void calculate_ofdmr_parameter()
> 
> This patch aligns the parameters with the opening parenthesis for better
> readability and adherence to coding style guidelines.
> 
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>

Hi Dorine,

please use only one Signed-off-by. See output of checkpatch:
WARNING: Duplicate signature
#19:
Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>



> Correct parameter alignment in bool card_update_tsf()
> 
> This patch aligns the parameters with the opening parenthesis for better
> readability and adherence to coding style guidelines.
> 
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> 
> Align parameters in card_get_tsf_offset()
> 
> This patch aligns the 'local_tsf' parameter with the open parenthesis.
> This change improves code readability and maintains consistency with coding
> standards.
> 
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> 
> Correct parameter alignment in bool card_set_beacon_period().
> 
> This patch aligns the beacon_interval parameter with the opening
> parenthesis.
> This change improves code readability and adheres to coding style
> guidelines.
> 
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> ---
>   drivers/staging/vt6655/card.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
>

If you have just one patch you do not need a patch series. Omit the 
cover letter.

In the description please do not describe what you did. Only write why 
you did it.

Look under "git log" of your repo what is good.

Please insert a change history below the --- (You can take it from the 
cover letter)

Thanks for your support.

Bye Philipp

[PATCH v4] staging: vt6655: Match open parentheses

[Dorine Tipo]

Align parameters in static void calculate_ofdmr_parameter(),
bool card_update_tsf(), card_get_tsf_offset(), and
bool card_set_beacon_period().

This patch fixes the alignment of parameters within various functions
with the opening parentheses.
This change improves code readability and ensures adherence to coding
style guidelines.

Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
---
Changelog:
V2: Modified subjects to be unique for each patch, as requested by
<gregkh@linuxfoundation.org>
    Fixed the warnings in the patches as suggested by
<philipp.g.hortmann@gmail.com>

V3: Combined the vt6655 patches into one patch as suggested by
<dan.carpenter@linaro.org>
V4: Removed the multiple signed-off-by as suggested by
    <philipp.g.hortmann@gmail.com>
    Omitted the cover letter as the changes have been combined into one
    patch
    Reworked the patch subject to be concise

 drivers/staging/vt6655/card.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index 36183f2a64c1..3f807d898607 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -81,9 +81,9 @@ static void vt6655_mac_set_bb_type(void __iomem *iobase, u32 mask)
  * Return Value: none
  */
 static void calculate_ofdmr_parameter(unsigned char rate,
-				       u8 bb_type,
-				       unsigned char *tx_rate,
-				       unsigned char *rsv_time)
+				      u8 bb_type,
+				      unsigned char *tx_rate,
+				      unsigned char *rsv_time)
 {
 	switch (rate) {
 	case RATE_6M:
@@ -288,7 +288,7 @@ bool card_set_phy_parameter(struct vnt_private *priv, u8 bb_type)
  * Return Value: none
  */
 bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,
-		    u64 bss_timestamp)
+		     u64 bss_timestamp)
 {
 	u64 local_tsf;
 	u64 tsf_offset = 0;
@@ -297,7 +297,7 @@ bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,

 	if (bss_timestamp != local_tsf) {
 		tsf_offset = card_get_tsf_offset(rx_rate, bss_timestamp,
-						local_tsf);
+						 local_tsf);
 		/* adjust TSF, HW's TSF add TSF Offset reg */
 		tsf_offset =  le64_to_cpu(tsf_offset);
 		iowrite32((u32)tsf_offset, priv->port_offset + MAC_REG_TSFOFST);
@@ -321,7 +321,7 @@ bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,
  * Return Value: true if succeed; otherwise false
  */
 bool card_set_beacon_period(struct vnt_private *priv,
-			  unsigned short beacon_interval)
+			    unsigned short beacon_interval)
 {
 	u64 next_tbtt;

--
2.25.1

Re: [PATCH v3 1/1] staging: vt6655: Correct parameters alignment

[Dan Carpenter]

On Mon, Mar 04, 2024 at 02:26:03PM +0000, Dorine Tipo wrote:
> Align parameters in static void calculate_ofdmr_parameter()
> 
> This patch aligns the parameters with the opening parenthesis for better
> readability and adherence to coding style guidelines.
> 
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> 
> Correct parameter alignment in bool card_update_tsf()
> 
> This patch aligns the parameters with the opening parenthesis for better
> readability and adherence to coding style guidelines.
> 
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> 
> Align parameters in card_get_tsf_offset()
> 
> This patch aligns the 'local_tsf' parameter with the open parenthesis.
> This change improves code readability and maintains consistency with coding
> standards.
> 
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> 
> Correct parameter alignment in bool card_set_beacon_period().
> 
> This patch aligns the beacon_interval parameter with the opening
> parenthesis.
> This change improves code readability and adheres to coding style
> guidelines.
> 
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> ---

This commit message got a bit messed up...  It should just say: "Align
the function parameters to silence a checkpatch warning." with one
signed-off-by.

regards,
dan carpenter

[PATCH v5] staging: vt6655: Match open parentheses

[Dorine Tipo]

Align the function parameters to silence a checkpatch warning

Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
---
Changelog:
V2: Modified subjects to be unique for each patch, as requested by
<gregkh@linuxfoundation.org>
    Fixed the warnings in the patches as suggested by
<philipp.g.hortmann@gmail.com>

V3: Combined the vt6655 patches into one patch as suggested by
<dan.carpenter@linaro.org>

V4: Removed the multiple signed-off-by as suggested by
    <philipp.g.hortmann@gmail.com>
    Omitted the cover letter as the changes have been combined into one
    patch
    Reworked the patch subject to be concise

V5: Fixed the commit message to "Align
    the function parameters to silence a checkpatch warning." as
    suggested by <dan.carpenter@linaro.org>

 drivers/staging/vt6655/card.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index 36183f2a64c1..3f807d898607 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -81,9 +81,9 @@ static void vt6655_mac_set_bb_type(void __iomem *iobase, u32 mask)
  * Return Value: none
  */
 static void calculate_ofdmr_parameter(unsigned char rate,
-				       u8 bb_type,
-				       unsigned char *tx_rate,
-				       unsigned char *rsv_time)
+				      u8 bb_type,
+				      unsigned char *tx_rate,
+				      unsigned char *rsv_time)
 {
 	switch (rate) {
 	case RATE_6M:
@@ -288,7 +288,7 @@ bool card_set_phy_parameter(struct vnt_private *priv, u8 bb_type)
  * Return Value: none
  */
 bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,
-		    u64 bss_timestamp)
+		     u64 bss_timestamp)
 {
 	u64 local_tsf;
 	u64 tsf_offset = 0;
@@ -297,7 +297,7 @@ bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,
 
 	if (bss_timestamp != local_tsf) {
 		tsf_offset = card_get_tsf_offset(rx_rate, bss_timestamp,
-						local_tsf);
+						 local_tsf);
 		/* adjust TSF, HW's TSF add TSF Offset reg */
 		tsf_offset =  le64_to_cpu(tsf_offset);
 		iowrite32((u32)tsf_offset, priv->port_offset + MAC_REG_TSFOFST);
@@ -321,7 +321,7 @@ bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,
  * Return Value: true if succeed; otherwise false
  */
 bool card_set_beacon_period(struct vnt_private *priv,
-			  unsigned short beacon_interval)
+			    unsigned short beacon_interval)
 {
 	u64 next_tbtt;
 
-- 
2.25.1

[PATCH v6] staging: vt6655: Match open parentheses

[Dorine Tipo]

Align the function parameters to silence a checkpatch warning.

Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
---
Changelog:
V2: Modified subjects to be unique for each patch, as requested by
<gregkh@linuxfoundation.org>
    Fixed the warnings in the patches as suggested by
<philipp.g.hortmann@gmail.com>

V3: Combined the vt6655 patches into one patch as suggested by
<dan.carpenter@linaro.org>

V4: Removed the multiple signed-off-by as suggested by
    <philipp.g.hortmann@gmail.com>
    Omitted the cover letter as the changes have been combined into one
    patch
    Reworked the patch subject to be concise

V5: Fixed the commit message to "Align
    the function parameters to silence a checkpatch warning." as
    suggested by <dan.carpenter@linaro.org>

V6: Fix trailing white spaces in the patch to silence checkpatch warning

 drivers/staging/vt6655/card.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index 36183f2a64c1..3f807d898607 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -81,9 +81,9 @@ static void vt6655_mac_set_bb_type(void __iomem *iobase, u32 mask)
  * Return Value: none
  */
 static void calculate_ofdmr_parameter(unsigned char rate,
-				       u8 bb_type,
-				       unsigned char *tx_rate,
-				       unsigned char *rsv_time)
+				      u8 bb_type,
+				      unsigned char *tx_rate,
+				      unsigned char *rsv_time)
 {
 	switch (rate) {
 	case RATE_6M:
@@ -288,7 +288,7 @@ bool card_set_phy_parameter(struct vnt_private *priv, u8 bb_type)
  * Return Value: none
  */
 bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,
-		    u64 bss_timestamp)
+		     u64 bss_timestamp)
 {
 	u64 local_tsf;
 	u64 tsf_offset = 0;
@@ -297,7 +297,7 @@ bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,

 	if (bss_timestamp != local_tsf) {
 		tsf_offset = card_get_tsf_offset(rx_rate, bss_timestamp,
-						local_tsf);
+						 local_tsf);
 		/* adjust TSF, HW's TSF add TSF Offset reg */
 		tsf_offset =  le64_to_cpu(tsf_offset);
 		iowrite32((u32)tsf_offset, priv->port_offset + MAC_REG_TSFOFST);
@@ -321,7 +321,7 @@ bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,
  * Return Value: true if succeed; otherwise false
  */
 bool card_set_beacon_period(struct vnt_private *priv,
-			  unsigned short beacon_interval)
+			    unsigned short beacon_interval)
 {
 	u64 next_tbtt;

--
2.25.1

Re: [PATCH v6] staging: vt6655: Match open parentheses

[Philipp Hortmann]

On 3/5/24 10:32, Dorine Tipo wrote:
> Align the function parameters to silence a checkpatch warning.
> 
> Signed-off-by: Dorine Tipo<dorine.a.tipo@gmail.com>
> ---

Hi Dorine,
I tried to apply your patch but it failed. I do not really understand 
why. Have you edited the patch manually or was it created by git?

Thanks for your support.

Bye Philipp

git apply --reject --whitespace=fix ~/Downloads/20240305*
kernel@matrix-ESPRIMO-P710:~/Documents/git/kernels/staging$ git apply 
--reject --whitespace=fix ~/Downloads/20240305*
Checking patch drivers/staging/vt6655/card.c...
error: while searching for:
  * Return Value: none
  */
static void calculate_ofdmr_parameter(unsigned char rate,
				       u8 bb_type,
				       unsigned char *tx_rate,
				       unsigned char *rsv_time)
{
	switch (rate) {
	case RATE_6M:

error: patch failed: drivers/staging/vt6655/card.c:81
error: while searching for:
  * Return Value: none
  */
bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,
		    u64 bss_timestamp)
{
	u64 local_tsf;
	u64 tsf_offset = 0;

error: patch failed: drivers/staging/vt6655/card.c:288
error: while searching for:

	if (bss_timestamp != local_tsf) {
		tsf_offset = card_get_tsf_offset(rx_rate, bss_timestamp,
						local_tsf);
		/* adjust TSF, HW's TSF add TSF Offset reg */
		tsf_offset =  le64_to_cpu(tsf_offset);
		iowrite32((u32)tsf_offset, priv->port_offset + MAC_REG_TSFOFST);

error: patch failed: drivers/staging/vt6655/card.c:297
error: while searching for:
  * Return Value: true if succeed; otherwise false
  */
bool card_set_beacon_period(struct vnt_private *priv,
			  unsigned short beacon_interval)
{
	u64 next_tbtt;


error: patch failed: drivers/staging/vt6655/card.c:321
Applying patch drivers/staging/vt6655/card.c with 4 rejects...
Rejected hunk #1.
Rejected hunk #2.
Rejected hunk #3.
Rejected hunk #4.

Re: [PATCH v6] staging: vt6655: Match open parentheses

[Dan Carpenter]

On Tue, Mar 05, 2024 at 11:01:09PM +0100, Philipp Hortmann wrote:
> On 3/5/24 10:32, Dorine Tipo wrote:
> > Align the function parameters to silence a checkpatch warning.
> > 
> > Signed-off-by: Dorine Tipo<dorine.a.tipo@gmail.com>
> > ---
> 
> Hi Dorine,
> I tried to apply your patch but it failed. I do not really understand why.
> Have you edited the patch manually or was it created by git?
> 
> Thanks for your support.

When you resend, could you start a new thread?  We used to advise people
to reply to the same thread but these days we always tell people to
start a new thread for a new version.

regards,
dan carpenter

Re: [PATCH v6] staging: vt6655: Match open parentheses

[Philipp Hortmann]

On 3/6/24 05:59, Dan Carpenter wrote:
> On Tue, Mar 05, 2024 at 11:01:09PM +0100, Philipp Hortmann wrote:
>> On 3/5/24 10:32, Dorine Tipo wrote:
>>> Align the function parameters to silence a checkpatch warning.
>>>
>>> Signed-off-by: Dorine Tipo<dorine.a.tipo@gmail.com>
>>> ---
>>
>> Hi Dorine,
>> I tried to apply your patch but it failed. I do not really understand why.
>> Have you edited the patch manually or was it created by git?
>>
>> Thanks for your support.
> 
> When you resend, could you start a new thread?  We used to advise people
> to reply to the same thread but these days we always tell people to
> start a new thread for a new version.
> 
> regards,
> dan carpenter
> 

Hi Dorine,

one more thing would be nice. Could you make the Subject more unique? 
Just think about the many patches the maintainer and reviewers have to 
read and recognize for some time. Please add a filename or one of the 
function names.

Thanks for your support.

Bye Philipp

[PATCH V3] Staging: octeon: match parentheses alignment

[Dorine Tipo]

Correct parameter alignment in cvmx_spi_restart_interface().

This patch aligns the parameters with the opening parenthesis for better
readability and adherence to coding style guidelines.

Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
---
 drivers/staging/octeon/octeon-stubs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h
index 3e7b92cd2e35..44cced319c11 100644
--- a/drivers/staging/octeon/octeon-stubs.h
+++ b/drivers/staging/octeon/octeon-stubs.h
@@ -1362,7 +1362,7 @@ static inline struct cvmx_wqe *cvmx_pow_work_request_sync(cvmx_pow_wait_t wait)
 }
 
 static inline int cvmx_spi_restart_interface(int interface,
-					cvmx_spi_mode_t mode, int timeout)
+					     cvmx_spi_mode_t mode, int timeout)
 {
 	return 0;
 }
-- 
2.25.1

Re: [PATCH V3] Staging: octeon: match parentheses alignment

[Greg KH]

On Mon, Mar 04, 2024 at 02:49:37PM +0000, Dorine Tipo wrote:
> Correct parameter alignment in cvmx_spi_restart_interface().
> 
> This patch aligns the parameters with the opening parenthesis for better
> readability and adherence to coding style guidelines.
> 
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> ---
>  drivers/staging/octeon/octeon-stubs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h
> index 3e7b92cd2e35..44cced319c11 100644
> --- a/drivers/staging/octeon/octeon-stubs.h
> +++ b/drivers/staging/octeon/octeon-stubs.h
> @@ -1362,7 +1362,7 @@ static inline struct cvmx_wqe *cvmx_pow_work_request_sync(cvmx_pow_wait_t wait)
>  }
>  
>  static inline int cvmx_spi_restart_interface(int interface,
> -					cvmx_spi_mode_t mode, int timeout)
> +					     cvmx_spi_mode_t mode, int timeout)
>  {
>  	return 0;
>  }
> -- 
> 2.25.1
> 
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

[PATCH v4] Staging: octeon: Match parenthesis alignment

[Dorine Tipo]

Correct parameter alignment in cvmx_spi_restart_interface().

This patch aligns the parameters with the opening parenthesis for better
readability and adherence to coding style guidelines.

Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
---
Changelog:

V2: Fixed the warnings in the patch as suggested by
    <philipp.g.hortmann@gmail.com>

V3: Reworked this patch as a separate patchset as suggested by
    <dan.carpenter@linaro.org>

V4: Added a changelog at the bottom as suggested by
    <gregkh@linuxfoundation.org>

 drivers/staging/octeon/octeon-stubs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h
index 3e7b92cd2e35..44cced319c11 100644
--- a/drivers/staging/octeon/octeon-stubs.h
+++ b/drivers/staging/octeon/octeon-stubs.h
@@ -1362,7 +1362,7 @@ static inline struct cvmx_wqe *cvmx_pow_work_request_sync(cvmx_pow_wait_t wait)
 }

 static inline int cvmx_spi_restart_interface(int interface,
-					cvmx_spi_mode_t mode, int timeout)
+					     cvmx_spi_mode_t mode, int timeout)
 {
 	return 0;
 }
--
2.25.1

[PATCH v5] Staging: octeon: Match parenthesis alignment

[Dorine Tipo]

Align the function parameters to silence a checkpatch warning.

Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
---
Changelog:

V2: Fixed the warnings in the patch as suggested by
    <philipp.g.hortmann@gmail.com>

V3: Reworked this patch as a separate patchset as suggested by
    <dan.carpenter@linaro.org>

V4: Added a changelog at the bottom as suggested by
    <gregkh@linuxfoundation.org>

V5: Fixed the commit message

 drivers/staging/octeon/octeon-stubs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/octeon/octeon-stubs.h b/drivers/staging/octeon/octeon-stubs.h
index 3e7b92cd2e35..44cced319c11 100644
--- a/drivers/staging/octeon/octeon-stubs.h
+++ b/drivers/staging/octeon/octeon-stubs.h
@@ -1362,7 +1362,7 @@ static inline struct cvmx_wqe *cvmx_pow_work_request_sync(cvmx_pow_wait_t wait)
 }

 static inline int cvmx_spi_restart_interface(int interface,
-					cvmx_spi_mode_t mode, int timeout)
+					     cvmx_spi_mode_t mode, int timeout)
 {
 	return 0;
 }
--
2.25.1

Re: [PATCH v5] Staging: octeon: Match parenthesis alignment

[Dan Carpenter]

On Tue, Mar 05, 2024 at 09:23:10AM +0000, Dorine Tipo wrote:
> Align the function parameters to silence a checkpatch warning.
> 
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> ---
> Changelog:
> 
> V2: Fixed the warnings in the patch as suggested by
>     <philipp.g.hortmann@gmail.com>
> 
> V3: Reworked this patch as a separate patchset as suggested by
>     <dan.carpenter@linaro.org>
> 
> V4: Added a changelog at the bottom as suggested by
>     <gregkh@linuxfoundation.org>
> 
> V5: Fixed the commit message

The v4 commit message was fine.  I was reviewing the v3 commit message
which was messed up and proposed a sample commit message.  But yours
was also fine.

regards,
dan carpenter

[PATCH] staging: vt6655: Match parenthesis alignment

[Dorine Tipo]

Correct parameter alignment in bool card_update_tsf()

This patch aligns the parameters with the opening parenthesis for better
readability and adherence to coding style guidelines.

Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
---
 drivers/staging/vt6655/card.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index 77662056c52c..2fb2b1da9136 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -288,7 +288,7 @@ bool card_set_phy_parameter(struct vnt_private *priv, u8 bb_type)
  * Return Value: none
  */
 bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,
-		    u64 bss_timestamp)
+		     u64 bss_timestamp)
 {
 	u64 local_tsf;
 	u64 tsf_offset = 0;
-- 
2.25.1

[PATCH] staging: vt6655: Match parentesis alignment

[Dorine Tipo]

Align parameters in card_get_tsf_offset()

This patch aligns the 'local_tsf' parameter with the open parenthesis.
This change improves code readability and maintains consistency with coding
standards.

Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
---
 drivers/staging/vt6655/card.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index 2fb2b1da9136..94784b5c0402 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -297,7 +297,7 @@ bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,
 
 	if (bss_timestamp != local_tsf) {
 		tsf_offset = card_get_tsf_offset(rx_rate, bss_timestamp,
-						local_tsf);
+						 local_tsf);
 		/* adjust TSF, HW's TSF add TSF Offset reg */
 		tsf_offset =  le64_to_cpu(tsf_offset);
 		iowrite32((u32)tsf_offset, priv->port_offset + MAC_REG_TSFOFST);
-- 
2.25.1

[PATCH] staging: vt6655: Match parenthesis alignment

[Dorine Tipo]

Align parameters in card_get_tsf_offset()

This patch aligns the 'local_tsf' parameter with the open parenthesis.
This change improves code readability and maintains consistency with coding
standards.

Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
---
 drivers/staging/vt6655/card.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index 2fb2b1da9136..94784b5c0402 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -297,7 +297,7 @@ bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,
 
 	if (bss_timestamp != local_tsf) {
 		tsf_offset = card_get_tsf_offset(rx_rate, bss_timestamp,
-						local_tsf);
+						 local_tsf);
 		/* adjust TSF, HW's TSF add TSF Offset reg */
 		tsf_offset =  le64_to_cpu(tsf_offset);
 		iowrite32((u32)tsf_offset, priv->port_offset + MAC_REG_TSFOFST);
-- 
2.25.1

[PATCH] staging: vt6655: Match parenthesis alignment

[Dorine Tipo]

Correct parameter alignment in bool card_set_beacon_period().

This patch aligns the beacon_interval parameter with the opening parenthesis.
This change improves code readability and maintains consistency with coding
style guidelines.

Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
---
 drivers/staging/vt6655/card.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index 94784b5c0402..3f807d898607 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -321,7 +321,7 @@ bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,
  * Return Value: true if succeed; otherwise false
  */
 bool card_set_beacon_period(struct vnt_private *priv,
-			  unsigned short beacon_interval)
+			    unsigned short beacon_interval)
 {
 	u64 next_tbtt;
 
-- 
2.25.1

Re: [PATCH] staging: vt6655: Match parenthesis alignment

[Philipp Hortmann]

On 3/3/24 08:59, Dorine Tipo wrote:
> Correct parameter alignment in bool card_set_beacon_period().
> 
> This patch aligns the beacon_interval parameter with the opening parenthesis.
> This change improves code readability and maintains consistency with coding
> style guidelines.
> 
> Signed-off-by: Dorine Tipo <dorine.a.tipo@gmail.com>
> ---
>   drivers/staging/vt6655/card.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
> index 94784b5c0402..3f807d898607 100644
> --- a/drivers/staging/vt6655/card.c
> +++ b/drivers/staging/vt6655/card.c
> @@ -321,7 +321,7 @@ bool card_update_tsf(struct vnt_private *priv, unsigned char rx_rate,
>    * Return Value: true if succeed; otherwise false
>    */
>   bool card_set_beacon_period(struct vnt_private *priv,
> -			  unsigned short beacon_interval)
> +			    unsigned short beacon_interval)
>   {
>   	u64 next_tbtt;
>   

Hi Dorine,

in addition: Please include a version history on the next series. It 
needs to have a v2 in the subject. Fix the following checkpatch warning 
as well. Did you run checkpatch on your patches?

WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit 
description?)
#9:
This patch aligns the beacon_interval parameter with the opening 
parenthesis.

Thanks for your support.

Bye Philipp