From: Dan Carpenter <dan.carpenter@linaro.org>
To: Deepanshu Kartikey <kartikey406@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] Staging: rts5208: rtsx: Moved else statement to same line with else if
Date: Tue, 30 May 2023 07:15:26 +0300 [thread overview]
Message-ID: <ee41bf67-a074-49fd-bd0f-7fb992d68884@kili.mountain> (raw)
In-Reply-To: <20230530022259.24094-1-kartikey406@gmail.com>
On Tue, May 30, 2023 at 07:52:59AM +0530, Deepanshu Kartikey wrote:
> drivers/staging/rts5208/rtsx.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
> index 2284a96abcff..47dacef0aaf8 100644
> --- a/drivers/staging/rts5208/rtsx.c
> +++ b/drivers/staging/rts5208/rtsx.c
> @@ -399,10 +399,8 @@ static int rtsx_control_thread(void *__dev)
> chip->srb->device->id,
> (u8)chip->srb->device->lun);
> chip->srb->result = DID_BAD_TARGET << 16;
> - }
> -
> - /* we've got a command, let's do it! */
> - else {
> + } else {
> + /* we've got a command, let's do it! */
This code is part of series of if else statements that all have the
same issue but you're only changing one. Please change them all.
regards,
dan carpenter
prev parent reply other threads:[~2023-05-30 4:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 2:22 [PATCH v4] Staging: rts5208: rtsx: Moved else statement to same line with else if Deepanshu Kartikey
2023-05-30 4:15 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee41bf67-a074-49fd-bd0f-7fb992d68884@kili.mountain \
--to=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=kartikey406@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox