* [PATCH v4] Staging: rts5208: rtsx: Moved else statement to same line with else if
@ 2023-05-30 2:22 Deepanshu Kartikey
2023-05-30 4:15 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Deepanshu Kartikey @ 2023-05-30 2:22 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel, Deepanshu Kartikey
Moved else statement to same line with else if,
this warning was given by checkpatch.pl
Signed-off-by: Deepanshu Kartikey <kartikey406@gmail.com>
---
Changes in V4:
- Moved else to the same line with else if
- Moved comment on else statement to inside of it
---
---
drivers/staging/rts5208/rtsx.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
index 2284a96abcff..47dacef0aaf8 100644
--- a/drivers/staging/rts5208/rtsx.c
+++ b/drivers/staging/rts5208/rtsx.c
@@ -399,10 +399,8 @@ static int rtsx_control_thread(void *__dev)
chip->srb->device->id,
(u8)chip->srb->device->lun);
chip->srb->result = DID_BAD_TARGET << 16;
- }
-
- /* we've got a command, let's do it! */
- else {
+ } else {
+ /* we've got a command, let's do it! */
scsi_show_command(chip);
rtsx_invoke_transport(chip->srb, chip);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v4] Staging: rts5208: rtsx: Moved else statement to same line with else if
2023-05-30 2:22 [PATCH v4] Staging: rts5208: rtsx: Moved else statement to same line with else if Deepanshu Kartikey
@ 2023-05-30 4:15 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2023-05-30 4:15 UTC (permalink / raw)
To: Deepanshu Kartikey; +Cc: gregkh, linux-staging, linux-kernel
On Tue, May 30, 2023 at 07:52:59AM +0530, Deepanshu Kartikey wrote:
> drivers/staging/rts5208/rtsx.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
> index 2284a96abcff..47dacef0aaf8 100644
> --- a/drivers/staging/rts5208/rtsx.c
> +++ b/drivers/staging/rts5208/rtsx.c
> @@ -399,10 +399,8 @@ static int rtsx_control_thread(void *__dev)
> chip->srb->device->id,
> (u8)chip->srb->device->lun);
> chip->srb->result = DID_BAD_TARGET << 16;
> - }
> -
> - /* we've got a command, let's do it! */
> - else {
> + } else {
> + /* we've got a command, let's do it! */
This code is part of series of if else statements that all have the
same issue but you're only changing one. Please change them all.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-30 4:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-30 2:22 [PATCH v4] Staging: rts5208: rtsx: Moved else statement to same line with else if Deepanshu Kartikey
2023-05-30 4:15 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox