From: Dan Carpenter <dan.carpenter@linaro.org>
To: Dave Penkler <dpenkler@gmail.com>
Cc: Michael Rubin <matchstick@neverthere.org>,
gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [Patch v1 01/21] staging: gpib: Using struct gpib_board_type_ioctl
Date: Wed, 9 Apr 2025 12:42:00 +0300 [thread overview]
Message-ID: <ff353ebf-a1c4-4f4f-8cbb-b6c62e70151f@stanley.mountain> (raw)
In-Reply-To: <Z_Y2Sg1tDok_MX6u@egonzo>
On Wed, Apr 09, 2025 at 10:56:42AM +0200, Dave Penkler wrote:
> On Wed, Apr 09, 2025 at 11:10:41AM +0300, Dan Carpenter wrote:
> > On Wed, Apr 09, 2025 at 05:58:43AM +0000, Michael Rubin wrote:
> > > diff --git a/drivers/staging/gpib/uapi/gpib_ioctl.h b/drivers/staging/gpib/uapi/gpib_ioctl.h
> > > index 6202865278ea..4ddcbc2a81b0 100644
> > > --- a/drivers/staging/gpib/uapi/gpib_ioctl.h
> > > +++ b/drivers/staging/gpib/uapi/gpib_ioctl.h
> > > @@ -12,9 +12,9 @@
> > >
> > > #define GPIB_CODE 160
> > >
> > > -typedef struct {
> > > +struct gpib_board_type_ioctl {
> > > char name[100];
> > > -} board_type_ioctl_t;
> > > +};
> >
> > This breaks user API so now user space can't compile. I don't think
> > any of these 21 patches can be applied.
> >
> > regards,
> > dan carpenter
> >
>
> These patches are OK. I will make a new release of the userspace libraries
> with a compat include that defines the typedefs.
Ah that's fine then. Thanks.
regards,
dan carpenter
next prev parent reply other threads:[~2025-04-09 9:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 5:58 [Patch v1 00/21] staging: gpib: Removing typedefs for ioctl API Michael Rubin
2025-04-09 5:58 ` [Patch v1 01/21] staging: gpib: Using struct gpib_board_type_ioctl Michael Rubin
2025-04-09 8:10 ` Dan Carpenter
2025-04-09 8:56 ` Dave Penkler
2025-04-09 9:42 ` Dan Carpenter [this message]
2025-04-09 5:58 ` [Patch v1 02/21] staging: gpib: Using struct gpib_read_write_ioctl Michael Rubin
2025-04-09 5:58 ` [Patch v1 03/21] staging: gpib: Using struct gpib_open_dev_ioctl Michael Rubin
2025-04-09 5:58 ` [Patch v1 04/21] staging: gpib: Using struct gpib_close_dev_ioctl Michael Rubin
2025-04-09 5:58 ` [Patch v1 05/21] staging: gpib: Using struct gpib_serial_poll_ioctl Michael Rubin
2025-04-09 5:58 ` [Patch v1 06/21] staging: gpib: Using struct gpib_eos_ioctl Michael Rubin
2025-04-09 5:58 ` [Patch v1 07/21] staging: gpib: Using struct gpib_wait_ioctl Michael Rubin
2025-04-09 5:58 ` [Patch v1 08/21] staging: gpib: Using struct gpib_online_ioctl Michael Rubin
2025-04-09 5:58 ` [Patch v1 09/21] staging: gpib: Using struct gpib_spoll_bytes_ioctl Michael Rubin
2025-04-09 5:58 ` [Patch v1 10/21] staging: gpib: Using struct gpib_board_info_ioctl Michael Rubin
2025-04-09 5:58 ` [Patch v1 11/21] staging: gpib: Using struct gpib_select_pci_ioctl Michael Rubin
2025-04-09 5:58 ` [Patch v1 12/21] staging: gpib: Using struct gpib_ppoll_config_ioctl` Michael Rubin
2025-04-09 5:58 ` [Patch v1 13/21] staging: gpib: Using struct gpib_pad_ioctl Michael Rubin
2025-04-09 5:58 ` [Patch v1 14/21] staging: gpib: Using struct gpib_sad_ioctl Michael Rubin
2025-04-09 5:58 ` [Patch v1 15/21] staging: gpib: Using gpib_select_device_path_ioctl Michael Rubin
2025-04-09 5:58 ` [Patch v1 16/21] staging: gpib: Using struct gpib_request_service2 Michael Rubin
2025-04-09 5:58 ` [Patch v1 17/21] staging: gpib: event_ioctl_t now short Michael Rubin
2025-04-09 5:59 ` [Patch v1 18/21] staging: gpib: rsc_ioctl_t now int Michael Rubin
2025-04-09 5:59 ` [Patch v1 19/21] staging: gpib: t1_delay_ioctl_t now unsigned int Michael Rubin
2025-04-09 5:59 ` [Patch v1 20/21] staging: gpib: autospoll_ioctl_t now short Michael Rubin
2025-04-09 5:59 ` [Patch v1 21/21] staging: gpib: local_ppoll_mode_ioctl_t " Michael Rubin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff353ebf-a1c4-4f4f-8cbb-b6c62e70151f@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=dpenkler@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=matchstick@neverthere.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox