* [PATCH v2 1/3] staging: sdio_intf.c: refactor function
From: Manuel Ebner @ 2026-05-22 11:55 UTC (permalink / raw)
To: manuelebner; +Cc: gregkh, linux-kernel, linux-staging, omer.e.idrissi
In-Reply-To: <20260522114317.189368-4-manuelebner@mailbox.org>
remove unused argument of rtw_sdio_if1_init()
Signed-off-by: Manuel Ebner <manuelebner@mailbox.org>
---
drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
index 1d0239eef114..4439ded602b6 100644
--- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
+++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
@@ -237,7 +237,7 @@ static void sd_intf_stop(struct adapter *padapter)
}
-static struct adapter *rtw_sdio_if1_init(struct dvobj_priv *dvobj, const struct sdio_device_id *pdid)
+static struct adapter *rtw_sdio_if1_init(struct dvobj_priv *dvobj)
{
int status = _FAIL;
struct net_device *pnetdev;
@@ -368,7 +368,7 @@ static int rtw_drv_init(
if (!dvobj)
goto exit;
- if1 = rtw_sdio_if1_init(dvobj, id);
+ if1 = rtw_sdio_if1_init(dvobj);
if (!if1)
goto free_dvobj;
--
2.54.0
^ permalink raw reply related
* [PATCH v2 2/3] staging: cleanup whitespace of sdio_intf.c
From: Manuel Ebner @ 2026-05-22 11:57 UTC (permalink / raw)
To: manuelebner; +Cc: gregkh, linux-kernel, linux-staging, omer.e.idrissi
In-Reply-To: <20260522114317.189368-4-manuelebner@mailbox.org>
remove empty lines, add lines where appropriate
reformat function declaration
Signed-off-by: Manuel Ebner <manuelebner@mailbox.org>
---
drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
index 4439ded602b6..a78fb4bc7155 100644
--- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
+++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
@@ -47,7 +47,6 @@ static void sd_sync_int_hdl(struct sdio_func *func)
{
struct dvobj_priv *psdpriv;
-
psdpriv = sdio_get_drvdata(func);
if (!psdpriv->if1)
@@ -168,6 +167,7 @@ static void sdio_deinit(struct dvobj_priv *dvobj)
sdio_release_host(func);
}
}
+
static struct dvobj_priv *sdio_dvobj_init(struct sdio_func *func)
{
int status = _FAIL;
@@ -236,7 +236,6 @@ static void sd_intf_stop(struct adapter *padapter)
rtw_hal_disable_interrupt(padapter);
}
-
static struct adapter *rtw_sdio_if1_init(struct dvobj_priv *dvobj)
{
int status = _FAIL;
@@ -270,7 +269,6 @@ static struct adapter *rtw_sdio_if1_init(struct dvobj_priv *dvobj)
/* 4 3.1 set hardware operation functions */
rtw_set_hal_ops(padapter);
-
/* 3 5. initialize Chip version */
padapter->intf_start = &sd_intf_start;
padapter->intf_stop = &sd_intf_stop;
@@ -356,9 +354,8 @@ static void rtw_sdio_if1_deinit(struct adapter *if1)
* notes: drv_init() is called when the bus driver has located a card for us to support.
* We accept the new device by returning 0.
*/
-static int rtw_drv_init(
- struct sdio_func *func,
- const struct sdio_device_id *id)
+static int rtw_drv_init(struct sdio_func *func,
+ const struct sdio_device_id *id)
{
int status = _FAIL;
struct adapter *if1 = NULL;
--
2.54.0
^ permalink raw reply related
* [PATCH v2 3/3] staging: cleanup braces of sdio_intf.c
From: Manuel Ebner @ 2026-05-22 11:58 UTC (permalink / raw)
To: manuelebner; +Cc: gregkh, linux-kernel, linux-staging, omer.e.idrissi
In-Reply-To: <20260522114317.189368-4-manuelebner@mailbox.org>
add braces to else statement
Signed-off-by: Manuel Ebner <manuelebner@mailbox.org>
---
drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
index a78fb4bc7155..fc16cf2e577d 100644
--- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
+++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
@@ -100,8 +100,9 @@ static void sdio_free_irq(struct dvobj_priv *dvobj)
netdev_err(dvobj->if1->pnetdev,
"%s: sdio_release_irq FAIL(%d)!\n",
__func__, err);
- } else
+ } else {
dvobj->drv_dbg.dbg_sdio_free_irq_cnt++;
+ }
sdio_release_host(func);
}
dvobj->irq_alloc = 0;
--
2.54.0
^ permalink raw reply related
* [PATCH v6 0/2] staging: rtl8723bs: efuse signature cleanup
From: Moksh Panicker @ 2026-05-22 12:50 UTC (permalink / raw)
To: linux-staging; +Cc: gregkh, dan.carpenter, mokshpanicker.7
This series reformats the multi-line function signatures in
rtw_efuse.c to single lines to fix checkpatch.pl warnings.
Patch 1 also fixes missing braces on the else clause in
rtw_efuse_read_1_byte(). Both patches have been compile-tested.
Changes from v5 to v6:
1) Reduced series from 3 patches to 2 by combining the signature
reformat and brace fix for rtw_efuse_read_1_byte() — splitting
them caused a build failure between patches.
2) Compile-tested each patch individually before sending.
Moksh Panicker (2):
staging: rtl8723bs: reformat rtw_efuse_read_1_byte() signature
staging: rtl8723bs: reformat rtw_efuse_one_byte_read() signature
drivers/staging/rtl8723bs/core/rtw_efuse.c | 15 +++++-----------
1 file changed, 4 insertions(+), 11 deletions(-)
--
2.34.1
^ permalink raw reply
* [PATCH v6 1/2] staging: rtl8723bs: reformat rtw_efuse_read_1_byte() signature
From: Moksh Panicker @ 2026-05-22 12:50 UTC (permalink / raw)
To: linux-staging; +Cc: gregkh, dan.carpenter, mokshpanicker.7
In-Reply-To: <20260522125022.29700-1-mokshpanicker.7@gmail.com>
Reformat multi-line function signature to a single line to fix
line length and coding style warnings from checkpatch.pl.
Also fix the missing brace/comment spacing in rtw_efuse_read_1_byte().
Note: CamelCase identifiers (Adapter, Address) are pre-existing
in this function and not introduced by this patch.
Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_efuse.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
index 803a608b74fa..ab7486020b3f 100644
--- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
+++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
@@ -41,10 +41,7 @@ rtw_efuse_calculate_word_counts(u8 word_en)
* 09/23/2008 MHC Copy from WMAC.
*
*/
-u8
-rtw_efuse_read_1_byte(
-struct adapter *Adapter,
-u16 Address)
+u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
{
u8 Bytetemp = {0x00};
u8 temp = {0x00};
@@ -76,9 +73,9 @@ u16 Address)
break;
}
return rtw_read8(Adapter, EFUSE_CTRL);
- } else
+ } else {
return 0xFF;
-
+ }
} /* rtw_efuse_read_1_byte */
/* 11/16/2008 MH Read one byte from real Efuse. */
--
2.34.1
^ permalink raw reply related
* [PATCH v6 2/2] staging: rtl8723bs: reformat rtw_efuse_one_byte_read() signature
From: Moksh Panicker @ 2026-05-22 12:50 UTC (permalink / raw)
To: linux-staging; +Cc: gregkh, dan.carpenter, mokshpanicker.7
In-Reply-To: <20260522125022.29700-1-mokshpanicker.7@gmail.com>
Reformat multi-line function signature to a single line to fix
line length and coding style warnings from checkpatch.pl.
Signed-off-by: Moksh Panicker <mokshpanicker.7@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_efuse.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
index ab7486020b3f..168ecb7a998f 100644
--- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
+++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
@@ -79,11 +79,7 @@ u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
} /* rtw_efuse_read_1_byte */
/* 11/16/2008 MH Read one byte from real Efuse. */
-u8
-rtw_efuse_one_byte_read(
-struct adapter *padapter,
-u16 addr,
-u8 *data)
+u8 rtw_efuse_one_byte_read(struct adapter *padapter, u16 addr, u8 *data)
{
u32 tmpidx = 0;
u8 bResult;
--
2.34.1
^ permalink raw reply related
* Re: [PATCH v2 0/3] staging: cleanup of sdio_intf.c
From: Dan Carpenter @ 2026-05-22 13:02 UTC (permalink / raw)
To: Manuel Ebner
Cc: Greg Kroah-Hartman, Omer El Idrissi, open list:STAGING SUBSYSTEM,
open list
In-Reply-To: <20260522114317.189368-4-manuelebner@mailbox.org>
On Fri, May 22, 2026 at 01:43:20PM +0200, Manuel Ebner wrote:
> did i overdo the split up?
>
The split is fine. The subsystem prefix needs to be improved. The
capitalization and puncuation in the commit message could be improved
as well.
regards,
dan carpenter
^ permalink raw reply
* [PATCH v7 0/3] staging: rtl8723bs: fix several style issues in hal/sdio_halinit.c
From: artur.ugnivenko @ 2026-05-22 13:19 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel, linux-staging, ahmet, error27, Artur Ugnivenko
From: Artur Ugnivenko <artur.ugnivenko@gmx.de>
Fix the following checkpatch warnings in hal/sdio_halinit.c:
- lines longer than 100 chars
- inconsistent brackets around else statements
- lines ending in parentheses
Changes in v7:
- Remove whitespace patch.
- Add transmit_queues struct to improve style of
_InitNormalChipRegPriority
- Add changelog to individual patches.
Changes in v6: Make the patch series apply to gregkh/staging-testing.
Changes in v5: Added the entire changelog to the cover letter.
Changes in v4: Fixed the long line checkpatch warning in patch 2.
Changes in v3: Split the patch into multiple patches.
Changes in v2: Make the patch apply to gregkh/staging-testing.
Artur Ugnivenko (3):
staging: rtl8723bs: shorten long lines in hal/sdio_halinit.c
staging: rtl8723bs: fix inconsistent braces in hal/sdio_halinit.c
staging: rtl8723bs: fix lines ending in parentheses in
hal/sdio_halinit.c
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 168 +++++++++++-------
drivers/staging/rtl8723bs/include/drv_types.h | 9 +
2 files changed, 109 insertions(+), 68 deletions(-)
--
2.54.0
^ permalink raw reply
* [PATCH v7 1/3] staging: rtl8723bs: shorten long lines in hal/sdio_halinit.c
From: artur.ugnivenko @ 2026-05-22 13:19 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel, linux-staging, ahmet, error27, Artur Ugnivenko
In-Reply-To: <20260522132001.4771-1-artur.ugnivenko@gmx.de>
From: Artur Ugnivenko <artur.ugnivenko@gmx.de>
Fix checkpatch warnings on lines above 100 chars in length by splitting
long function calls and long comments into multiple lines.
Signed-off-by: Artur Ugnivenko <artur.ugnivenko@gmx.de>
---
Changes in v7: Add changelog.
Changes in v6: Make the patch apply to gregkh/staging-testing.
Changes in v5: No changes in this patch.
Changes in v4: No changes in this patch.
Changes in v3: Split the patch into multiple patches.
Changes in v2: Make the patch apply to gregkh/staging-testing.
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 52 ++++++++++++++++----
1 file changed, 42 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index ed9b8fb07fec..43f9c45967f4 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
@@ -27,7 +27,11 @@ static u8 CardEnable(struct adapter *padapter)
/* unlock ISO/CLK/Power control register */
rtw_write8(padapter, REG_RSV_CTRL, 0x0);
- ret = HalPwrSeqCmdParsing(padapter, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, PWR_INTF_SDIO_MSK, rtl8723B_card_enable_flow);
+ ret = HalPwrSeqCmdParsing(padapter,
+ PWR_CUT_ALL_MSK,
+ PWR_FAB_ALL_MSK,
+ PWR_INTF_SDIO_MSK,
+ rtl8723B_card_enable_flow);
if (ret == _SUCCESS) {
bMacPwrCtrlOn = true;
rtw_hal_set_hwreg(padapter, HW_VAR_APFM_ON_MAC, &bMacPwrCtrlOn);
@@ -104,7 +108,11 @@ u8 _InitPowerOn_8723BS(struct adapter *padapter)
}
/* Tx Page FIFO threshold */
-static void _init_available_page_threshold(struct adapter *padapter, u8 numHQ, u8 numNQ, u8 numLQ, u8 numPubQ)
+static void _init_available_page_threshold(struct adapter *padapter,
+ u8 numHQ,
+ u8 numNQ,
+ u8 numLQ,
+ u8 numPubQ)
{
u16 HQ_threshold, NQ_threshold, LQ_threshold;
@@ -781,7 +789,11 @@ u32 rtl8723bs_hal_init(struct adapter *padapter)
restore_iqk_rst = pwrpriv->bips_processing;
b2Ant = pHalData->EEPROMBluetoothAntNum == Ant_x2;
- PHY_IQCalibrate_8723B(padapter, false, restore_iqk_rst, b2Ant, pHalData->ant_path);
+ PHY_IQCalibrate_8723B(padapter,
+ false,
+ restore_iqk_rst,
+ b2Ant,
+ pHalData->ant_path);
pHalData->odmpriv.RFCalibrateInfo.bIQKInitialized = true;
hal_btcoex_IQKNotify(padapter, false);
@@ -812,7 +824,11 @@ static void CardDisableRTL8723BSdio(struct adapter *padapter)
u8 bMacPwrCtrlOn;
/* Run LPS WL RFOFF flow */
- HalPwrSeqCmdParsing(padapter, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, PWR_INTF_SDIO_MSK, rtl8723B_enter_lps_flow);
+ HalPwrSeqCmdParsing(padapter,
+ PWR_CUT_ALL_MSK,
+ PWR_FAB_ALL_MSK,
+ PWR_INTF_SDIO_MSK,
+ rtl8723B_enter_lps_flow);
/* ==== Reset digital sequence ====== */
@@ -841,7 +857,11 @@ static void CardDisableRTL8723BSdio(struct adapter *padapter)
bMacPwrCtrlOn = false; /* Disable CMD53 R/W */
rtw_hal_set_hwreg(padapter, HW_VAR_APFM_ON_MAC, &bMacPwrCtrlOn);
- HalPwrSeqCmdParsing(padapter, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, PWR_INTF_SDIO_MSK, rtl8723B_card_disable_flow);
+ HalPwrSeqCmdParsing(padapter,
+ PWR_CUT_ALL_MSK,
+ PWR_FAB_ALL_MSK,
+ PWR_INTF_SDIO_MSK,
+ rtl8723B_card_disable_flow);
}
u32 rtl8723bs_hal_deinit(struct adapter *padapter)
@@ -853,7 +873,10 @@ u32 rtl8723bs_hal_deinit(struct adapter *padapter)
u8 val8 = 0;
rtl8723b_set_FwPwrModeInIPS_cmd(padapter, 0x3);
- /* poll 0x1cc to make sure H2C command already finished by FW; MAC_0x1cc = 0 means H2C done by FW. */
+ /*
+ * poll 0x1cc to make sure H2C command already finished by FW;
+ * MAC_0x1cc = 0 means H2C done by FW.
+ */
do {
val8 = rtw_read8(padapter, REG_HMETFR);
cnt++;
@@ -862,10 +885,13 @@ u32 rtl8723bs_hal_deinit(struct adapter *padapter)
/* H2C done, enter 32k */
if (val8 == 0) {
/* set rpwm to enter 32k */
- val8 = rtw_read8(padapter, SDIO_LOCAL_BASE | SDIO_REG_HRPWM1);
+ val8 = rtw_read8(padapter,
+ SDIO_LOCAL_BASE | SDIO_REG_HRPWM1);
val8 += 0x80;
val8 |= BIT(0);
- rtw_write8(padapter, SDIO_LOCAL_BASE | SDIO_REG_HRPWM1, val8);
+ rtw_write8(padapter,
+ SDIO_LOCAL_BASE | SDIO_REG_HRPWM1,
+ val8);
adapter_to_pwrctl(padapter)->tog = (val8 + 0x80) & 0x80;
cnt = val8 = 0;
do {
@@ -1063,8 +1089,14 @@ static s32 _ReadAdapterInfo8723BS(struct adapter *padapter)
_ReadPROMContent(padapter);
if (!padapter->hw_init_completed) {
- rtw_write8(padapter, 0x67, 0x00); /* for BT, Switch Ant control to BT */
- CardDisableRTL8723BSdio(padapter);/* for the power consumption issue, wifi ko module is loaded during booting, but wifi GUI is off */
+ /* for BT, Switch Ant control to BT */
+ rtw_write8(padapter, 0x67, 0x00);
+
+ /*
+ * for the power consumption issue, wifi ko module is loaded during booting,
+ * but wifi GUI is off
+ */
+ CardDisableRTL8723BSdio(padapter);
}
return _SUCCESS;
--
2.54.0
^ permalink raw reply related
* [PATCH v7 2/3] staging: rtl8723bs: fix inconsistent braces in hal/sdio_halinit.c
From: artur.ugnivenko @ 2026-05-22 13:20 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel, linux-staging, ahmet, error27, Artur Ugnivenko
In-Reply-To: <20260522132001.4771-1-artur.ugnivenko@gmx.de>
From: Artur Ugnivenko <artur.ugnivenko@gmx.de>
Fix checkpatch warnings on inconsistent braces around if/else statements
in hal/sdio_halinit.c
Signed-off-by: Artur Ugnivenko <artur.ugnivenko@gmx.de>
---
Changes in v7: Add changelog.
Changes in v6: Make the patch apply to gregkh/staging-testing.
Changes in v5: No changes in this patch.
Changes in v4: Fix long line checkpatch warning.
Changes in v3: Split the patch into multiple patches.
Changes in v2: Make patch apply to gregkh/staging-testing.
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index 43f9c45967f4..6f2aea984b30 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
@@ -36,8 +36,9 @@ static u8 CardEnable(struct adapter *padapter)
bMacPwrCtrlOn = true;
rtw_hal_set_hwreg(padapter, HW_VAR_APFM_ON_MAC, &bMacPwrCtrlOn);
}
- } else
+ } else {
ret = _SUCCESS;
+ }
return ret;
}
@@ -1011,8 +1012,9 @@ static void Hal_EfuseParseBoardType_8723BS(
pHalData->BoardType = (hwinfo[EEPROM_RF_BOARD_OPTION_8723B] & 0xE0) >> 5;
if (pHalData->BoardType == 0xFF)
pHalData->BoardType = (EEPROM_DEFAULT_BOARD_OPTION & 0xE0) >> 5;
- } else
+ } else {
pHalData->BoardType = 0;
+ }
}
static void _ReadEfuseInfo8723BS(struct adapter *padapter)
--
2.54.0
^ permalink raw reply related
* [PATCH] staging: rtl8723bs: fix coding style issues in hal_com.c
From: Oliwier Iwan @ 2026-05-22 14:11 UTC (permalink / raw)
To: linux-staging; +Cc: gregkh, straube.linux, linux-kernel, Oliwier Iwan
Fix multiple checkpatch warnings:
- Place constant on right side of comparison
- Remove space before tab in block comments
- Align '*' on each line of block comments
- Fix misaligned closing brace
Signed-off-by: Oliwier Iwan <oliwieriwan@mailbox.org>
---
drivers/staging/rtl8723bs/hal/hal_com.c | 38 ++++++++++++-------------
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8723bs/hal/hal_com.c
index 728a2171fbcb..4b4bfa80e37c 100644
--- a/drivers/staging/rtl8723bs/hal/hal_com.c
+++ b/drivers/staging/rtl8723bs/hal/hal_com.c
@@ -107,7 +107,7 @@ u8 hal_com_config_channel_plan(
pHalData->bDisableSWChannelPlan = false;
chnlPlan = def_channel_plan;
- if (0xFF == hw_channel_plan)
+ if (hw_channel_plan == 0xFF)
auto_load_fail = true;
if (!auto_load_fail) {
@@ -362,7 +362,7 @@ static void _TwoOutPipeMapping(struct adapter *padapter, bool bWIFICfg)
if (bWIFICfg) { /* WMM */
- /* BK, BE, VI, VO, BCN, CMD, MGT, HIGH, HCCA */
+ /* BK, BE, VI, VO, BCN, CMD, MGT, HIGH, HCCA */
/* 0, 1, 0, 1, 0, 0, 0, 0, 0 }; */
/* 0:ep_0 num, 1:ep_1 num */
@@ -403,7 +403,7 @@ static void _ThreeOutPipeMapping(struct adapter *padapter, bool bWIFICfg)
if (bWIFICfg) { /* for WMM */
- /* BK, BE, VI, VO, BCN, CMD, MGT, HIGH, HCCA */
+ /* BK, BE, VI, VO, BCN, CMD, MGT, HIGH, HCCA */
/* 1, 2, 1, 0, 0, 0, 0, 0, 0 }; */
/* 0:H, 1:N, 2:L */
@@ -420,7 +420,7 @@ static void _ThreeOutPipeMapping(struct adapter *padapter, bool bWIFICfg)
} else { /* typical setting */
- /* BK, BE, VI, VO, BCN, CMD, MGT, HIGH, HCCA */
+ /* BK, BE, VI, VO, BCN, CMD, MGT, HIGH, HCCA */
/* 2, 2, 1, 0, 0, 0, 0, 0, 0 }; */
/* 0:H, 1:N, 2:L */
@@ -478,10 +478,10 @@ void rtw_init_hal_com_default_value(struct adapter *Adapter)
}
/*
-* C2H event format:
-* Field TRIGGER CONTENT CMD_SEQ CMD_LEN CMD_ID
-* BITS [127:120] [119:16] [15:8] [7:4] [3:0]
-*/
+ * C2H event format:
+ * Field TRIGGER CONTENT CMD_SEQ CMD_LEN CMD_ID
+ * BITS [127:120] [119:16] [15:8] [7:4] [3:0]
+ */
void c2h_evt_clear(struct adapter *adapter)
{
@@ -489,10 +489,10 @@ void c2h_evt_clear(struct adapter *adapter)
}
/*
-* C2H event format:
-* Field TRIGGER CMD_LEN CONTENT CMD_SEQ CMD_ID
-* BITS [127:120] [119:112] [111:16] [15:8] [7:0]
-*/
+ * C2H event format:
+ * Field TRIGGER CMD_LEN CONTENT CMD_SEQ CMD_ID
+ * BITS [127:120] [119:112] [111:16] [15:8] [7:0]
+ */
s32 c2h_evt_read_88xx(struct adapter *adapter, u8 *buf)
{
s32 ret = _FAIL;
@@ -526,9 +526,9 @@ s32 c2h_evt_read_88xx(struct adapter *adapter, u8 *buf)
clear_evt:
/*
- * Clear event to notify FW we have read the command.
- * If this field isn't clear, the FW won't update the next command message.
- */
+ * Clear event to notify FW we have read the command.
+ * If this field isn't clear, the FW won't update the next command message.
+ */
c2h_evt_clear(adapter);
exit:
return ret;
@@ -625,9 +625,9 @@ void SetHwReg(struct adapter *adapter, u8 variable, u8 *val)
break;
case HW_VAR_DM_FUNC_CLR:
/*
- * input is already a mask to clear function
- * don't invert it again! George, Lucas@20130513
- */
+ * input is already a mask to clear function
+ * don't invert it again! George, Lucas@20130513
+ */
odm->SupportAbility &= *((u32 *)val);
break;
case HW_VAR_AMPDU_MIN_SPACE:
@@ -736,7 +736,7 @@ void SetHalODMVar(
ODM_CmnInfoPtrArrayHook(podmpriv, ODM_CMNINFO_STA_STATUS, psta->mac_id, NULL);
/* spin_unlock_bh(&pHalData->odm_stainfo_lock); */
- }
+ }
}
break;
case HAL_ODM_P2P_STATE:
--
2.54.0
^ permalink raw reply related
* [PATCH v7 3/3] staging: rtl8723bs: fix lines ending in parentheses in hal/sdio_halinit.c
From: artur.ugnivenko @ 2026-05-22 14:27 UTC (permalink / raw)
To: gregkh; +Cc: ahmet, error27, linux-kernel, linux-staging, Artur Ugnivenko
In-Reply-To: <20260522132001.4771-1-artur.ugnivenko@gmx.de>
From: Artur Ugnivenko <artur.ugnivenko@gmx.de>
Fix checkpatch warnings on lines that end in patentheses in
hal/sdio_halinit.c.
In _InitNormalChipRegPriority specifically pack all of the
queues into a struct, to pass that as one argument instead of
six individual values, so that those lines can be shortened and
not end in parentheses.
Signed-off-by: Artur Ugnivenko <artur.ugnivenko@gmx.de>
---
Changes in v7:
- Add changelog.
- Add transmit_queues struct in include/drv_types.h to improve
style of _InitNormalChipRegPriority
Changes in v6: Make the patch apply to gregkh/staging-testing.
Changes in v5: No changes in this patch.
Changes in v4: No changes in this patch.
Changes in v3: Split the patch into multiple patches.
Changes in v2: Make patch apply to gregkh/staging-testing.
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 110 +++++++++---------
drivers/staging/rtl8723bs/include/drv_types.h | 9 ++
2 files changed, 63 insertions(+), 56 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index 6f2aea984b30..81cd5b315bb7 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
@@ -188,25 +188,18 @@ static void _InitTxBufferBoundary(struct adapter *padapter)
rtw_write8(padapter, REG_TDECTRL + 1, txpktbuf_bndy);
}
-static void _InitNormalChipRegPriority(
- struct adapter *Adapter,
- u16 beQ,
- u16 bkQ,
- u16 viQ,
- u16 voQ,
- u16 mgtQ,
- u16 hiQ
-)
+static void _InitNormalChipRegPriority(struct adapter *Adapter,
+ struct transmit_queues queues)
{
u16 value16 = (rtw_read16(Adapter, REG_TRXDMA_CTRL) & 0x7);
value16 |=
- _TXDMA_BEQ_MAP(beQ) |
- _TXDMA_BKQ_MAP(bkQ) |
- _TXDMA_VIQ_MAP(viQ) |
- _TXDMA_VOQ_MAP(voQ) |
- _TXDMA_MGQ_MAP(mgtQ) |
- _TXDMA_HIQ_MAP(hiQ);
+ _TXDMA_BEQ_MAP(queues.beQ) |
+ _TXDMA_BKQ_MAP(queues.bkQ) |
+ _TXDMA_VIQ_MAP(queues.viQ) |
+ _TXDMA_VOQ_MAP(queues.voQ) |
+ _TXDMA_MGQ_MAP(queues.mgtQ) |
+ _TXDMA_HIQ_MAP(queues.hiQ);
rtw_write16(Adapter, REG_TRXDMA_CTRL, value16);
}
@@ -231,17 +224,23 @@ static void _InitNormalChipOneOutEpPriority(struct adapter *Adapter)
break;
}
- _InitNormalChipRegPriority(
- Adapter, value, value, value, value, value, value
- );
+ struct transmit_queues queues = {
+ .beQ = value,
+ .bkQ = value,
+ .viQ = value,
+ .voQ = value,
+ .mgtQ = value,
+ .hiQ = value,
+ };
+ _InitNormalChipRegPriority(Adapter, queues);
}
static void _InitNormalChipTwoOutEpPriority(struct adapter *Adapter)
{
struct hal_com_data *pHalData = GET_HAL_DATA(Adapter);
struct registry_priv *pregistrypriv = &Adapter->registrypriv;
- u16 beQ, bkQ, viQ, voQ, mgtQ, hiQ;
+ struct transmit_queues queues;
u16 valueHi = 0;
u16 valueLow = 0;
@@ -264,49 +263,48 @@ static void _InitNormalChipTwoOutEpPriority(struct adapter *Adapter)
}
if (!pregistrypriv->wifi_spec) {
- beQ = valueLow;
- bkQ = valueLow;
- viQ = valueHi;
- voQ = valueHi;
- mgtQ = valueHi;
- hiQ = valueHi;
+ queues.beQ = valueLow;
+ queues.bkQ = valueLow;
+ queues.viQ = valueHi;
+ queues.voQ = valueHi;
+ queues.mgtQ = valueHi;
+ queues.hiQ = valueHi;
} else {
/* for WMM , CONFIG_OUT_EP_WIFI_MODE */
- beQ = valueLow;
- bkQ = valueHi;
- viQ = valueHi;
- voQ = valueLow;
- mgtQ = valueHi;
- hiQ = valueHi;
+ queues.beQ = valueLow;
+ queues.bkQ = valueHi;
+ queues.viQ = valueHi;
+ queues.voQ = valueLow;
+ queues.mgtQ = valueHi;
+ queues.hiQ = valueHi;
}
- _InitNormalChipRegPriority(Adapter, beQ, bkQ, viQ, voQ, mgtQ, hiQ);
-
+ _InitNormalChipRegPriority(Adapter, queues);
}
static void _InitNormalChipThreeOutEpPriority(struct adapter *padapter)
{
struct registry_priv *pregistrypriv = &padapter->registrypriv;
- u16 beQ, bkQ, viQ, voQ, mgtQ, hiQ;
+ struct transmit_queues queues;
if (!pregistrypriv->wifi_spec) {
/* typical setting */
- beQ = QUEUE_LOW;
- bkQ = QUEUE_LOW;
- viQ = QUEUE_NORMAL;
- voQ = QUEUE_HIGH;
- mgtQ = QUEUE_HIGH;
- hiQ = QUEUE_HIGH;
+ queues.beQ = QUEUE_LOW;
+ queues.bkQ = QUEUE_LOW;
+ queues.viQ = QUEUE_NORMAL;
+ queues.voQ = QUEUE_HIGH;
+ queues.mgtQ = QUEUE_HIGH;
+ queues.hiQ = QUEUE_HIGH;
} else {
/* for WMM */
- beQ = QUEUE_LOW;
- bkQ = QUEUE_NORMAL;
- viQ = QUEUE_NORMAL;
- voQ = QUEUE_HIGH;
- mgtQ = QUEUE_HIGH;
- hiQ = QUEUE_HIGH;
+ queues.beQ = QUEUE_LOW;
+ queues.bkQ = QUEUE_NORMAL;
+ queues.viQ = QUEUE_NORMAL;
+ queues.voQ = QUEUE_HIGH;
+ queues.mgtQ = QUEUE_HIGH;
+ queues.hiQ = QUEUE_HIGH;
}
- _InitNormalChipRegPriority(padapter, beQ, bkQ, viQ, voQ, mgtQ, hiQ);
+ _InitNormalChipRegPriority(padapter, queues);
}
static void _InitQueuePriority(struct adapter *Adapter)
@@ -988,9 +986,9 @@ static void _ReadRFType(struct adapter *Adapter)
pHalData->rf_chip = RF_6052;
}
-static void Hal_EfuseParseMACAddr_8723BS(
- struct adapter *padapter, u8 *hwinfo, bool AutoLoadFail
-)
+static void Hal_EfuseParseMACAddr_8723BS(struct adapter *padapter,
+ u8 *hwinfo,
+ bool AutoLoadFail)
{
struct eeprom_priv *pEEPROM = GET_EEPROM_EFUSE_PRIV(padapter);
@@ -1002,9 +1000,9 @@ static void Hal_EfuseParseMACAddr_8723BS(
}
}
-static void Hal_EfuseParseBoardType_8723BS(
- struct adapter *padapter, u8 *hwinfo, bool AutoLoadFail
-)
+static void Hal_EfuseParseBoardType_8723BS(struct adapter *padapter,
+ u8 *hwinfo,
+ bool AutoLoadFail)
{
struct hal_com_data *pHalData = GET_HAL_DATA(padapter);
@@ -1192,9 +1190,9 @@ void SetHwRegWithBuf8723B(struct adapter *padapter, u8 variable, u8 *pbuf, int l
/* Description: */
/* Query setting of specified variable. */
/* */
-u8 GetHalDefVar8723BSDIO(
- struct adapter *Adapter, enum hal_def_variable eVariable, void *pValue
-)
+u8 GetHalDefVar8723BSDIO(struct adapter *Adapter,
+ enum hal_def_variable eVariable,
+ void *pValue)
{
u8 bResult = _SUCCESS;
diff --git a/drivers/staging/rtl8723bs/include/drv_types.h b/drivers/staging/rtl8723bs/include/drv_types.h
index 552d0c5fa47f..82dbe5553811 100644
--- a/drivers/staging/rtl8723bs/include/drv_types.h
+++ b/drivers/staging/rtl8723bs/include/drv_types.h
@@ -373,6 +373,15 @@ struct adapter {
unsigned char in_cta_test;
};
+struct transmit_queues {
+ u16 beQ;
+ u16 bkQ;
+ u16 viQ;
+ u16 voQ;
+ u16 mgtQ;
+ u16 hiQ;
+};
+
#define adapter_to_dvobj(adapter) (adapter->dvobj)
#define adapter_to_pwrctl(adapter) (dvobj_to_pwrctl(adapter->dvobj))
#define adapter_wdev_data(adapter) (&((adapter)->wdev_data))
--
2.54.0
^ permalink raw reply related
* Re: [PATCH v2 0/3] staging: cleanup of sdio_intf.c
From: Manuel Ebner @ 2026-05-22 15:33 UTC (permalink / raw)
To: Dan Carpenter
Cc: Greg Kroah-Hartman, Omer El Idrissi, open list:STAGING SUBSYSTEM,
open list
In-Reply-To: <ahBT3r8ob5Zbq_Fc@stanley.mountain>
On Fri, 2026-05-22 at 16:02 +0300, Dan Carpenter wrote:
> On Fri, May 22, 2026 at 01:43:20PM +0200, Manuel Ebner wrote:
> > did i overdo the split up?
> >
>
> The split is fine. The subsystem prefix needs to be improved.
Is it wireless? If it isn't how can I find the subsystems for my patches.
> The
> capitalization and puncuation in the commit message could be improved
> as well.
I will do that.
Thanks
Manuel Ebner
>
> regards,
> dan carpenter
^ permalink raw reply
* Re: [PATCH v4 5/6] media: staging: ipu3-imgu: Add range check for imgu_css_cfg_acc_stripe
From: Sakari Ailus @ 2026-05-22 16:49 UTC (permalink / raw)
To: Ricardo Ribalda
Cc: Mauro Carvalho Chehab, Laurent Pinchart, Hans Verkuil, Nas Chung,
Jackson Lee, Greg Kroah-Hartman, Keke Li, Yong Zhi, Jacopo Mondi,
linux-media, linux-kernel, linux-staging, Mauro Carvalho Chehab,
stable
In-Reply-To: <20260507-smatch-7-1-v4-5-cc195f142167@chromium.org>
Hi Ricardo,
Thanks for the patch.
On Thu, May 07, 2026 at 08:58:10PM +0000, Ricardo Ribalda wrote:
> If the driver's stripe information is invalid it can result in an integer
> underflow. Add a range check to avoid this kind of error.
>
> This patch fixes the following smatch error:
> drivers/staging/media/ipu3/ipu3-css-params.c:1792 imgu_css_cfg_acc_stripe() warn: 'acc->stripe.bds_out_stripes[0]->width - 2 * f' 4294967168 can't fit into 65535 'acc->stripe.bds_out_stripes[1]->offset'
>
> Cc: stable@vger.kernel.org
> Fixes: e11110a5b744 ("media: staging/intel-ipu3: css: Compute and program ccs")
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> ---
> drivers/staging/media/ipu3/ipu3-css-params.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/ipu3/ipu3-css-params.c b/drivers/staging/media/ipu3/ipu3-css-params.c
> index 2c48d57a3180..92cce31e35c5 100644
> --- a/drivers/staging/media/ipu3/ipu3-css-params.c
> +++ b/drivers/staging/media/ipu3/ipu3-css-params.c
> @@ -1770,6 +1770,8 @@ static int imgu_css_cfg_acc_stripe(struct imgu_css *css, unsigned int pipe,
> acc->stripe.bds_out_stripes[0].width =
> ALIGN(css_pipe->rect[IPU3_CSS_RECT_BDS].width, f);
> } else {
> + u32 offset;
> +
> /* Image processing is divided into two stripes */
> acc->stripe.bds_out_stripes[0].width =
> acc->stripe.bds_out_stripes[1].width =
> @@ -1788,8 +1790,10 @@ static int imgu_css_cfg_acc_stripe(struct imgu_css *css, unsigned int pipe,
> acc->stripe.bds_out_stripes[1].width += f;
> }
> /* Overlap between stripes is IPU3_UAPI_ISP_VEC_ELEMS * 4 */
> - acc->stripe.bds_out_stripes[1].offset =
> - acc->stripe.bds_out_stripes[0].width - 2 * f;
> + offset = acc->stripe.bds_out_stripes[0].width - 2 * f;
> + if (offset > 65535)
> + return -EINVAL;
acc->stripe.bds_out_stripes[0].width comes from the sub-device's main
source pad, and its driver-enforced upper limit 4480. The lower limit,
though, appears to be 32, which is obviously too low.
I can post a patch for this but I'm not sure smatch can figure this out...
but let's try anyway. The driver would indeed benefit of a cleanup in this
area.
> + acc->stripe.bds_out_stripes[1].offset = offset;
> }
>
> acc->stripe.effective_stripes[0].height =
>
--
Regards,
Sakari Ailus
^ permalink raw reply
* Re: [PATCH v2 0/3] staging: cleanup of sdio_intf.c
From: Dan Carpenter @ 2026-05-22 16:53 UTC (permalink / raw)
To: Manuel Ebner
Cc: Greg Kroah-Hartman, Omer El Idrissi, open list:STAGING SUBSYSTEM,
open list
In-Reply-To: <9eafd3db22791e0bdba31c866a802a31e6f1a012.camel@mailbox.org>
On Fri, May 22, 2026 at 05:33:53PM +0200, Manuel Ebner wrote:
> On Fri, 2026-05-22 at 16:02 +0300, Dan Carpenter wrote:
> > On Fri, May 22, 2026 at 01:43:20PM +0200, Manuel Ebner wrote:
> > > did i overdo the split up?
> > >
> >
> > The split is fine. The subsystem prefix needs to be improved.
>
> Is it wireless? If it isn't how can I find the subsystems for my patches.
>
git log --oneline drivers/staging/rtl8723bs/os_dep/sdio_intf.c
Use what everyone else uses:
Subject: staging: rtl8723bs: cleanup of sdio_intf.c
regards,
dan carpenter
^ permalink raw reply
* [PATCH 0/2] staging: rtl8723bs: remove dead function and clean up table
From: Andrei Khomenkov @ 2026-05-22 19:02 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-staging
Remove the dead rtw_atimdone_event_callback() function since it is
unused and clean up the wlanevents table.
Andrei Khomenkov (2):
staging: rtl8723bs: remove dead rtw_atimdone_event_callback()
staging: rtl8723bs: clean up wlanevents table in rtw_mlme_ext.c
drivers/staging/rtl8723bs/core/rtw_mlme.c | 5 --
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 54 +++++++++----------
drivers/staging/rtl8723bs/include/rtw_mlme.h | 1 -
3 files changed, 26 insertions(+), 34 deletions(-)
--
2.47.3
^ permalink raw reply
* [PATCH 2/2] staging: rtl8723bs: clean up wlanevents table in rtw_mlme_ext.c
From: Andrei Khomenkov @ 2026-05-22 19:02 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-staging
In-Reply-To: <20260522190256.49830-1-khomenkov@mailbox.org>
Clean up the wlanevents table by removing redundant
ampersands, adding all index comments and aligning them.
Signed-off-by: Andrei Khomenkov <khomenkov@mailbox.org>
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 54 +++++++++----------
1 file changed, 26 insertions(+), 28 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
index c56082cd5264..eaedff8ae2e2 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
@@ -5605,34 +5605,32 @@ u8 set_tx_beacon_cmd(struct adapter *padapter)
}
static struct fwevent wlanevents[] = {
- {0, rtw_dummy_event_callback}, /*0*/
- {0, NULL},
- {0, NULL},
- {0, NULL},
- {0, NULL},
- {0, NULL},
- {0, NULL},
- {0, NULL},
- {0, &rtw_survey_event_callback}, /*8*/
- {sizeof(struct surveydone_event), &rtw_surveydone_event_callback}, /*9*/
-
- {0, &rtw_joinbss_event_callback}, /*10*/
- {sizeof(struct stassoc_event), &rtw_stassoc_event_callback},
- {sizeof(struct stadel_event), &rtw_stadel_event_callback},
- {0, rtw_dummy_event_callback},
- {0, rtw_dummy_event_callback},
- {0, NULL}, /*15*/
- {0, NULL},
- {0, NULL},
- {0, NULL},
- {0, rtw_fwdbg_event_callback},
- {0, NULL}, /*20*/
- {0, NULL},
- {0, NULL},
- {0, &rtw_cpwm_event_callback},
- {0, NULL},
- {0, &rtw_wmm_event_callback},
-
+ {0, rtw_dummy_event_callback}, /* 0 */
+ {0, NULL}, /* 1 */
+ {0, NULL}, /* 2 */
+ {0, NULL}, /* 3 */
+ {0, NULL}, /* 4 */
+ {0, NULL}, /* 5 */
+ {0, NULL}, /* 6 */
+ {0, NULL}, /* 7 */
+ {0, rtw_survey_event_callback}, /* 8 */
+ {sizeof(struct surveydone_event), rtw_surveydone_event_callback}, /* 9 */
+ {0, rtw_joinbss_event_callback}, /* 10 */
+ {sizeof(struct stassoc_event), rtw_stassoc_event_callback}, /* 11 */
+ {sizeof(struct stadel_event), rtw_stadel_event_callback}, /* 12 */
+ {0, rtw_dummy_event_callback}, /* 13 */
+ {0, rtw_dummy_event_callback}, /* 14 */
+ {0, NULL}, /* 15 */
+ {0, NULL}, /* 16 */
+ {0, NULL}, /* 17 */
+ {0, NULL}, /* 18 */
+ {0, rtw_fwdbg_event_callback}, /* 19 */
+ {0, NULL}, /* 20 */
+ {0, NULL}, /* 21 */
+ {0, NULL}, /* 22 */
+ {0, rtw_cpwm_event_callback}, /* 23 */
+ {0, NULL}, /* 24 */
+ {0, rtw_wmm_event_callback}, /* 25 */
};
u8 mlme_evt_hdl(struct adapter *padapter, unsigned char *pbuf)
--
2.47.3
^ permalink raw reply related
* [PATCH 1/2] staging: rtl8723bs: remove dead rtw_atimdone_event_callback()
From: Andrei Khomenkov @ 2026-05-22 19:02 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-staging
In-Reply-To: <20260522190256.49830-1-khomenkov@mailbox.org>
Remove the dead rtw_atimdone_event_callback() function since it is
unused anywhere in the driver. In the wlanevents table, replace it
with rtw_dummy_event_callback() to avoid an index shift.
Signed-off-by: Andrei Khomenkov <khomenkov@mailbox.org>
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 5 -----
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 2 +-
drivers/staging/rtl8723bs/include/rtw_mlme.h | 1 -
3 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index 4fb74729180f..6d43948ffe40 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
@@ -624,11 +624,6 @@ static bool rtw_is_desired_network(struct adapter *adapter, struct wlan_network
return bselected;
}
-/* TODO: Perry : For Power Management */
-void rtw_atimdone_event_callback(struct adapter *adapter, u8 *pbuf)
-{
-}
-
void rtw_survey_event_callback(struct adapter *adapter, u8 *pbuf)
{
u32 len;
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
index a86d6f97cf02..c56082cd5264 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
@@ -5619,7 +5619,7 @@ static struct fwevent wlanevents[] = {
{0, &rtw_joinbss_event_callback}, /*10*/
{sizeof(struct stassoc_event), &rtw_stassoc_event_callback},
{sizeof(struct stadel_event), &rtw_stadel_event_callback},
- {0, &rtw_atimdone_event_callback},
+ {0, rtw_dummy_event_callback},
{0, rtw_dummy_event_callback},
{0, NULL}, /*15*/
{0, NULL},
diff --git a/drivers/staging/rtl8723bs/include/rtw_mlme.h b/drivers/staging/rtl8723bs/include/rtw_mlme.h
index 8cc96164e1cf..e2fd899d6579 100644
--- a/drivers/staging/rtl8723bs/include/rtw_mlme.h
+++ b/drivers/staging/rtl8723bs/include/rtw_mlme.h
@@ -258,7 +258,6 @@ extern void rtw_surveydone_event_callback(struct adapter *adapter, u8 *pbuf);
extern void rtw_joinbss_event_callback(struct adapter *adapter, u8 *pbuf);
extern void rtw_stassoc_event_callback(struct adapter *adapter, u8 *pbuf);
extern void rtw_stadel_event_callback(struct adapter *adapter, u8 *pbuf);
-extern void rtw_atimdone_event_callback(struct adapter *adapter, u8 *pbuf);
extern void rtw_cpwm_event_callback(struct adapter *adapter, u8 *pbuf);
extern void rtw_wmm_event_callback(struct adapter *padapter, u8 *pbuf);
--
2.47.3
^ permalink raw reply related
* Re: [PATCH 14/16] media: sun6i-isp: Use V4L2 subdev active state
From: arash golgol @ 2026-05-23 3:15 UTC (permalink / raw)
To: Paul Kocialkowski
Cc: linux-media, linux-arm-kernel, linux-sunxi, linux-kernel,
linux-staging, Mauro Carvalho Chehab, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Greg Kroah-Hartman,
Laurent Pinchart, Nicolas Dufresne
In-Reply-To: <ahA61YIGM4Bqipu7@collins>
Hi Paul,
On Fri, May 22, 2026 at 2:45 PM Paul Kocialkowski <paulk@sys-base.io> wrote:
>
> Hi Arash,
>
> Le Thu 21 May 26, 12:53, arash golgol a écrit :
> > I used LicheePi Zero Dock (V3s) with the following pipeline as test setup.
> >
> > ov5647 -> sun6i-mipi-csi2 -> sun6i-csi-bridge -> sun6i-isp-proc ->
> > sun6i-isp-capture
> >
> > I verified TRY and ACTIVE state handling, including changing TRY
> > formats without affecting ACTIVE state. Format propagation from the
> > sink (csi) pad to the source pad was also tested.
> >
> > I also tested streaming with the sensor test pattern enabled and
> > verified the captured output was correct.
> >
> > Tested-by: Arash Golgol <arash.golgol@gmail.com>
>
> Thanks a lot for testing this! Did you test just this patch or the other
> ones (especially sun6i-csi format enumeration) as well?
>
Happy to help.
I only tested patch 14 for now, but I plan to test the other patches
as well when I get some more time, especially the sun6i-csi changes.
> Also if you have an opinion on the code itself feel free to drop a
> Reviewed-by tag, a lot of this work is very similar to what you did for
> sun6i-csi and other drivers.
>
From a code perspective, the changes look good to me.
Reviewed-by: Arash Golgol <arash.golgol@gmail.com>
--
Regards,
Arash Golgol
^ permalink raw reply
* Re: [PATCH v2 2/3] staging: cleanup whitespace of sdio_intf.c
From: Greg KH @ 2026-05-23 4:17 UTC (permalink / raw)
To: Manuel Ebner; +Cc: linux-kernel, linux-staging, omer.e.idrissi
In-Reply-To: <20260522115701.190482-2-manuelebner@mailbox.org>
On Fri, May 22, 2026 at 01:57:02PM +0200, Manuel Ebner wrote:
> remove empty lines, add lines where appropriate
> reformat function declaration
That is multiple different things, which of course need multiple
different patches.
thanks,
greg k-h
^ permalink raw reply
* Re: [PATCH] staging: rtl8723bs: fix coding style issues in hal_com.c
From: Greg KH @ 2026-05-23 4:18 UTC (permalink / raw)
To: Oliwier Iwan; +Cc: linux-staging, straube.linux, linux-kernel
In-Reply-To: <20260522141130.169249-1-oliwieriwan@mailbox.org>
On Fri, May 22, 2026 at 03:11:30PM +0100, Oliwier Iwan wrote:
> Fix multiple checkpatch warnings:
> - Place constant on right side of comparison
> - Remove space before tab in block comments
> - Align '*' on each line of block comments
> - Fix misaligned closing brace
>
> Signed-off-by: Oliwier Iwan <oliwieriwan@mailbox.org>
> ---
> drivers/staging/rtl8723bs/hal/hal_com.c | 38 ++++++++++++-------------
> 1 file changed, 19 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8723bs/hal/hal_com.c
> index 728a2171fbcb..4b4bfa80e37c 100644
> --- a/drivers/staging/rtl8723bs/hal/hal_com.c
> +++ b/drivers/staging/rtl8723bs/hal/hal_com.c
> @@ -107,7 +107,7 @@ u8 hal_com_config_channel_plan(
> pHalData->bDisableSWChannelPlan = false;
> chnlPlan = def_channel_plan;
>
> - if (0xFF == hw_channel_plan)
> + if (hw_channel_plan == 0xFF)
> auto_load_fail = true;
>
> if (!auto_load_fail) {
> @@ -362,7 +362,7 @@ static void _TwoOutPipeMapping(struct adapter *padapter, bool bWIFICfg)
>
> if (bWIFICfg) { /* WMM */
>
> - /* BK, BE, VI, VO, BCN, CMD, MGT, HIGH, HCCA */
> + /* BK, BE, VI, VO, BCN, CMD, MGT, HIGH, HCCA */
> /* 0, 1, 0, 1, 0, 0, 0, 0, 0 }; */
> /* 0:ep_0 num, 1:ep_1 num */
>
> @@ -403,7 +403,7 @@ static void _ThreeOutPipeMapping(struct adapter *padapter, bool bWIFICfg)
>
> if (bWIFICfg) { /* for WMM */
>
> - /* BK, BE, VI, VO, BCN, CMD, MGT, HIGH, HCCA */
> + /* BK, BE, VI, VO, BCN, CMD, MGT, HIGH, HCCA */
> /* 1, 2, 1, 0, 0, 0, 0, 0, 0 }; */
> /* 0:H, 1:N, 2:L */
>
> @@ -420,7 +420,7 @@ static void _ThreeOutPipeMapping(struct adapter *padapter, bool bWIFICfg)
> } else { /* typical setting */
>
>
> - /* BK, BE, VI, VO, BCN, CMD, MGT, HIGH, HCCA */
> + /* BK, BE, VI, VO, BCN, CMD, MGT, HIGH, HCCA */
> /* 2, 2, 1, 0, 0, 0, 0, 0, 0 }; */
> /* 0:H, 1:N, 2:L */
>
> @@ -478,10 +478,10 @@ void rtw_init_hal_com_default_value(struct adapter *Adapter)
> }
>
> /*
> -* C2H event format:
> -* Field TRIGGER CONTENT CMD_SEQ CMD_LEN CMD_ID
> -* BITS [127:120] [119:16] [15:8] [7:4] [3:0]
> -*/
> + * C2H event format:
> + * Field TRIGGER CONTENT CMD_SEQ CMD_LEN CMD_ID
> + * BITS [127:120] [119:16] [15:8] [7:4] [3:0]
> + */
>
> void c2h_evt_clear(struct adapter *adapter)
> {
> @@ -489,10 +489,10 @@ void c2h_evt_clear(struct adapter *adapter)
> }
>
> /*
> -* C2H event format:
> -* Field TRIGGER CMD_LEN CONTENT CMD_SEQ CMD_ID
> -* BITS [127:120] [119:112] [111:16] [15:8] [7:0]
> -*/
> + * C2H event format:
> + * Field TRIGGER CMD_LEN CONTENT CMD_SEQ CMD_ID
> + * BITS [127:120] [119:112] [111:16] [15:8] [7:0]
> + */
> s32 c2h_evt_read_88xx(struct adapter *adapter, u8 *buf)
> {
> s32 ret = _FAIL;
> @@ -526,9 +526,9 @@ s32 c2h_evt_read_88xx(struct adapter *adapter, u8 *buf)
>
> clear_evt:
> /*
> - * Clear event to notify FW we have read the command.
> - * If this field isn't clear, the FW won't update the next command message.
> - */
> + * Clear event to notify FW we have read the command.
> + * If this field isn't clear, the FW won't update the next command message.
> + */
> c2h_evt_clear(adapter);
> exit:
> return ret;
> @@ -625,9 +625,9 @@ void SetHwReg(struct adapter *adapter, u8 variable, u8 *val)
> break;
> case HW_VAR_DM_FUNC_CLR:
> /*
> - * input is already a mask to clear function
> - * don't invert it again! George, Lucas@20130513
> - */
> + * input is already a mask to clear function
> + * don't invert it again! George, Lucas@20130513
> + */
> odm->SupportAbility &= *((u32 *)val);
> break;
> case HW_VAR_AMPDU_MIN_SPACE:
> @@ -736,7 +736,7 @@ void SetHalODMVar(
> ODM_CmnInfoPtrArrayHook(podmpriv, ODM_CMNINFO_STA_STATUS, psta->mac_id, NULL);
>
> /* spin_unlock_bh(&pHalData->odm_stainfo_lock); */
> - }
> + }
> }
> break;
> case HAL_ODM_P2P_STATE:
> --
> 2.54.0
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- Your patch did many different things all at once, making it difficult
to review. All Linux kernel patches need to only do one thing at a
time. If you need to do multiple things (such as clean up all coding
style issues in a file/driver), do it in a sequence of patches, each
one doing only one thing. This will make it easier to review the
patches to ensure that they are correct, and to help alleviate any
merge issues that larger patches can cause.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
^ permalink raw reply
* Re: [PATCH 16/16] media: sun6i-isp: Add support for frame size enumeration
From: arash golgol @ 2026-05-23 4:34 UTC (permalink / raw)
To: Paul Kocialkowski
Cc: linux-media, linux-arm-kernel, linux-sunxi, linux-kernel,
linux-staging, Mauro Carvalho Chehab, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Greg Kroah-Hartman,
Laurent Pinchart, Nicolas Dufresne
In-Reply-To: <20260518102451.417971-17-paulk@sys-base.io>
Hi Paul,
On Mon, May 18, 2026 at 2:02 PM Paul Kocialkowski <paulk@sys-base.io> wrote:
>
> This implements the enum_framesizes operation, which reports support for
> even sizes.
>
> Signed-off-by: Paul Kocialkowski <paulk@sys-base.io>
> ---
> .../media/sunxi/sun6i-isp/sun6i_isp_capture.c | 22 +++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_capture.c b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_capture.c
> index 372b9331bd6d..e638ec32c7cd 100644
> --- a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_capture.c
> +++ b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_capture.c
> @@ -452,6 +452,26 @@ static int sun6i_isp_capture_enum_fmt(struct file *file, void *priv,
> return 0;
> }
>
> +static int sun6i_isp_capture_enum_framesizes(struct file *file, void *fh,
> + struct v4l2_frmsizeenum *frmsize)
> +{
> + if (frmsize->index)
> + return -EINVAL;
> +
> + if (!sun6i_isp_capture_format_find(frmsize->pixel_format))
> + return -EINVAL;
> +
> + frmsize->type = V4L2_FRMSIZE_TYPE_STEPWISE;
> + frmsize->stepwise.min_width = SUN6I_ISP_CAPTURE_WIDTH_MIN;
> + frmsize->stepwise.max_width = SUN6I_ISP_CAPTURE_WIDTH_MAX;
> + frmsize->stepwise.min_height = SUN6I_ISP_CAPTURE_HEIGHT_MIN;
> + frmsize->stepwise.max_height = SUN6I_ISP_CAPTURE_HEIGHT_MAX;
> + frmsize->stepwise.step_width = 2;
> + frmsize->stepwise.step_height = 2;
> +
> + return 0;
> +}
> +
> static int sun6i_isp_capture_g_fmt(struct file *file, void *priv,
> struct v4l2_format *format)
> {
> @@ -522,6 +542,8 @@ static const struct v4l2_ioctl_ops sun6i_isp_capture_ioctl_ops = {
> .vidioc_s_fmt_vid_cap = sun6i_isp_capture_s_fmt,
> .vidioc_try_fmt_vid_cap = sun6i_isp_capture_try_fmt,
>
> + .vidioc_enum_framesizes = sun6i_isp_capture_enum_framesizes,
> +
> .vidioc_enum_input = sun6i_isp_capture_enum_input,
> .vidioc_g_input = sun6i_isp_capture_g_input,
> .vidioc_s_input = sun6i_isp_capture_s_input,
> --
> 2.54.0
>
Tested on a LicheePi Zero Dock (V3s) with the ov5647 camera setup.
The enum_framesizes implementation behaves as expected and reports the
supported even frame sizes correctly.
Tested-by: Arash Golgol <arash.golgol@gmail.com>
Reviewed-by: Arash Golgol <arash.golgol@gmail.com>
--
Regards,
Arash Golgol
^ permalink raw reply
* [PATCH 0/5] staging: sm750fb: various code cleanups
From: Ahmet Sezgin Duran @ 2026-05-23 5:15 UTC (permalink / raw)
To: gregkh; +Cc: linux-fbdev, linux-staging, linux-kernel, Ahmet Sezgin Duran
This series performs several cleanups on the sm750fb staging driver
to improve code readability and remove redundancy.
The changes include:
- Removing a block of commented-out forward declarations.
- Removing redundant variable initializations.
- Removing unused struct fields.
- Replacing a hardcoded loop bound with ARRAY_SIZE().
- Deduplicating per-index fbinfo handling in suspend/resume using
a loop.
No functional changes are intended.
Ahmet Sezgin Duran (5):
staging: sm750fb: remove commented-out forward declarations
staging: sm750fb: remove unnecessary initializations
staging: sm750fb: remove unused struct fields
staging: sm750fb: use ARRAY_SIZE macro in fb_find_mode loop
staging: sm750fb: deduplicate fbinfo loop in suspend/resume
drivers/staging/sm750fb/sm750.c | 47 ++++++++++-----------------------
drivers/staging/sm750fb/sm750.h | 3 ---
2 files changed, 14 insertions(+), 36 deletions(-)
base-commit: 7cb1c5b32a2bfde961fff8d5204526b609bcb30a
--
2.53.0
^ permalink raw reply
* [PATCH 2/5] staging: sm750fb: remove unnecessary initializations
From: Ahmet Sezgin Duran @ 2026-05-23 5:15 UTC (permalink / raw)
To: gregkh; +Cc: linux-fbdev, linux-staging, linux-kernel, Ahmet Sezgin Duran
In-Reply-To: <20260523051509.166152-1-ahmet@sezginduran.net>
Remove two instances of `ret = 0` initializations since the
variable is overridden unconditionally before being used.
Signed-off-by: Ahmet Sezgin Duran <ahmet@sezginduran.net>
---
drivers/staging/sm750fb/sm750.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 02db1418476b..fff9c35ee7b0 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -343,7 +343,6 @@ static int lynxfb_ops_set_par(struct fb_info *info)
if (!info)
return -EINVAL;
- ret = 0;
par = info->par;
crtc = &par->crtc;
output = &par->output;
@@ -463,7 +462,6 @@ static int lynxfb_ops_check_var(struct fb_var_screeninfo *var,
if (!var->pixclock)
return -EINVAL;
- ret = 0;
par = info->par;
crtc = &par->crtc;
--
2.53.0
^ permalink raw reply related
* [PATCH 3/5] staging: sm750fb: remove unused struct fields
From: Ahmet Sezgin Duran @ 2026-05-23 5:15 UTC (permalink / raw)
To: gregkh; +Cc: linux-fbdev, linux-staging, linux-kernel, Ahmet Sezgin Duran
In-Reply-To: <20260523051509.166152-1-ahmet@sezginduran.net>
Remove `void *priv` pointer field in following struct definitions:
- `struct lynxfb_crtc`
- `struct lynxfb_output`
Verified that no other code references them.
No functional changes.
Signed-off-by: Ahmet Sezgin Duran <ahmet@sezginduran.net>
---
drivers/staging/sm750fb/sm750.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
index d2c522e67f26..56d7e1fa4557 100644
--- a/drivers/staging/sm750fb/sm750.h
+++ b/drivers/staging/sm750fb/sm750.h
@@ -145,8 +145,6 @@ struct lynxfb_crtc {
u16 ypanstep;
u16 ywrapstep;
- void *priv;
-
/* cursor information */
struct lynx_cursor cursor;
};
@@ -168,7 +166,6 @@ struct lynxfb_output {
* *channel=1 means secondary channel
* output->channel ==> &crtc->channel
*/
- void *priv;
};
struct lynxfb_par {
--
2.53.0
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox