ARM Sunxi Platform Development
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Chris Morgan <macroalpha82@gmail.com>
Cc: samuel@sholland.org, conor+dt@kernel.org, krzk+dt@kernel.org,
	 Chris Morgan <macromorgan@hotmail.com>,
	devicetree@vger.kernel.org,  linux-sunxi@lists.linux.dev,
	jernej.skrabec@gmail.com, mripard@kernel.org,
	 andre.przywara@arm.com, ryan@testtoast.com, wens@csie.org
Subject: Re: [PATCH V2 0/4] Add Anbernic RG35XX-SP
Date: Wed, 03 Jul 2024 08:27:07 -0600	[thread overview]
Message-ID: <172001675758.274687.5859740689353342431.robh@kernel.org> (raw)
In-Reply-To: <20240702193414.57461-1-macroalpha82@gmail.com>


On Tue, 02 Jul 2024 14:34:10 -0500, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
> 
> Add support for the Anbernic RG35XX-SP handheld gaming device. The
> Anbernic RG35XX-SP is a clamshell device, but hardware wise is very
> similar to the RG35XX-Plus. The RG35XX-SP has a lid-switch and an
> external RTC that necessitate a distinct device tree.
> 
> Changes from V1:
>  - Switched all RG35XX devices from the r_rsb bus to the r_i2c bus for
>    the PMIC to keep it consistent.
>  - Added missing pinctrl nodes in sun50i-h616.dtsi file for the r_i2c
>    bus.
>  - Modified devicetree documentation to keep definition of the RG35XX
>    series consistent with other Allwinner devices.
> 
> Chris Morgan (4):
>   dt-bindings: arm: sunxi: Add Anbernic RG35XXSP
>   arm64: dts: allwinner: h616: Add r_i2c pinctrl nodes
>   arm64: dts: allwinner: h616: Change RG35XX Series from r_rsb to r_i2c
>   arm64: dts: allwinner: h700: Add Anbernic RG35XX-SP
> 
>  .../devicetree/bindings/arm/sunxi.yaml        |  9 +++--
>  arch/arm64/boot/dts/allwinner/Makefile        |  3 +-
>  .../arm64/boot/dts/allwinner/sun50i-h616.dtsi |  2 ++
>  .../sun50i-h700-anbernic-rg35xx-2024.dts      |  6 ++--
>  .../sun50i-h700-anbernic-rg35xx-sp.dts        | 34 +++++++++++++++++++
>  5 files changed, 48 insertions(+), 6 deletions(-)
>  create mode 100644 arch/arm64/boot/dts/allwinner/sun50i-h700-anbernic-rg35xx-sp.dts
> 
> --
> 2.34.1
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y allwinner/sun50i-h700-anbernic-rg35xx-2024.dtb allwinner/sun50i-h700-anbernic-rg35xx-sp.dtb' for 20240702193414.57461-1-macroalpha82@gmail.com:

arch/arm64/boot/dts/allwinner/sun50i-h700-anbernic-rg35xx-sp.dtb: pmic@34: regulators: 'boost' does not match any of the regexes: '^(([a-f])?ldo[0-9]|dcdc[0-7a-e]|ldo(_|-)io(0|1)|(dc1)?sw|rtc(_|-)ldo|cpusldo|drivevbus|dc5ldo)$', 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/mfd/x-powers,axp152.yaml#
arch/arm64/boot/dts/allwinner/sun50i-h700-anbernic-rg35xx-2024.dtb: pmic@34: regulators: 'boost' does not match any of the regexes: '^(([a-f])?ldo[0-9]|dcdc[0-7a-e]|ldo(_|-)io(0|1)|(dc1)?sw|rtc(_|-)ldo|cpusldo|drivevbus|dc5ldo)$', 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/mfd/x-powers,axp152.yaml#






      parent reply	other threads:[~2024-07-03 14:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-02 19:34 [PATCH V2 0/4] Add Anbernic RG35XX-SP Chris Morgan
2024-07-02 19:34 ` [PATCH V2 1/4] dt-bindings: arm: sunxi: Add Anbernic RG35XXSP Chris Morgan
2024-07-03  5:11   ` Krzysztof Kozlowski
2024-07-05 16:48     ` Chris Morgan
2024-07-02 19:34 ` [PATCH V2 2/4] arm64: dts: allwinner: h616: Add r_i2c pinctrl nodes Chris Morgan
2024-07-03 13:14   ` Andre Przywara
2024-07-03 23:39     ` Andre Przywara
2024-07-02 19:34 ` [PATCH V2 3/4] arm64: dts: allwinner: h616: Change RG35XX Series from r_rsb to r_i2c Chris Morgan
2024-07-02 19:34 ` [PATCH V2 4/4] arm64: dts: allwinner: h700: Add Anbernic RG35XX-SP Chris Morgan
2024-07-03 14:27 ` Rob Herring (Arm) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=172001675758.274687.5859740689353342431.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=andre.przywara@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=macroalpha82@gmail.com \
    --cc=macromorgan@hotmail.com \
    --cc=mripard@kernel.org \
    --cc=ryan@testtoast.com \
    --cc=samuel@sholland.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox